Skip to content

Commit bcdef09

Browse files
committed
Notifications - add a "Clear All Notifications" link to dropdown
Summary: Fixes T2576. Also hyperlinks "Notifications" and "Messages" for easier quick navigation to those areas. Maybe we could get rid of the "See All X" UI at the bottom and use these links? Test Plan: cleared all notifications from new UI - it worked! observed new linked "Notifications" and "Messages" headers Reviewers: chad, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T2576 Differential Revision: https://secure.phabricator.com/D8894
1 parent 3a06945 commit bcdef09

File tree

4 files changed

+35
-8
lines changed

4 files changed

+35
-8
lines changed

resources/celerity/map.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
return array(
88
'names' =>
99
array(
10-
'core.pkg.css' => 'a762d94d',
10+
'core.pkg.css' => 'b7ba02ba',
1111
'core.pkg.js' => '417722ff',
1212
'darkconsole.pkg.js' => 'ca8671ce',
1313
'differential.pkg.css' => '8a064eb7',
@@ -38,7 +38,7 @@
3838
'rsrc/css/aphront/typeahead.css' => '271456a1',
3939
'rsrc/css/application/auth/auth.css' => '1e655982',
4040
'rsrc/css/application/base/main-menu-view.css' => '0a599177',
41-
'rsrc/css/application/base/notification-menu.css' => 'fc9a363c',
41+
'rsrc/css/application/base/notification-menu.css' => '99ffef72',
4242
'rsrc/css/application/base/phabricator-application-launch-view.css' => 'd290ba21',
4343
'rsrc/css/application/base/standard-page-view.css' => '517cdfb1',
4444
'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
@@ -87,7 +87,7 @@
8787
'rsrc/css/application/phrequent/phrequent.css' => 'ffc185ad',
8888
'rsrc/css/application/phriction/phriction-document-css.css' => '7d7f0071',
8989
'rsrc/css/application/policy/policy-edit.css' => '05cca26a',
90-
'rsrc/css/application/policy/policy-transaction-detail.css' => '21b7daba',
90+
'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43',
9191
'rsrc/css/application/policy/policy.css' => '957ea14c',
9292
'rsrc/css/application/ponder/comments.css' => '6cdccea7',
9393
'rsrc/css/application/ponder/feed.css' => 'e62615b6',
@@ -705,7 +705,7 @@
705705
'phabricator-nav-view-css' => '80e60fc1',
706706
'phabricator-notification' => '0c6946e7',
707707
'phabricator-notification-css' => 'ef2c9b34',
708-
'phabricator-notification-menu-css' => 'fc9a363c',
708+
'phabricator-notification-menu-css' => '99ffef72',
709709
'phabricator-object-selector-css' => '029a133d',
710710
'phabricator-phtize' => 'd254d646',
711711
'phabricator-prefab' => '0326e5d0',
@@ -772,7 +772,7 @@
772772
'phui-workpanel-view-css' => '97b69459',
773773
'policy-css' => '957ea14c',
774774
'policy-edit-css' => '05cca26a',
775-
'policy-transaction-detail-css' => '21b7daba',
775+
'policy-transaction-detail-css' => '82100a43',
776776
'ponder-comment-table-css' => '6cdccea7',
777777
'ponder-feed-view-css' => 'e62615b6',
778778
'ponder-post-css' => 'ebab8a70',

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,12 @@ public function processRequest() {
8181
'<div class="phabricator-notification-header">%s</div>'.
8282
'%s'.
8383
'<div class="phabricator-notification-view-all">%s</div>',
84-
pht('Messages'),
84+
phutil_tag(
85+
'a',
86+
array(
87+
'href' => '/conpherence/',
88+
),
89+
pht('Messages')),
8590
$content,
8691
phutil_tag(
8792
'a',

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,23 @@ public function processRequest() {
2626
}
2727

2828
$content = hsprintf(
29-
'<div class="phabricator-notification-header">%s</div>'.
29+
'<div class="phabricator-notification-header">%s %s</div>'.
3030
'%s'.
3131
'<div class="phabricator-notification-view-all">%s</div>',
32-
pht('Notifications'),
32+
phutil_tag(
33+
'a',
34+
array(
35+
'href' => '/notification/',
36+
),
37+
pht('Notifications')),
38+
javelin_tag(
39+
'a',
40+
array(
41+
'sigil' => 'workflow',
42+
'href' => '/notification/clear/',
43+
'class' => 'phabricator-notification-clear-all'
44+
),
45+
pht('Clear All Notifications')),
3346
$content,
3447
phutil_tag(
3548
'a',

webroot/rsrc/css/application/base/notification-menu.css

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,15 @@
7474
border-bottom: 1px solid #e9e9e9;
7575
}
7676

77+
.phabricator-notification-header a {
78+
color: {$darkgreytext};
79+
}
80+
81+
.phabricator-notification-header .phabricator-notification-clear-all {
82+
color: #18559D;
83+
float: right;
84+
}
85+
7786
.phabricator-notification-view-all {
7887
text-align: center;
7988
font-weight: bold;

0 commit comments

Comments
 (0)