Skip to content

Commit bec21d8

Browse files
author
epriestley
committed
Don't try to import proxy columns
Summary: Fixes T10346. You finally wrung a clue out of the reporter and I think I figured this out. Here's the bug: - Create a project with a workboard and subprojects/milestones. - Create a new project, import columns from the first project. - We incorrectly import empty columns for the subprojects/milestons. Instead, skip proxy columns during import. Also, allow "hide column" to continue on missing fields, so columns with no name can be hidden. Test Plan: - Did the stuff above. - Workboard no longer populated with a bunch of "Unnamed Column" columns. - Hid several "Unnamed Column" columns. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10346 Differential Revision: https://secure.phabricator.com/D15265
1 parent 1e3a5bd commit bec21d8

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

src/applications/project/controller/PhabricatorProjectBoardImportController.php

+4
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@ public function handleRequest(AphrontRequest $request) {
5050
if ($import_column->isHidden()) {
5151
continue;
5252
}
53+
if ($import_column->getProxy()) {
54+
continue;
55+
}
56+
5357
$new_column = PhabricatorProjectColumn::initializeNewColumn($viewer)
5458
->setSequence($import_column->getSequence())
5559
->setProjectPHID($project->getPHID())

src/applications/project/controller/PhabricatorProjectColumnHideController.php

+1
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ public function handleRequest(AphrontRequest $request) {
9191
$editor = id(new PhabricatorProjectColumnTransactionEditor())
9292
->setActor($viewer)
9393
->setContinueOnNoEffect(true)
94+
->setContinueOnMissingFields(true)
9495
->setContentSourceFromRequest($request)
9596
->applyTransactions($column, $xactions);
9697
}

0 commit comments

Comments
 (0)