Various translation improvements

Summary: Depends on D14070.

Test Plan: Eyeball it.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D14073

Author: Joshua Spence

scripts/symbols/import_repository_symbols.php

@@ -102,7 +102,7 @@ function commit_symbols(
       $repository->getPHID());
   }
 
-  echo pht('Loading %s symbols...',  new PhutilNumber(count($sql))), "\n";
+  echo pht('Loading %s symbols...',  phutil_count($sql)), "\n";
   foreach (array_chunk($sql, 128) as $chunk) {
     queryfx(
       $conn_w,

src/applications/auth/controller/config/PhabricatorAuthListController.php

@@ -109,7 +109,7 @@ public function processRequest() {
         'only users with a verified email address at one of these %s '.
         'allowed domain(s) will be able to register an account: %s',
         $domains_link,
-        new PhutilNumber(count($domains_value)),
+        phutil_count($domains_value),
         phutil_tag('strong', array(), implode(', ', $domains_value)));
     } else {
       $issues[] = pht(

src/applications/auth/management/PhabricatorAuthManagementRefreshWorkflow.php

@@ -78,7 +78,7 @@ public function execute(PhutilArgumentParser $args) {
         "%s\n",
         pht(
           'Found %s account(s) to refresh.',
-          new PhutilNumber(count($accounts))));
+          phutil_count($accounts)));
     }
 
     $providers = PhabricatorAuthProvider::getAllEnabledProviders();

src/applications/celerity/management/CelerityManagementMapWorkflow.php

@@ -18,7 +18,7 @@ public function execute(PhutilArgumentParser $args) {
     $this->log(
       pht(
         'Rebuilding %d resource source(s).',
-        new PhutilNumber(count($resources_map))));
+        phutil_count($resources_map)));
 
     foreach ($resources_map as $name => $resources) {
       $this->rebuildResources($resources);

src/applications/config/check/PhabricatorDaemonsSetupCheck.php

@@ -115,7 +115,7 @@ protected function executeChecks() {
             $list_section = array(
               pht(
                 'The configurations differ in the following %s way(s):',
-                new PhutilNumber(count($issues))),
+                phutil_count($issues)),
               phutil_tag(
                 'ul',
                 array(),

src/applications/config/check/PhabricatorPathSetupCheck.php

@@ -111,7 +111,7 @@ protected function executeChecks() {
 
         $this
           ->newIssue('config.PATH.'.$digest)
-          ->setName(pht('$PATH Component Unusable'))
+          ->setName(pht('%s Component Unusable', '$PATH'))
           ->setSummary(
             pht(
               'A component of the configured PATH can not be used by '.

src/applications/config/view/PhabricatorSetupIssueView.php

@@ -387,7 +387,7 @@ private function renderPHPConfig(array $configs, $issue) {
         array(),
         pht(
           'PHP also loaded these %s configuration file(s):',
-          new PhutilNumber(count($more_loc))));
+          phutil_count($more_loc)));
       $info[] = phutil_tag(
         'pre',
         array(),

src/applications/conpherence/conduit/ConpherenceUpdateThreadConduitAPIMethod.php

@@ -29,14 +29,13 @@ protected function defineReturnType() {
   protected function defineErrorTypes() {
     return array(
       'ERR_USAGE_NO_ROOM_ID' => pht(
-        'You must specify a room id or room phid to query transactions '.
-        'from.'),
+        'You must specify a room ID or room PHID to query transactions from.'),
       'ERR_USAGE_ROOM_NOT_FOUND' => pht(
-        'room does not exist or logged in user can not see it.'),
+        'Room does not exist or logged in user can not see it.'),
       'ERR_USAGE_ONLY_SELF_REMOVE' => pht(
         'Only a user can remove themselves from a room.'),
       'ERR_USAGE_NO_UPDATES' => pht(
-        'You must specify data that actually updates the conpherence.'),
+        'You must specify data that actually updates the Conpherence.'),
     );
   }
 

src/applications/conpherence/controller/ConpherenceUpdateController.php

@@ -325,26 +325,22 @@ private function renderRemovePersonDialogue(
     $remove_person = $request->getStr('remove_person');
     $participants = $conpherence->getParticipants();
 
-    $message = pht(
-      'Are you sure you want to leave this room?');
+    $message = pht('Are you sure you want to leave this room?');
     $test_conpherence = clone $conpherence;
     $test_conpherence->attachParticipants(array());
     if (!PhabricatorPolicyFilter::hasCapability(
       $user,
       $test_conpherence,
       PhabricatorPolicyCapability::CAN_VIEW)) {
       if (count($participants) == 1) {
-        $message .= pht(
-          ' The room will be inaccessible forever and ever.');
+        $message .= ' '.pht('The room will be inaccessible forever and ever.');
       } else {
-        $message .= pht(
-          ' Someone else in the room can add you back later.');
+        $message .= ' '.pht('Someone else in the room can add you back later.');
       }
     }
     $body = phutil_tag(
       'p',
-      array(
-      ),
+      array(),
       $message);
 
     require_celerity_resource('conpherence-update-css');

src/applications/conpherence/storage/ConpherenceTransaction.php

@@ -77,14 +77,14 @@ public function getTitle() {
             count($rem));
         } else if ($add) {
           $title = pht(
-            '%s added %d files(s).',
+            '%s added %s files(s).',
             $this->renderHandleLink($author_phid),
-            count($add));
+            phutil_count($add));
         } else {
           $title = pht(
-            '%s removed %d file(s).',
+            '%s removed %s file(s).',
             $this->renderHandleLink($author_phid),
-            count($rem));
+            phutil_count($rem));
         }
         return $title;
         break;