Skip to content

Commit c4392ba

Browse files
author
Chad Little
committed
Add slugs to project manage page
Summary: Minor, just shows the slugs on the manage project page, also normalized language to "details" Test Plan: review a project with slugs, description. Reviewers: amckinley Reviewed By: amckinley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D17985
1 parent 684ce70 commit c4392ba

File tree

3 files changed

+15
-2
lines changed

3 files changed

+15
-2
lines changed

src/applications/project/controller/PhabricatorProjectController.php

+8
Original file line numberDiff line numberDiff line change
@@ -166,4 +166,12 @@ protected function newCardResponse($board_phid, $object_phid) {
166166
->buildResponse();
167167
}
168168

169+
public function renderHashtags(array $tags) {
170+
$result = array();
171+
foreach ($tags as $key => $tag) {
172+
$result[] = '#'.$tag;
173+
}
174+
return implode(', ', $result);
175+
}
176+
169177
}

src/applications/project/controller/PhabricatorProjectManageController.php

+6-1
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,12 @@ private function buildPropertyListView(
138138
pht('Looks Like'),
139139
$viewer->renderHandle($project->getPHID())->setAsTag(true));
140140

141+
$slugs = $project->getSlugs();
142+
$tags = mpull($slugs, 'getSlug');
143+
144+
$view->addProperty(
145+
pht('Hashtags'),
146+
$this->renderHashtags($tags));
141147

142148
$field_list = PhabricatorCustomField::getObjectFields(
143149
$project,
@@ -147,5 +153,4 @@ private function buildPropertyListView(
147153
return $view;
148154
}
149155

150-
151156
}

src/applications/project/controller/PhabricatorProjectProfileController.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ private function buildPropertyListView(
135135
}
136136

137137
$header = id(new PHUIHeaderView())
138-
->setHeader(pht('Properties'));
138+
->setHeader(pht('Details'));
139139

140140
$view = id(new PHUIObjectBoxView())
141141
->setHeader($header)

0 commit comments

Comments
 (0)