Convert all tokenizers to take token/scalar inputs

Summary: Ref T7689. Ref T4100. This advances the goals of removing `loadViewerHandles()` (only 67 callsites remain!) and letting tokenizers some day take token functions like `viewer()` and `members(differential)`.

Test Plan:
- Sent a new message; used "To".
  - I simplified the cancel URI construction slightly because it's moot in all normal cases.
- Edited a thread; used "Add Participants".
- Searched rooms; used "Participants".
- Searched countdowns; used "Authors".
- Created a diff; used "Repository".
- Edited a revision; edited "Projects"; edited "Reveiwers"; edited "Subscribers".
- Searched for revisions; edited "responsible users"; "authors"; "reviwers"; "subscribers"; "repositories".
- Added revision comments; edited "Add Reveiwers"; "Add Subscribers".
- Commented on a commit; edited "Add Auditors"; "Add subscribers".
- Edited a commit; edited "Projects".
- Edited a repository; edited "Projects".
- Searched feed, used "include Users"; "include Proejcts".
- Searched files, used "authors".
- Edited initiative; edited "Projects".
- Searched backers; used "Backers".
- Searched initiatives; used "Owners".
- Edited build plans; edited "Run Command".
- Searched Herald; used "Authors".
- Added signature exemption in Legalpad.
- Searhced legalpad; used "creators"; used "contributors".
- Searched signatures; used "documents"; used "signers".
- Created meme.
- Searched macros; used "Authors".
- Used "Projects" in Maniphest reports.
- Used Maniphest comment actions.
- Edited Maniphest tasks; edited "Assigned To"; edited "CC"; edited "projects".
- Used "parent" in Maniphest task creation workflow.
- Searched for projects; used "assigned to"; "in any projec"; "in all projects"; "not in projects"; "in users' projects"; "authors"; "subscribers".
- Edited Maniphest bug filing domains, used "Default Author".
- Searched for OAuth applications, used "Creators".
- Edited Owners pacakge; edited "Primary Owner"; edited "Owners".
- Searched for Owners packages; used "Owner".
  - OMG this UI is OLD
- Edited a paste; edited "Projects".
- Searched for paste; used "Authors".
- Searched user activity log; used "Actors"; used "Users".
- Edited a mock; edited "Projects"; edited "CC".
- Searched for mocks; used "Authors".
- Edited Phortune account; edited "Members".
- Edited Phortune merchant account; edited "Members".
- Searched Phrequent; used "Users".
- Edited Ponder question; sued "projects".
- Searched Ponder; used "Authors"; used "Answered By".
- Added project members.
- Searched for projects; used "Members".
- Edited a Releeph product; edited "Pushers".
- Searched pull requests; searched "Requestors".
- Edited an arcanist project; used "Uses Symbols From".
- Searhced push logs; used "Repositories"; used "Pushers".
- Searched repositories; used "In nay project".
- Used global search; used Authors/owners/Subscribers/In Any Project.
- Edited a slowvote; used "Projects".
- Searched slovotes; used "Authors".
- Created a custom "Users" field; edited and searched for it.
- Made a whole lot of typos in this list. ^^^^^^

Did not test:

- Lint is nontrivial to test locally, I'll test it in production.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100, T7689

Differential Revision: https://secure.phabricator.com/D12224

Author: epriestley

resources/celerity/map.php

@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '20d3b672',
+    'core.pkg.css' => 'ad650d52',
     'core.pkg.js' => '0c88e7f6',
     'darkconsole.pkg.js' => '8ab24e01',
     'differential.pkg.css' => '3500921f',
@@ -20,7 +20,7 @@
     'rsrc/css/aphront/dark-console.css' => '6378ef3d',
     'rsrc/css/aphront/dialog-view.css' => 'd2e76b88',
     'rsrc/css/aphront/lightbox-attachment.css' => '7acac05d',
-    'rsrc/css/aphront/list-filter-view.css' => '2ae43867',
+    'rsrc/css/aphront/list-filter-view.css' => '18b7e144',
     'rsrc/css/aphront/multi-column.css' => 'fd18389d',
     'rsrc/css/aphront/notification.css' => '9c279160',
     'rsrc/css/aphront/pager-view.css' => '2e3539af',
@@ -34,7 +34,7 @@
     'rsrc/css/aphront/typeahead.css' => '0e403212',
     'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af',
     'rsrc/css/application/auth/auth.css' => '1e655982',
-    'rsrc/css/application/base/main-menu-view.css' => 'cfa2ec0f',
+    'rsrc/css/application/base/main-menu-view.css' => '361a51f9',
     'rsrc/css/application/base/notification-menu.css' => '6aa0a74b',
     'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
     'rsrc/css/application/base/standard-page-view.css' => 'd2a6518d',
@@ -45,7 +45,7 @@
     'rsrc/css/application/config/setup-issue.css' => '22270af2',
     'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2',
     'rsrc/css/application/conpherence/durable-column.css' => 'caa12d4a',
-    'rsrc/css/application/conpherence/menu.css' => 'beef0920',
+    'rsrc/css/application/conpherence/menu.css' => '7c900089',
     'rsrc/css/application/conpherence/message-pane.css' => '44154798',
     'rsrc/css/application/conpherence/notification.css' => '04a6e10a',
     'rsrc/css/application/conpherence/update.css' => '1099a660',
@@ -355,7 +355,7 @@
     'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de',
     'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => 'bb928342',
     'rsrc/js/application/conpherence/behavior-durable-column.js' => 'a0216452',
-    'rsrc/js/application/conpherence/behavior-menu.js' => 'de5579b4',
+    'rsrc/js/application/conpherence/behavior-menu.js' => 'cda6de80',
     'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861',
     'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3',
     'rsrc/js/application/conpherence/behavior-widget-pane.js' => '1ec93bcf',
@@ -501,7 +501,7 @@
     'aphront-bars' => '231ac33c',
     'aphront-dark-console-css' => '6378ef3d',
     'aphront-dialog-view-css' => 'd2e76b88',
-    'aphront-list-filter-view-css' => '2ae43867',
+    'aphront-list-filter-view-css' => '18b7e144',
     'aphront-multi-column-view-css' => 'fd18389d',
     'aphront-pager-view-css' => '2e3539af',
     'aphront-panel-view-css' => '8427b78d',
@@ -515,7 +515,7 @@
     'config-options-css' => '7fedf08b',
     'config-welcome-css' => '6abd79be',
     'conpherence-durable-column-view' => 'caa12d4a',
-    'conpherence-menu-css' => 'beef0920',
+    'conpherence-menu-css' => '7c900089',
     'conpherence-message-pane-css' => '44154798',
     'conpherence-notification-css' => '04a6e10a',
     'conpherence-thread-manager' => 'bb928342',
@@ -557,7 +557,7 @@
     'javelin-behavior-boards-dropdown' => '0ec56e1d',
     'javelin-behavior-choose-control' => '6153c708',
     'javelin-behavior-config-reorder-fields' => '14a827de',
-    'javelin-behavior-conpherence-menu' => 'de5579b4',
+    'javelin-behavior-conpherence-menu' => 'cda6de80',
     'javelin-behavior-conpherence-pontificate' => '21ba5861',
     'javelin-behavior-conpherence-widget-pane' => '1ec93bcf',
     'javelin-behavior-countdown-timer' => 'e4cc26b3',
@@ -729,7 +729,7 @@
     'phabricator-hovercard-view-css' => '893f4783',
     'phabricator-keyboard-shortcut' => '1ae869f2',
     'phabricator-keyboard-shortcut-manager' => 'c1700f6f',
-    'phabricator-main-menu-view' => 'cfa2ec0f',
+    'phabricator-main-menu-view' => '361a51f9',
     'phabricator-nav-view-css' => '7aeaf435',
     'phabricator-notification' => '0c6946e7',
     'phabricator-notification-css' => '9c279160',
@@ -1755,6 +1755,18 @@
       'javelin-stratcom',
       'phabricator-phtize',
     ),
+    'cda6de80' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'javelin-stratcom',
+      'javelin-workflow',
+      'javelin-behavior-device',
+      'javelin-history',
+      'javelin-vector',
+      'phabricator-shaped-request',
+      'conpherence-thread-manager',
+    ),
     'd19198c8' => array(
       'javelin-install',
       'javelin-dom',
@@ -1807,18 +1819,6 @@
       'javelin-typeahead-ondemand-source',
       'javelin-dom',
     ),
-    'de5579b4' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'javelin-stratcom',
-      'javelin-workflow',
-      'javelin-behavior-device',
-      'javelin-history',
-      'javelin-vector',
-      'phabricator-shaped-request',
-      'conpherence-thread-manager',
-    ),
     'e10f8e18' => array(
       'javelin-behavior',
       'javelin-dom',

src/applications/conpherence/controller/ConpherenceNewController.php

@@ -53,25 +53,9 @@ public function handleRequest(AphrontRequest $request) {
       }
     }
 
-
-    $participant_handles = array();
-    if ($participants) {
-      $participant_handles = id(new PhabricatorHandleQuery())
-        ->setViewer($user)
-        ->withPHIDs($participants)
-        ->execute();
-    }
-
     $submit_uri = $this->getApplicationURI('new/');
     $cancel_uri = $this->getApplicationURI();
 
-    // TODO - we can get a better cancel_uri once we get better at crazy
-    // ajax jonx T2086
-    if ($participant_prefill) {
-      $handle = $participant_handles[$participant_prefill];
-      $cancel_uri = $handle->getURI();
-    }
-
     $dialog = id(new AphrontDialogView())
       ->setWidth(AphrontDialogView::WIDTH_FORM)
       ->setErrors($errors)
@@ -80,17 +64,17 @@ public function handleRequest(AphrontRequest $request) {
       ->addCancelButton($cancel_uri)
       ->addSubmitButton(pht('Send Message'));
 
-    $form = id(new PHUIFormLayoutView())
+    $form = id(new AphrontFormView())
       ->setUser($user)
       ->setFullWidth(true)
-      ->appendChild(
+      ->appendControl(
         id(new AphrontFormTokenizerControl())
-        ->setName('participants')
-        ->setValue($participant_handles)
-        ->setUser($user)
-        ->setDatasource(new PhabricatorPeopleDatasource())
-        ->setLabel(pht('To'))
-        ->setError($e_participants))
+          ->setName('participants')
+          ->setValue($participants)
+          ->setUser($user)
+          ->setDatasource(new PhabricatorPeopleDatasource())
+          ->setLabel(pht('To'))
+          ->setError($e_participants))
       ->appendChild(
         id(new PhabricatorRemarkupControl())
           ->setUser($user)
@@ -99,7 +83,7 @@ public function handleRequest(AphrontRequest $request) {
           ->setLabel(pht('Message'))
           ->setError($e_message));
 
-    $dialog->appendChild($form);
+    $dialog->appendForm($form);
 
     return id(new AphrontDialogResponse())->setDialog($dialog);
   }

src/applications/conpherence/controller/ConpherenceUpdateController.php

@@ -225,14 +225,14 @@ private function renderAddPersonDialogue(
     $user = $request->getUser();
     $add_person = $request->getStr('add_person');
 
-    $form = id(new PHUIFormLayoutView())
+    $form = id(new AphrontFormView())
       ->setUser($user)
       ->setFullWidth(true)
-      ->appendChild(
+      ->appendControl(
         id(new AphrontFormTokenizerControl())
-        ->setName('add_person')
-        ->setUser($user)
-        ->setDatasource(new PhabricatorPeopleDatasource()));
+          ->setName('add_person')
+          ->setUser($user)
+          ->setDatasource(new PhabricatorPeopleDatasource()));
 
     require_celerity_resource('conpherence-update-css');
     $view = id(new AphrontDialogView())
@@ -241,7 +241,7 @@ private function renderAddPersonDialogue(
       ->addHiddenInput(
         'latest_transaction_id',
         $request->getInt('latest_transaction_id'))
-      ->appendChild($form);
+      ->appendForm($form);
 
     if ($request->getExists('minimal_display')) {
       $view->addHiddenInput('minimal_display', true);

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

@@ -52,18 +52,15 @@ public function buildSearchForm(
     AphrontFormView $form,
     PhabricatorSavedQuery $saved) {
 
-    $phids = $saved->getParameter('participantPHIDs', array());
-    $participant_handles = id(new PhabricatorHandleQuery())
-      ->setViewer($this->requireViewer())
-      ->withPHIDs($phids)
-      ->execute();
+    $participant_phids = $saved->getParameter('participantPHIDs', array());
+
     $form
-      ->appendChild(
+      ->appendControl(
         id(new AphrontFormTokenizerControl())
-        ->setDatasource(new PhabricatorPeopleDatasource())
-        ->setName('participants')
-        ->setLabel(pht('Participants'))
-        ->setValue($participant_handles));
+          ->setDatasource(new PhabricatorPeopleDatasource())
+          ->setName('participants')
+          ->setLabel(pht('Participants'))
+          ->setValue($participant_phids));
   }
 
   protected function getURI($path) {

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

@@ -40,21 +40,17 @@ public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
   public function buildSearchForm(
     AphrontFormView $form,
     PhabricatorSavedQuery $saved_query) {
-    $phids = $saved_query->getParameter('authorPHIDs', array());
-    $author_handles = id(new PhabricatorHandleQuery())
-      ->setViewer($this->requireViewer())
-      ->withPHIDs($phids)
-      ->execute();
 
+    $author_phids = $saved_query->getParameter('authorPHIDs', array());
     $upcoming = $saved_query->getParameter('upcoming');
 
     $form
-      ->appendChild(
+      ->appendControl(
         id(new AphrontFormTokenizerControl())
           ->setDatasource(new PhabricatorPeopleDatasource())
           ->setName('authors')
           ->setLabel(pht('Authors'))
-          ->setValue($author_handles))
+          ->setValue($author_phids))
       ->appendChild(
         id(new AphrontFormCheckboxControl())
           ->addCheckbox(

src/applications/differential/controller/DifferentialDiffCreateController.php

@@ -28,7 +28,6 @@ public function handleRequest(AphrontRequest $request) {
     // This object is just for policy stuff
     $diff_object = DifferentialDiff::initializeNewDiff($viewer);
     $repository_phid = null;
-    $repository_value = array();
     $errors = array();
     $e_diff = null;
     $e_file = null;
@@ -62,7 +61,8 @@ public function handleRequest(AphrontRequest $request) {
             array(
               'diff' => $diff,
               'repositoryPHID' => $repository_phid,
-              'viewPolicy' => $request->getStr('viewPolicy'),));
+              'viewPolicy' => $request->getStr('viewPolicy'),
+            ));
           $call->setUser($viewer);
           $result = $call->execute();
 
@@ -93,10 +93,6 @@ public function handleRequest(AphrontRequest $request) {
 
     $cancel_uri = $this->getApplicationURI();
 
-    if ($repository_phid) {
-      $repository_value = $this->loadViewerHandles(array($repository_phid));
-    }
-
     $policies = id(new PhabricatorPolicyQuery())
       ->setViewer($viewer)
       ->setObject($diff_object)
@@ -148,6 +144,12 @@ public function handleRequest(AphrontRequest $request) {
           ->setValue($revision_handle->renderLink()));
     }
 
+    if ($repository_phid) {
+      $repository_value = array($repository_phid);
+    } else {
+      $repository_value = array();
+    }
+
     $form
       ->appendChild(
         id(new AphrontFormTextAreaControl())
@@ -161,20 +163,20 @@ public function handleRequest(AphrontRequest $request) {
           ->setLabel(pht('Raw Diff From File'))
           ->setName('diff-file')
           ->setError($e_file))
-      ->appendChild(
+      ->appendControl(
         id(new AphrontFormTokenizerControl())
-        ->setName(id(new DifferentialRepositoryField())->getFieldKey())
-        ->setLabel(pht('Repository'))
-        ->setDatasource(new DiffusionRepositoryDatasource())
-        ->setValue($repository_value)
-        ->setLimit(1))
+          ->setName(id(new DifferentialRepositoryField())->getFieldKey())
+          ->setLabel(pht('Repository'))
+          ->setDatasource(new DiffusionRepositoryDatasource())
+          ->setValue($repository_value)
+          ->setLimit(1))
       ->appendChild(
         id(new AphrontFormPolicyControl())
-        ->setUser($viewer)
-        ->setName('viewPolicy')
-        ->setPolicyObject($diff_object)
-        ->setPolicies($policies)
-        ->setCapability(PhabricatorPolicyCapability::CAN_VIEW))
+          ->setUser($viewer)
+          ->setName('viewPolicy')
+          ->setPolicyObject($diff_object)
+          ->setPolicies($policies)
+          ->setCapability(PhabricatorPolicyCapability::CAN_VIEW))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->addCancelButton($cancel_uri)

src/applications/differential/customfield/DifferentialProjectsField.php

@@ -49,15 +49,12 @@ public function readValueFromRequest(AphrontRequest $request) {
     $this->setValue($request->getArr($this->getFieldKey()));
   }
 
-  public function getRequiredHandlePHIDsForEdit() {
-    return $this->getValue();
-  }
-
   public function renderEditControl(array $handles) {
     return id(new AphrontFormTokenizerControl())
+      ->setUser($this->getViewer())
       ->setName($this->getFieldKey())
       ->setDatasource(new PhabricatorProjectDatasource())
-      ->setValue($handles)
+      ->setValue($this->getValue())
       ->setLabel($this->getFieldName());
   }
 

src/applications/differential/customfield/DifferentialRepositoryField.php

@@ -32,25 +32,18 @@ public function readValueFromRequest(AphrontRequest $request) {
     $this->setValue(nonempty($first, null));
   }
 
-  public function getRequiredHandlePHIDsForEdit() {
-    $phids = array();
-    if ($this->getValue()) {
-      $phids[] = $this->getValue();
-    }
-    return $phids;
-  }
-
   public function renderEditControl(array $handles) {
     if ($this->getValue()) {
-      $control_value = array_select_keys($handles, array($this->getValue()));
+      $value = array($this->getValue());
     } else {
-      $control_value = array();
+      $value = array();
     }
 
     return id(new AphrontFormTokenizerControl())
+      ->setUser($this->getViewer())
       ->setName($this->getFieldKey())
       ->setDatasource(new DiffusionRepositoryDatasource())
-      ->setValue($control_value)
+      ->setValue($value)
       ->setError($this->getFieldError())
       ->setLabel($this->getFieldName())
       ->setLimit(1);