Convert Conpherence to use normal picture setting flows

Summary: This moves room pictures out of the dialog and into it's own PictureController. Also adds a standard image (and removes the "last person to chat" picture (though we could add that back. My plan is though that direct messages use auto use the other person's photo, after we have editengine and room pictures will have a plain, replaceable image.

Test Plan: Set a new room picture, remove a picture. Run migration, see old images properly set with new image.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T11730

Differential Revision: https://secure.phabricator.com/D16669

Author: Chad Little

resources/builtin/conpherence.png

@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'conpherence.pkg.css' => '3c08b01f',
+    'conpherence.pkg.css' => '4601645d',
     'conpherence.pkg.js' => '11f3e07e',
     'core.pkg.css' => '3fa66cb3',
     'core.pkg.js' => '30185d95',
@@ -47,7 +47,7 @@
     'rsrc/css/application/config/setup-issue.css' => 'f794cfc3',
     'rsrc/css/application/config/unhandled-exception.css' => '4c96257a',
     'rsrc/css/application/conpherence/durable-column.css' => '44bcaa19',
-    'rsrc/css/application/conpherence/header-pane.css' => '6a032d4c',
+    'rsrc/css/application/conpherence/header-pane.css' => '20a7028c',
     'rsrc/css/application/conpherence/menu.css' => '4f51db5a',
     'rsrc/css/application/conpherence/message-pane.css' => '0d7dff02',
     'rsrc/css/application/conpherence/notification.css' => '965db05b',
@@ -618,7 +618,7 @@
     'config-options-css' => '0ede4c9b',
     'config-page-css' => '8798e14f',
     'conpherence-durable-column-view' => '44bcaa19',
-    'conpherence-header-pane-css' => '6a032d4c',
+    'conpherence-header-pane-css' => '20a7028c',
     'conpherence-menu-css' => '4f51db5a',
     'conpherence-message-pane-css' => '0d7dff02',
     'conpherence-notification-css' => '965db05b',

resources/celerity/map.php

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_conpherence.conpherence_thread
+  ADD profileImagePHID VARBINARY(64);

resources/sql/autopatches/20161005.conpherence.image.1.sql

@@ -0,0 +1,34 @@
+<?php
+
+// Rebuild all Conpherence Room images to profile standards
+//
+$table = new ConpherenceThread();
+$conn = $table->establishConnection('w');
+$table_name = 'conpherence_thread';
+
+foreach (new LiskRawMigrationIterator($conn, $table_name) as $row) {
+
+  $images = phutil_json_decode($row['imagePHIDs']);
+  if (!$images) {
+    return;
+  }
+
+  $file_phid = idx($images, 'original');
+
+  $file = id(new PhabricatorFileQuery())
+    ->setViewer(PhabricatorUser::getOmnipotentUser())
+    ->withPHIDs(array($file_phid))
+    ->executeOne();
+
+  $xform = PhabricatorFileTransform::getTransformByKey(
+    PhabricatorFileThumbnailTransform::TRANSFORM_PROFILE);
+  $xformed = $xform->executeTransform($file);
+  $new_phid = $xformed->getPHID();
+
+  queryfx(
+    $conn,
+    'UPDATE %T SET profileImagePHID = %s WHERE id = %d',
+    $table->getTableName(),
+    $new_phid,
+    $row['id']);
+}

resources/sql/autopatches/20161005.conpherence.image.2.php

@@ -292,7 +292,6 @@
     'ConpherenceEditor' => 'applications/conpherence/editor/ConpherenceEditor.php',
     'ConpherenceFormDragAndDropUploadControl' => 'applications/conpherence/view/ConpherenceFormDragAndDropUploadControl.php',
     'ConpherenceFulltextQuery' => 'applications/conpherence/query/ConpherenceFulltextQuery.php',
-    'ConpherenceImageData' => 'applications/conpherence/constants/ConpherenceImageData.php',
     'ConpherenceIndex' => 'applications/conpherence/storage/ConpherenceIndex.php',
     'ConpherenceLayoutView' => 'applications/conpherence/view/ConpherenceLayoutView.php',
     'ConpherenceListController' => 'applications/conpherence/controller/ConpherenceListController.php',
@@ -309,6 +308,7 @@
     'ConpherenceQueryTransactionConduitAPIMethod' => 'applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php',
     'ConpherenceReplyHandler' => 'applications/conpherence/mail/ConpherenceReplyHandler.php',
     'ConpherenceRoomListController' => 'applications/conpherence/controller/ConpherenceRoomListController.php',
+    'ConpherenceRoomPictureController' => 'applications/conpherence/controller/ConpherenceRoomPictureController.php',
     'ConpherenceRoomTestCase' => 'applications/conpherence/__tests__/ConpherenceRoomTestCase.php',
     'ConpherenceSchemaSpec' => 'applications/conpherence/storage/ConpherenceSchemaSpec.php',
     'ConpherenceTestCase' => 'applications/conpherence/__tests__/ConpherenceTestCase.php',
@@ -4768,7 +4768,6 @@
     'ConpherenceEditor' => 'PhabricatorApplicationTransactionEditor',
     'ConpherenceFormDragAndDropUploadControl' => 'AphrontFormControl',
     'ConpherenceFulltextQuery' => 'PhabricatorOffsetPagedQuery',
-    'ConpherenceImageData' => 'ConpherenceConstants',
     'ConpherenceIndex' => 'ConpherenceDAO',
     'ConpherenceLayoutView' => 'AphrontTagView',
     'ConpherenceListController' => 'ConpherenceController',
@@ -4785,6 +4784,7 @@
     'ConpherenceQueryTransactionConduitAPIMethod' => 'ConpherenceConduitAPIMethod',
     'ConpherenceReplyHandler' => 'PhabricatorMailReplyHandler',
     'ConpherenceRoomListController' => 'ConpherenceController',
+    'ConpherenceRoomPictureController' => 'ConpherenceController',
     'ConpherenceRoomTestCase' => 'ConpherenceTestCase',
     'ConpherenceSchemaSpec' => 'PhabricatorConfigSchemaSpec',
     'ConpherenceTestCase' => 'PhabricatorTestCase',

src/__phutil_library_map__.php

@@ -30,20 +30,31 @@ public function getRemarkupRules() {
 
   public function getRoutes() {
     return array(
-      '/Z(?P<id>[1-9]\d*)'         => 'ConpherenceViewController',
+      '/Z(?P<id>[1-9]\d*)'
+        => 'ConpherenceViewController',
       '/conpherence/' => array(
-        ''                         => 'ConpherenceListController',
-        'thread/(?P<id>[1-9]\d*)/' => 'ConpherenceListController',
-        '(?P<id>[1-9]\d*)/'        => 'ConpherenceViewController',
+        ''
+          => 'ConpherenceListController',
+        'thread/(?P<id>[1-9]\d*)/'
+          => 'ConpherenceListController',
+        '(?P<id>[1-9]\d*)/'
+          => 'ConpherenceViewController',
         '(?P<id>[1-9]\d*)/(?P<messageID>[1-9]\d*)/'
-                                   => 'ConpherenceViewController',
-        'columnview/'              => 'ConpherenceColumnViewController',
-        'new/'                     => 'ConpherenceNewRoomController',
+          => 'ConpherenceViewController',
+        'columnview/'
+          => 'ConpherenceColumnViewController',
+        'new/'
+          => 'ConpherenceNewRoomController',
+        'picture/(?P<id>[1-9]\d*)/'
+          => 'ConpherenceRoomPictureController',
         'search/(?:query/(?P<queryKey>[^/]+)/)?'
-           => 'ConpherenceRoomListController',
-        'panel/'                   => 'ConpherenceNotificationPanelController',
-        'participant/(?P<id>[1-9]\d*)/' => 'ConpherenceParticipantController',
-        'update/(?P<id>[1-9]\d*)/' => 'ConpherenceUpdateController',
+          => 'ConpherenceRoomListController',
+        'panel/'
+          => 'ConpherenceNotificationPanelController',
+        'participant/(?P<id>[1-9]\d*)/'
+          => 'ConpherenceParticipantController',
+        'update/(?P<id>[1-9]\d*)/'
+          => 'ConpherenceUpdateController',
       ),
     );
   }

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

@@ -16,7 +16,7 @@ public function handleRequest(AphrontRequest $request) {
       $latest_conpherences = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs($conpherence_phids)
-        ->needCropPics(true)
+        ->needProfileImage(true)
         ->needParticipantCache(true)
         ->execute();
       $latest_conpherences = mpull($latest_conpherences, null, 'getPHID');
@@ -31,7 +31,7 @@ public function handleRequest(AphrontRequest $request) {
       $conpherence = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withIDs(array($request->getInt('id')))
-        ->needCropPics(true)
+        ->needProfileImage(true)
         ->needTransactions(true)
         ->setTransactionLimit(ConpherenceThreadQuery::TRANSACTION_LIMIT)
         ->executeOne();
@@ -41,7 +41,7 @@ public function handleRequest(AphrontRequest $request) {
       $conpherence = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs(array($participant->getConpherencePHID()))
-        ->needCropPics(true)
+        ->needProfileImage(true)
         ->needTransactions(true)
         ->setTransactionLimit(ConpherenceThreadQuery::TRANSACTION_LIMIT)
         ->executeOne();

src/applications/conpherence/constants/ConpherenceImageData.php

@@ -66,6 +66,11 @@ protected function buildHeaderPaneContent(
         $conpherence,
         PhabricatorPolicyCapability::CAN_EDIT);
 
+      if ($can_edit) {
+        $header->setImageURL(
+          $this->getApplicationURI('picture/'.$conpherence->getID().'/'));
+      }
+
       $participating = $conpherence->getParticipantIfExists($viewer->getPHID());
       $can_join = PhabricatorPolicyFilter::hasCapability(
         $viewer,

src/applications/conpherence/controller/ConpherenceColumnViewController.php

@@ -158,7 +158,7 @@ private function loadConpherenceThreadData($participation) {
       $conpherences = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs($conpherence_phids)
-        ->needCropPics(true)
+        ->needProfileImage(true)
         ->needParticipantCache(true)
         ->execute();
 

src/applications/conpherence/controller/ConpherenceController.php

@@ -18,7 +18,7 @@ public function handleRequest(AphrontRequest $request) {
       $conpherences = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs(array_keys($participant_data))
-        ->needCropPics(true)
+        ->needProfileImage(true)
         ->needTransactions(true)
         ->setTransactionLimit(3 * 5)
         ->needParticipantCache(true)