Skip to content

Commit da1ed2c

Browse files
author
Chad Little
committed
Don't mark a thread as seen if durable column is minimized
Summary: More work to do here on the JS side, but this at least makes sure users with a small chat window have some notification marked that new replies have not been seen. Test Plan: Open two windows. Window 1 has durable minimized, Window 2 is full conpherence. Send a message from Window 2, see header count in Window 1 increase. Repeat with durable open, see no change in window. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16650
1 parent a591b86 commit da1ed2c

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/applications/conpherence/controller/ConpherenceUpdateController.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -607,8 +607,13 @@ private function loadAndRenderUpdates(
607607
$user,
608608
$conpherence,
609609
!$minimal_display);
610-
$participant_obj = $conpherence->getParticipant($user->getPHID());
611-
$participant_obj->markUpToDate($conpherence, $data['latest_transaction']);
610+
$key = PhabricatorConpherenceColumnMinimizeSetting::SETTINGKEY;
611+
$minimized = $user->getUserSetting($key);
612+
if (!$minimized) {
613+
$participant_obj = $conpherence->getParticipant($user->getPHID());
614+
$participant_obj
615+
->markUpToDate($conpherence, $data['latest_transaction']);
616+
}
612617
} else if ($need_transactions) {
613618
$non_update = true;
614619
$data = array();

0 commit comments

Comments
 (0)