Conpherenece - improve performance by not fetching data as often from D12347

Summary: Turns out the pertinent views don't use this data anyway. Additonally, change the remaining pathway to fetch 15% of the rows it fetched in D12347. Fixes T7815.

Test Plan: clicked around and things worked. my instance always feels snappy though

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7815

Differential Revision: https://secure.phabricator.com/D12399

Author: bobtrahan

src/applications/conpherence/controller/ConpherenceColumnViewController.php

@@ -16,7 +16,6 @@ public function handleRequest(AphrontRequest $request) {
       $latest_conpherences = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs($conpherence_phids)
-        ->needTransactions(true)
         ->needParticipantCache(true)
         ->execute();
       $latest_conpherences = mpull($latest_conpherences, null, 'getPHID');

src/applications/conpherence/controller/ConpherenceListController.php

@@ -138,7 +138,6 @@ private function loadConpherenceThreadData($participation) {
       $conpherences = id(new ConpherenceThreadQuery())
         ->setViewer($user)
         ->withPHIDs($conpherence_phids)
-        ->needTransactions(true)
         ->needParticipantCache(true)
         ->execute();
 

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

@@ -18,6 +18,7 @@ public function handleRequest(AphrontRequest $request) {
         ->setViewer($user)
         ->withPHIDs(array_keys($participant_data))
         ->needTransactions(true)
+        ->setTransactionLimit(3 * 5)
         ->needParticipantCache(true)
         ->execute();
     }

src/applications/conpherence/controller/ConpherenceUpdateController.php

@@ -380,14 +380,14 @@ private function loadAndRenderUpdates(
     $need_widget_data = false;
     $need_transactions = false;
     $need_participant_cache = true;
-    $need_transactions = true;
     switch ($action) {
       case ConpherenceUpdateActions::METADATA:
-        break;
       case ConpherenceUpdateActions::LOAD:
+        $need_transactions = true;
         break;
       case ConpherenceUpdateActions::MESSAGE:
       case ConpherenceUpdateActions::ADD_PERSON:
+        $need_transactions = true;
         $need_widget_data = true;
         break;
       case ConpherenceUpdateActions::REMOVE_PERSON:

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

@@ -27,7 +27,6 @@ public function buildSavedQueryFromRequest(AphrontRequest $request) {
 
   public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
     $query = id(new ConpherenceThreadQuery())
-      ->needTransactions(true)
       ->needParticipantCache(true);
 
     $participant_phids = $saved->getParameter('participantPHIDs', array());