Open
Description
I was attempting to patch Hack using alt-hack
, however before I did so I wanted to make sure that a default git clone
of this repo + a make ttf
would work. Doesn't seem to be doing the trick. I checked out the dev
branch and it seems to install fine from there, so not exactly sure what the issue is in the master
branch that is causing it.
Here's the full output from a clean git clone
/make ttf
of the master
branch:
./build-ttf.sh
Confirming that build dependencies are installed...
/usr/local/bin/fontmake
fontTools Python library identified
Starting build...
INFO:fontmake.font_project:Building TTF for Hack-Regular
INFO:ufo2ft:Pre-processing glyphs
INFO:ufo2ft.filters:Running DecomposeComponentsFilter on Hack-Regular
INFO:ufo2ft.filters:Running RemoveOverlapsFilter on Hack-Regular
INFO:ufo2ft.filters:Running CubicToQuadraticFilter on Hack-Regular
INFO:ufo2ft.filters.cubicToQuadratic:New spline lengths: 1: 4796, 2: 4109, 3: 519, 4: 85, 5: 15
INFO:ufo2ft:Building OpenType tables
INFO:fontmake.font_project:Saving master_ttf/Hack-Regular.ttf
INFO:fontmake.font_project:Building TTF for Hack-Bold
INFO:ufo2ft:Pre-processing glyphs
INFO:ufo2ft.filters:Running DecomposeComponentsFilter on Hack-Bold
INFO:ufo2ft.filters:Running RemoveOverlapsFilter on Hack-Bold
INFO:ufo2ft.filters:Running CubicToQuadraticFilter on Hack-Bold
INFO:ufo2ft.filters.cubicToQuadratic:New spline lengths: 1: 4605, 2: 4531, 3: 458, 4: 72, 5: 17, 6: 4, 7: 3
INFO:ufo2ft:Building OpenType tables
INFO:fontmake.font_project:Saving master_ttf/Hack-Bold.ttf
INFO:fontmake.font_project:Building TTF for Hack-Italic
INFO:ufo2ft:Pre-processing glyphs
INFO:ufo2ft.filters:Running DecomposeComponentsFilter on Hack-Italic
INFO:ufo2ft.filters:Running RemoveOverlapsFilter on Hack-Italic
INFO:ufo2ft.filters:Running CubicToQuadraticFilter on Hack-Italic
INFO:ufo2ft.filters.cubicToQuadratic:New spline lengths: 1: 5062, 2: 5211, 3: 531, 4: 94, 5: 13, 6: 1
INFO:ufo2ft:Building OpenType tables
INFO:fontmake.font_project:Saving master_ttf/Hack-Italic.ttf
INFO:fontmake.font_project:Building TTF for Hack-BoldItalic
INFO:ufo2ft:Pre-processing glyphs
INFO:ufo2ft.filters:Running DecomposeComponentsFilter on Hack-BoldItalic
INFO:ufo2ft.filters:Running RemoveOverlapsFilter on Hack-BoldItalic
INFO:ufo2ft.filters:Running CubicToQuadraticFilter on Hack-BoldItalic
INFO:ufo2ft.filters.cubicToQuadratic:New spline lengths: 1: 4902, 2: 5329, 3: 466, 4: 97, 5: 11, 6: 1
INFO:ufo2ft:Building OpenType tables
INFO:fontmake.font_project:Saving master_ttf/Hack-BoldItalic.ttf
Attempting DSIG table fixes with fontbakery...
master_ttf/Hack-Bold.ttf - successful DSIG table fix
master_ttf/Hack-BoldItalic.ttf - successful DSIG table fix
master_ttf/Hack-Italic.ttf - successful DSIG table fix
master_ttf/Hack-Regular.ttf - successful DSIG table fix
Attempting fstype fixes with fontbakery...
master_ttf/Hack-Bold.ttf - successful fstype fix
master_ttf/Hack-BoldItalic.ttf - successful fstype fix
master_ttf/Hack-Italic.ttf - successful fstype fix
master_ttf/Hack-Regular.ttf - successful fstype fix
Attempting ttfautohint hinting...
postbuild_processing/tt-hinting/Hack-Regular-TA.txt:3:1: invalid glyph name (0x204)
uni0023 touch 0,1,2,3,18,19,20,21,22,23,24,25,26,27,28,31 x 0.25 @ 13
^
Unable to execute ttfautohint on the Hack-Regular variant set. Build canceled.
make: *** [ttf] Error 1
Please let me know if you need anything else. I'm still running macOS 10.14.6.
Metadata
Metadata
Assignees
Labels
No labels
Activity
[-]Building Hack on macOS fails[/-][+]Building Hack on macOS 10.14.6 fails[/+]macintacos commentedon Oct 16, 2019
So the build of a "clean"
dev
branch works fine, but after I patch the font I'm getting a slightly different error, presumably due to the patching (the patching itself claimed to be successful, FWIW). For reference, all I was trying to do was change0
to its backslashing alternative:make ttf
of thedev
branch looks like the following:Both builds seem to fail on the
Attempting ttfautohint hinting...
step.macintacos commentedon Oct 16, 2019
Woops, accidentally closed this.
macintacos commentedon Oct 17, 2019
Please feel free to let me know if you need anything else for debugging! Would love to get this sorted so I can start using it.
chrissimpkins commentedon Oct 21, 2019
Sorry for the troubles! The fontmake compiler is renaming the glyphs by default in more recent releases than the source that was developed in the master branch. ttfautohint can't find the glyph names indicated in the Control Instructions Files.
Since you are on macOS, you will be fine with unhinted builds. Simply comment out the ttfautohint execution steps in the shell scripts and you should be able to build without issues. You don't need the hints on macOS. If you still run into problems, please let me know and I'll whip together a simple script as a workaround.
Edit: I think that the issue in your second step build from
dev
branch is that the outlines changed in the alternate zero so at least one of the points is no longer valid in the hinting files. You replaced zeroes in your build?chrissimpkins commentedon Oct 21, 2019
And I do recognize that there is a root problem that needs to be addressed here. I am trying to find time to get back to this project to clean it up... Sorry!
macintacos commentedon Dec 1, 2019
@chrissimpkins apologies for the delay here. I didn't actually get this to work (pretty sure I moved to using Meslo shortly after I created this issue), however I'm willing to test out any solutions you come up with.
Yep, I noted in this comment that I was trying to implement the slashed-0. Not sure if that helps point you in the right direction (the whole reason why I was doing this to begin with was to get the slashed-0 into the font build 🙂)
cetver commentedon Mar 7, 2020
This is OS - independent problem.
In dev branch glyph files named by symbol names, but in the rest by unicode representation
Fix:
rofrol commentedon Jul 28, 2021
@cetver Thanks. Full instruction for Windows 10 and zero glif https://github.com/kisswiki/kisswiki/blob/master/src/00other/font_Hack_customization.md#windows-10
mahmoudhossam commentedon Feb 14, 2022
I'm also getting this error on Manjaro Linux, this is not MacOS specific.
remd commentedon Apr 26, 2022
Getting this error on Ubuntu 20.04.4 LTS using
make build-with-dependencies
.Fix incorrect glyph names in TTF hinting files (source-foundry#500)
Rename glyphs from unicode to symbolic names in ttf hinting (see sour…
Fix incorrect glyph names in TTF hinting files (source-foundry#500)
kili-ilo commentedon Apr 16, 2025
@cetver's substitution approach (as implemented by @remd) seems to fix the first error, but a follow-up error about
invalid range
led me to just follow @remd in commenting-out the hinting for my overwritten glyph.0
with forward-slashed0
kili-ilo/Hack-with-slashed-0#2Fix incorrect glyph names in TTF hinting files (source-foundry#500)