Update README.md #16
Update README.md #16
Conversation
| @@ -119,7 +119,7 @@ Hello World! You've reached <?php print($_SERVER['REQUEST_URI']); ?> | |||
|
|
|||
| You should now have a directory structure like: | |||
|
|
|||
| ``` | |||
| ```yaml | |||
There was a problem hiding this comment.
This isn't yaml. We should leave it as plain text.
| @@ -145,10 +145,13 @@ $ sam deploy \ | |||
| Build the layer by: | |||
|
|
|||
| 1. Installing a Docker environment | |||
| 1. Running `make` | |||
| 2. Running `make` | |||
There was a problem hiding this comment.
The reason this is two "1"s is markdown will automatically convert it to a correctly numbered list. The "1" merely signifies that it's a numbered list, not the specific number that will be used when the markdown is rendered. By keeping everything "1" we don't have to fiddle with ensuring the numbers are correct when we insert new steps in the middle of numbered lists.
|
|
||
| This will launch a Docker container that will build php71.zip. | ||
|
|
||
| Example of installing other php modules: | ||
| https://medium.com/@narwy/stackery-php-lambda-layer-add-mysql-1e49f3f3160a |
There was a problem hiding this comment.
I would rather expand the documentation in this project than link to somewhere else for helpful instructions. Maybe you could help make the documentation in the extensions section above more clear instead?
|
I'm closing this PR out as there hasn't been any progress on it recently and it needs to be reworked to solve the core issue. |
Updated read me with link to example + small tweaks