Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

simplify querystring building #24

Closed

Conversation

ibejohn818
Copy link

  • simplify querystring building

@ibejohn818 ibejohn818 closed this Jan 17, 2019
Copy link
Member

@txase txase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this really does the right thing. For example, multiValueQueryStringParameters might have the following value:

    "multiValueQueryStringParameters":{
      "name":[
        "me"
      ],
      "multivalueName":[
        "you",
        "me"
      ]
    }

This corresponds to a url querystring like ?name=me&multivalueName=you&multivalueName=me

If you fed the same data into http_build_query, it would generate the following querystring: ?name[0]=me&multivalueName[0]=you&multivalueName[1]=me. (The square brackets [] would actually be url-encoded, but I left them unencoded to make it easier to understand here.)

Can you double check my thinking?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants