Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer

Differential Revision: https://phabricator.services.mozilla.com/D200582

Author: Standard8

.eslintrc.js

@@ -68,10 +68,15 @@ module.exports = {
   plugins: ["mozilla", "import", "json"],
   overrides: [
     {
-      // All .eslintrc.js files are in the node environment, so turn that
-      // on here.
-      // https://github.com/eslint/eslint/issues/13008
-      files: [".eslintrc.js"],
+      files: [
+        // All .eslintrc.js files are in the node environment, so turn that
+        // on here.
+        // https://github.com/eslint/eslint/issues/13008
+        ".eslintrc.js",
+        // *.config.js files are generally assumed to be configuration files
+        // based for node.
+        "*.config.?(m)js",
+      ],
       env: {
         node: true,
         browser: false,

browser/components/aboutwelcome/.eslintrc.js

@@ -43,7 +43,7 @@ module.exports = {
       },
     },
     {
-      files: ["./*.js", "content-src/**", "tests/unit/**"],
+      files: ["content-src/**", "tests/unit/**"],
       env: {
         node: true,
       },

browser/components/asrouter/.eslintrc.js

@@ -26,7 +26,7 @@ module.exports = {
       },
     },
     {
-      files: ["bin/**", "./*.js", "content-src/**", "tests/unit/**"],
+      files: ["bin/**", "content-src/**", "tests/unit/**"],
       env: {
         node: true,
       },

browser/components/newtab/.eslintrc.js

@@ -52,7 +52,6 @@ module.exports = {
       files: [
         "bin/**",
         "content-src/**",
-        "./*.js",
         "loaders/**",
         "tools/**",
         "test/unit/**",

browser/components/pocket/webpack.config.js

@@ -1,7 +1,6 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
-/* eslint-env node */
 
 module.exports = {
   mode: "production",

browser/components/storybook/custom-elements-manifest.config.mjs

@@ -10,8 +10,8 @@
 function removePrivateAndStaticFields() {
   return {
     packageLinkPhase({ customElementsManifest }) {
-      customElementsManifest?.modules?.forEach(module => {
-        module?.declarations?.forEach(declaration => {
+      customElementsManifest?.modules?.forEach(m => {
+        m?.declarations?.forEach(declaration => {
           if (declaration.members != null) {
             declaration.members = declaration.members.filter(member => {
               return (

devtools/client/debugger/babel.config.js

@@ -4,8 +4,6 @@
 
 "use strict";
 
-/* global __dirname */
-
 /**
  * NOTE: This file does not apply to builds in MC. This config is used for
  * our Jest tests and for webpack bundle builds.

devtools/client/debugger/jest-test.config.js

@@ -4,8 +4,6 @@
 
 "use strict";
 
-/* global __dirname */
-
 const sharedJestConfig = require(`${__dirname}/../shared/test-helpers/shared-jest.config`);
 
 module.exports = {

devtools/client/debugger/jest.config.js

@@ -4,8 +4,6 @@
 
 "use strict";
 
-/* global __dirname */
-
 const { resolve } = require("path");
 const rootDir = resolve(__dirname);
 module.exports = {

devtools/client/shared/sourceeditor/webpack.config.js

@@ -4,7 +4,6 @@
 
 "use strict";
 
-/* global __dirname */
 const path = require("path");
 
 module.exports = (env, argv) => {

devtools/client/shared/test-helpers/shared-jest.config.js

@@ -4,7 +4,6 @@
 
 "use strict";
 
-/* global __dirname */
 const fixturesDir = `${__dirname}/jest-fixtures`;
 
 module.exports = {