Bug 1877788 - Record reach for all messaging experiment features r=omc-reviewers,aminomancer

Differential Revision: https://phabricator.services.mozilla.com/D203829

Author: halemu

browser/components/asrouter/modules/ASRouter.sys.mjs

@@ -106,18 +106,10 @@ const TOPIC_EXPERIMENT_ENROLLMENT_CHANGED = "nimbus:enrollments-updated";
 const USE_REMOTE_L10N_PREF =
   "browser.newtabpage.activity-stream.asrouter.useRemoteL10n";
 
-// Experiment groups that need to report the reach event in Messaging-Experiments.
-// If you're adding new groups to it, make sure they're also added in the
-// `messaging_experiments.reach.objects` defined in "toolkit/components/telemetry/Events.yaml"
-const REACH_EVENT_GROUPS = [
-  "cfr",
-  "moments-page",
-  "infobar",
-  "spotlight",
-  "featureCallout",
-];
 const REACH_EVENT_CATEGORY = "messaging_experiments";
 const REACH_EVENT_METHOD = "reach";
+// Reach for the pbNewtab feature will be added in bug 1755401
+const NO_REACH_EVENT_GROUPS = ["pbNewtab"];
 
 export const MessageLoaderUtils = {
   STARTPAGE_VERSION,
@@ -405,7 +397,11 @@ export const MessageLoaderUtils = {
       // Add Reach messages from unenrolled sibling branches, provided we are
       // recording Reach events for this feature. If we are in a rollout, we do
       // not have sibling branches.
-      if (!REACH_EVENT_GROUPS.includes(featureId) || !experimentData) {
+      if (
+        NO_REACH_EVENT_GROUPS.includes(featureId) ||
+        !MESSAGING_EXPERIMENTS_DEFAULT_FEATURES.includes(featureId) ||
+        !experimentData
+      ) {
         continue;
       }
 

browser/components/asrouter/modules/MessagingExperimentConstants.sys.mjs

@@ -15,6 +15,10 @@
  * FeatureManifest.yaml. Conversely, messaging experiment features contain
  * actual messages, with the usual message keys like `template` and `targeting`.
  * @see FeatureManifest.yaml
+ * Messages delivered through these feature IDs record reach events, with the
+ * exception of "pbNewtab". If you're adding new features to this list, make
+ * sure they're also added in the `messaging_experiments.reach.objects` defined
+ * in "toolkit/components/telemetry/Events.yaml"
  */
 export const MESSAGING_EXPERIMENTS_DEFAULT_FEATURES = [
   "cfr",

toolkit/components/telemetry/Events.yaml

@@ -1550,7 +1550,18 @@ messaging_experiments:
       "moments_page",
       "infobar",
       "spotlight",
-      "featureCallout"
+      "featureCallout",
+      "fxms_message_1",
+      "fxms_message_2",
+      "fxms_message_3",
+      "fxms_message_4",
+      "fxms_message_5",
+      "fxms_message_6",
+      "fxms_message_7",
+      "fxms_message_8",
+      "fxms_message_9",
+      "fxms_message_10",
+      "fxms_message_11"
     ]
     methods: ["reach"]
     release_channel_collection: opt-out