Bug 1864896: Autofix unused function arguments (browser/components/sessionstore). r=sessionstore-reviewers,dao

Differential Revision: https://phabricator.services.mozilla.com/D202953

Author: Mossop

browser/components/sessionstore/ContentRestore.sys.mjs

@@ -417,7 +417,7 @@ ProgressListener.prototype = {
     this.webProgress.removeProgressListener(this);
   },
 
-  onStateChange(webProgress, request, stateFlags, status) {
+  onStateChange(webProgress, request, stateFlags, _status) {
     let { STATE_IS_WINDOW, STATE_STOP, STATE_START } =
       Ci.nsIWebProgressListener;
     if (!webProgress.isTopLevel || !(stateFlags & STATE_IS_WINDOW)) {

browser/components/sessionstore/ContentSessionStore.sys.mjs

@@ -195,7 +195,7 @@ class SessionHistoryListener extends Handler {
     });
   }
 
-  handleEvent(event) {
+  handleEvent() {
     this.collect();
   }
 
@@ -226,7 +226,7 @@ class SessionHistoryListener extends Handler {
   /**
    * @see nsIWebProgressListener.onStateChange
    */
-  onStateChange(webProgress, request, stateFlags, status) {
+  onStateChange(webProgress, request, stateFlags, _status) {
     // Ignore state changes for subframes because we're only interested in the
     // top-document starting or stopping its load.
     if (!webProgress.isTopLevel || webProgress.DOMWindow != this.mm.content) {

browser/components/sessionstore/RecentlyClosedTabsAndWindowsMenuUtils.sys.mjs

@@ -182,7 +182,7 @@ export var RecentlyClosedTabsAndWindowsMenuUtils = {
    * @param aEvent
    *        The command event when the user clicks the restore all menu item
    */
-  onRestoreAllWindowsCommand(aEvent) {
+  onRestoreAllWindowsCommand() {
     const count = lazy.SessionStore.getClosedWindowCount();
     for (let index = 0; index < count; index++) {
       lazy.SessionStore.undoCloseWindow(index);
@@ -265,7 +265,7 @@ function createEntry(
     element.removeAttribute("oncommand");
     element.addEventListener(
       "command",
-      event => {
+      () => {
         lazy.SessionStore.undoClosedTabFromClosedWindow(
           { sourceClosedId },
           aClosedTab.closedId

browser/components/sessionstore/SessionSaver.sys.mjs

@@ -210,7 +210,7 @@ var SessionSaverInternal = {
   /**
    * Observe idle/ active notifications.
    */
-  observe(subject, topic, data) {
+  observe(subject, topic) {
     switch (topic) {
       case "idle":
         this._isIdle = true;

browser/components/sessionstore/SessionStartup.sys.mjs

@@ -268,7 +268,7 @@ export var SessionStartup = {
   /**
    * Handle notifications
    */
-  observe(subject, topic, data) {
+  observe(subject, topic) {
     switch (topic) {
       case "sessionstore-windows-restored":
         Services.obs.removeObserver(this, "sessionstore-windows-restored");

browser/components/sessionstore/SessionStore.sys.mjs

@@ -1789,7 +1789,7 @@ var SessionStoreInternal = {
 
         break;
       case "SessionStore:restoreHistoryComplete":
-        this._restoreHistoryComplete(browser, data);
+        this._restoreHistoryComplete(browser);
         break;
       case "SessionStore:restoreTabContentStarted":
         this._restoreTabContentStarted(browser, data);
@@ -7039,7 +7039,7 @@ var SessionStoreInternal = {
         } catch {} // May have already gotten rid of the browser's webProgress.
       },
 
-      onStateChange(webProgress, request, stateFlags, status) {
+      onStateChange(webProgress, request, stateFlags) {
         if (
           webProgress.isTopLevel &&
           stateFlags & Ci.nsIWebProgressListener.STATE_IS_WINDOW &&
@@ -7100,7 +7100,7 @@ var SessionStoreInternal = {
       OnHistoryPurge() {},
       OnHistoryReplaceEntry() {},
 
-      onStateChange(webProgress, request, stateFlags, status) {
+      onStateChange(webProgress, request, stateFlags) {
         if (
           webProgress.isTopLevel &&
           stateFlags & Ci.nsIWebProgressListener.STATE_IS_WINDOW &&
@@ -7181,7 +7181,7 @@ var SessionStoreInternal = {
 
       this._tabStateRestorePromises.delete(browser.permanentKey);
 
-      this._restoreHistoryComplete(browser, data);
+      this._restoreHistoryComplete(browser);
     };
 
     promise.then(onResolve).catch(() => {});
@@ -7267,7 +7267,7 @@ var SessionStoreInternal = {
     }
   },
 
-  _restoreHistoryComplete(browser, data) {
+  _restoreHistoryComplete(browser) {
     let win = browser.ownerGlobal;
     let tab = win?.gBrowser.getTabForBrowser(browser);
     if (!tab) {
@@ -7680,7 +7680,7 @@ var DirtyWindows = {
     this._data.delete(window);
   },
 
-  clear(window) {
+  clear(_window) {
     this._data = new WeakMap();
   },
 };

browser/components/sessionstore/StartupPerformance.sys.mjs

@@ -153,7 +153,7 @@ export var StartupPerformance = {
     }, COLLECT_RESULTS_AFTER_MS);
   },
 
-  observe(subject, topic, details) {
+  observe(subject, topic) {
     try {
       switch (topic) {
         case "sessionstore-restoring-on-startup":

browser/components/sessionstore/content/aboutSessionRestore.js

@@ -325,31 +325,31 @@ var treeView = {
   setTree(treeBox) {
     this.treeBox = treeBox;
   },
-  getCellText(idx, column) {
+  getCellText(idx) {
     return gTreeData[idx].label;
   },
   isContainer(idx) {
     return "open" in gTreeData[idx];
   },
-  getCellValue(idx, column) {
+  getCellValue(idx) {
     return gTreeData[idx].checked;
   },
   isContainerOpen(idx) {
     return gTreeData[idx].open;
   },
-  isContainerEmpty(idx) {
+  isContainerEmpty() {
     return false;
   },
-  isSeparator(idx) {
+  isSeparator() {
     return false;
   },
   isSorted() {
     return false;
   },
-  isEditable(idx, column) {
+  isEditable() {
     return false;
   },
-  canDrop(idx, orientation, dt) {
+  canDrop() {
     return false;
   },
   getLevel(idx) {
@@ -438,10 +438,10 @@ var treeView = {
     return null;
   },
 
-  cycleHeader(column) {},
-  cycleCell(idx, column) {},
+  cycleHeader() {},
+  cycleCell() {},
   selectionChanged() {},
-  getColumnProperties(column) {
+  getColumnProperties() {
     return "";
   },
 };

browser/components/sessionstore/test/SessionStoreTestUtils.sys.mjs

@@ -100,7 +100,7 @@ export var SessionStoreTestUtils = {
       expectedTabsRestored = aState.windows.length;
     }
 
-    function onSSTabRestored(aEvent) {
+    function onSSTabRestored() {
       if (++tabsRestored == expectedTabsRestored) {
         // Remove the event listener from each window
         windows.forEach(function (win) {
@@ -118,7 +118,7 @@ export var SessionStoreTestUtils = {
 
     // Used to add our listener to further windows so we can catch SSTabRestored
     // coming from them when creating a multi-window state.
-    function windowObserver(aSubject, aTopic, aData) {
+    function windowObserver(aSubject, aTopic) {
       if (aTopic == "domwindowopened") {
         let newWindow = aSubject;
         newWindow.addEventListener(

browser/components/sessionstore/test/browser_354894_perwindowpb.js

@@ -133,7 +133,7 @@ let setupTest = async function (options, testFunction) {
    * Helper: Will observe and handle the notifications for us
    */
   let hitCount = 0;
-  function observer(aCancel, aTopic, aData) {
+  function observer(aCancel, aTopic) {
     // count so that we later may compare
     observing[aTopic]++;
 
@@ -415,7 +415,7 @@ add_task(async function test_open_close_restore_from_popup() {
     return;
   }
 
-  await setupTest({}, async function (newWin, obs) {
+  await setupTest({}, async function (newWin) {
     let newWin2 = await promiseNewWindowLoaded();
     await injectTestTabs(newWin2);