Bug 1864896: Autofix unused function arguments (webextensions). r=extension-reviewers,zombie

Differential Revision: https://phabricator.services.mozilla.com/D202999

Author: Mossop

browser/components/extensions/ExtensionBrowsingData.sys.mjs

@@ -18,7 +18,7 @@ ChromeUtils.defineESModuleGetters(lazy, {
 
 export class BrowsingDataDelegate {
   // Unused for now
-  constructor(extension) {}
+  constructor() {}
 
   // This method returns undefined for all data types that are _not_ handled by
   // this delegate.

browser/components/extensions/ExtensionControlledPopup.sys.mjs

@@ -155,7 +155,7 @@ export class ExtensionControlledPopup {
     );
   }
 
-  observe(subject, topic, data) {
+  observe(subject) {
     // Remove the observer here so we don't get multiple open() calls if we get
     // multiple observer events in quick succession.
     this.removeObserver();

browser/components/extensions/ExtensionPopups.sys.mjs

@@ -28,7 +28,7 @@ function promisePopupShown(popup) {
     } else {
       popup.addEventListener(
         "popupshown",
-        function (event) {
+        function () {
           resolve();
         },
         { once: true }
@@ -385,7 +385,7 @@ export class BasePopup {
   }
 
   unblockParser() {
-    this.browserReady.then(browser => {
+    this.browserReady.then(() => {
       if (this.destroyed) {
         return;
       }

browser/components/extensions/child/ext-devtools.js

@@ -7,7 +7,7 @@
 "use strict";
 
 this.devtools = class extends ExtensionAPI {
-  getAPI(context) {
+  getAPI() {
     return {
       devtools: {},
     };

browser/components/extensions/child/ext-menus.js

@@ -248,7 +248,7 @@ this.menusInternal = class extends ExtensionAPI {
           }
           pendingMenuEvent = {
             webExtContextData,
-            observe(subject, topic, data) {
+            observe(subject) {
               pendingMenuEvent = null;
               Services.obs.removeObserver(this, "on-prepare-contextmenu");
               subject = subject.wrappedJSObject;

browser/components/extensions/parent/ext-browser.js

@@ -108,7 +108,7 @@ global.clickModifiersFromEvent = event => {
 global.waitForTabLoaded = (tab, url) => {
   return new Promise(resolve => {
     windowTracker.addListener("progress", {
-      onLocationChange(browser, webProgress, request, locationURI, flags) {
+      onLocationChange(browser, webProgress, request, locationURI) {
         if (
           webProgress.isTopLevel &&
           browser.ownerGlobal.gBrowser.getTabForBrowser(browser) == tab &&

browser/components/extensions/parent/ext-browserAction.js

@@ -95,7 +95,7 @@ this.browserAction = class extends ExtensionAPIPersistent {
     return browserActionMap.get(extension);
   }
 
-  async onManifestEntry(entryName) {
+  async onManifestEntry() {
     let { extension } = this;
 
     let options =
@@ -341,7 +341,7 @@ this.browserAction = class extends ExtensionAPIPersistent {
         );
       },
 
-      onBeforeCommand: (event, node) => {
+      onBeforeCommand: event => {
         this.lastClickInfo = {
           button: event.button || 0,
           modifiers: clickModifiersFromEvent(event),

browser/components/extensions/parent/ext-chrome-settings-overrides.js

@@ -259,7 +259,7 @@ this.chrome_settings_overrides = class extends ExtensionAPI {
     await chrome_settings_overrides.removeEngine(id);
   }
 
-  async onManifestEntry(entryName) {
+  async onManifestEntry() {
     let { extension } = this;
     let { manifest } = extension;
     let homepageUrl = manifest.chrome_settings_overrides.homepage;

browser/components/extensions/parent/ext-commands.js

@@ -42,7 +42,7 @@ this.commands = class extends ExtensionAPIPersistent {
     return ExtensionShortcuts.removeCommandsFromStorage(extensionId);
   }
 
-  async onManifestEntry(entryName) {
+  async onManifestEntry() {
     let shortcuts = new ExtensionShortcuts({
       extension: this.extension,
       onCommand: name => this.emit("command", name),

browser/components/extensions/parent/ext-devtools-panels.js

@@ -593,7 +593,7 @@ this.devtools_panels = class extends ExtensionAPI {
               context,
               name: "devtools.panels.elements.onSelectionChanged",
               register: fire => {
-                const listener = eventName => {
+                const listener = () => {
                   fire.async();
                 };
                 toolboxSelectionObserver.on("selectionChanged", listener);