Skip to content

Commit 3b67d44

Browse files
committed
Bug 1814411 - Use moz-support-link for the protections-popup-shim-allow-learn-more labels in protectionsPanel.inc.xhtml. r=tgiles
Depends on D179594 Differential Revision: https://phabricator.services.mozilla.com/D179719
1 parent de17418 commit 3b67d44

File tree

2 files changed

+20
-26
lines changed

2 files changed

+20
-26
lines changed

browser/base/content/browser-siteProtections.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1350,16 +1350,6 @@ var gProtectionsHandler = {
13501350
for (let blocker of Object.values(this.blockers)) {
13511351
blocker.updateCategoryItem();
13521352
}
1353-
1354-
let baseURL = Services.urlFormatter.formatURLPref("app.support.baseURL");
1355-
let shimAllowLearnMoreURL =
1356-
baseURL + "smartblock-enhanced-tracking-protection";
1357-
1358-
document
1359-
.querySelectorAll(".protections-popup-shim-allow-learn-more")
1360-
.forEach(label => {
1361-
label.href = shimAllowLearnMoreURL;
1362-
});
13631353
}
13641354
},
13651355

browser/components/controlcenter/content/protectionsPanel.inc.xhtml

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -240,10 +240,11 @@
240240
<vbox flex="1">
241241
<description data-l10n-id="protections-panel-description-shim-allowed">
242242
</description>
243-
<label class="protections-popup-shim-allow-learn-more"
244-
is="text-link"
245-
data-l10n-id="protections-panel-description-shim-allowed-learn-more">
246-
</label>
243+
<html:a class="protections-popup-shim-allow-learn-more"
244+
is="moz-support-link"
245+
data-l10n-id="protections-panel-description-shim-allowed-learn-more"
246+
support-page="smartblock-enhanced-tracking-protection"
247+
/>
247248
</vbox>
248249
</hbox>
249250
</vbox>
@@ -269,10 +270,11 @@
269270
<vbox flex="1">
270271
<description data-l10n-id="protections-panel-description-shim-allowed">
271272
</description>
272-
<label class="protections-popup-shim-allow-learn-more"
273-
is="text-link"
274-
data-l10n-id="protections-panel-description-shim-allowed-learn-more">
275-
</label>
273+
<html:a class="protections-popup-shim-allow-learn-more"
274+
is="moz-support-link"
275+
data-l10n-id="protections-panel-description-shim-allowed-learn-more"
276+
support-page="smartblock-enhanced-tracking-protection"
277+
/>
276278
</vbox>
277279
</hbox>
278280
</vbox>
@@ -315,10 +317,11 @@
315317
<vbox flex="1">
316318
<description data-l10n-id="protections-panel-description-shim-allowed">
317319
</description>
318-
<label class="protections-popup-shim-allow-learn-more"
319-
is="text-link"
320-
data-l10n-id="protections-panel-description-shim-allowed-learn-more">
321-
</label>
320+
<html:a class="protections-popup-shim-allow-learn-more"
321+
is="moz-support-link"
322+
data-l10n-id="protections-panel-description-shim-allowed-learn-more"
323+
support-page="smartblock-enhanced-tracking-protection"
324+
/>
322325
</vbox>
323326
</hbox>
324327
</vbox>
@@ -344,10 +347,11 @@
344347
<vbox flex="1">
345348
<description data-l10n-id="protections-panel-description-shim-allowed">
346349
</description>
347-
<label class="protections-popup-shim-allow-learn-more"
348-
is="text-link"
349-
data-l10n-id="protections-panel-description-shim-allowed-learn-more">
350-
</label>
350+
<html:a class="protections-popup-shim-allow-learn-more"
351+
is="moz-support-link"
352+
data-l10n-id="protections-panel-description-shim-allowed-learn-more"
353+
support-page="smartblock-enhanced-tracking-protection"
354+
/>
351355
</vbox>
352356
</hbox>
353357
</vbox>

0 commit comments

Comments
 (0)