Bug 1817443 - move url loading method implementations from utilityOverlay.js into their own helper module, r=mossop

openLinkIn would really benefit from being split up a bit, and adding more
globals to the browser window is icky. Also, the story for opening new tabs if
you're not inside a window is a nightmare right now. Moving this code
to a module is a first step to making that story nicer.

I kept wrappers for all the functions I'm moving, and added the `window` as the
first argument. In the future we can update these functions to support being
called without a `window` ref. The one exception is getTopWin, where I updated
the callers in this patch.

I had to tweak the parameter detection of the different arguments supported by
openUILinkIn because forwarding calls means arguments.length is always larger
than 3... but then also removed it in the next commit.

Differential Revision: https://phabricator.services.mozilla.com/D170210

Author: gijsk

browser/base/content/browser.js

@@ -2808,7 +2808,7 @@ function openLocation(event) {
   }
 
   // If there's an open browser window, redirect the command there.
-  let win = getTopWin();
+  let win = URILoadingHelper.getTargetWindow(window);
   if (win) {
     win.focus();
     win.openLocation();
@@ -3947,7 +3947,7 @@ const BrowserSearch = {
       window.location.href != AppConstants.BROWSER_CHROME_URL ||
       gURLBar.readOnly
     ) {
-      let win = getTopWin({ skipPopups: true });
+      let win = URILoadingHelper.getTopWin(window, { skipPopups: true });
       if (win) {
         // If there's an open browser window, it should handle this command
         win.focus();

browser/base/content/test/contextMenu/browser_utilityOverlay.js

@@ -51,13 +51,12 @@ add_task(async function test_eventMatchesKey() {
   }
 });
 
-add_task(async function test_getTopWin() {
-  is(getTopWin(), window, "got top window");
+add_task(async function test_getTargetWindow() {
+  is(URILoadingHelper.getTargetWindow(window), window, "got top window");
 });
 
 add_task(async function test_openUILink() {
-  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
-  const kURL = "http://example.org/";
+  const kURL = "https://example.org/";
   let tab = await BrowserTestUtils.openNewForegroundTab(
     gBrowser,
     "about:blank"