Skip to content

Commit 3fda739

Browse files
author
Erica Wright
committed
Bug 1563586 - Add icons to graph legend. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D36977 --HG-- extra : moz-landing-system : lando
1 parent 38430c2 commit 3fda739

File tree

4 files changed

+30
-11
lines changed

4 files changed

+30
-11
lines changed

browser/components/protections/content/protections.css

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -215,32 +215,44 @@ input {
215215
display: none;
216216
}
217217

218-
label {
218+
#legend label {
219219
display: inline-block;
220220
margin: 0 0 -1px;
221-
padding: 15px 25px;
222-
font-weight: 600;
223-
text-align: center;
224-
border: 1px solid transparent;
221+
padding: 15px 23px;
222+
border: 3px solid transparent;
223+
-moz-context-properties: fill;
224+
background-repeat: no-repeat;
225+
background-position: left center;
226+
background-size: 16px;
225227
}
226228

227229
label[data-type="social"] {
230+
background-image: url(chrome://browser/skin/controlcenter/socialblock.svg);
231+
fill: var(--social-color);
228232
color: var(--social-color);
229233
}
230234

231235
label[data-type="crossSite"] {
236+
background-image: url(chrome://browser/skin/controlcenter/3rdpartycookies.svg);
237+
fill: var(--crossSite-color);
232238
color: var(--crossSite-color);
233239
}
234240

235241
label[data-type="tracker"] {
242+
background-image: url(chrome://browser/skin/controlcenter/trackers.svg);
243+
fill: var(--tracker-color);
236244
color: var(--tracker-color);
237245
}
238246

239247
label[data-type="fingerprinter"] {
248+
background-image: url(chrome://browser/skin/controlcenter/fingerprinters.svg);
249+
fill: var(--fingerprinter-color);
240250
color: var(--fingerprinter-color);
241251
}
242252

243253
label[data-type="cryptominer"] {
254+
background-image: url(chrome://browser/skin/controlcenter/cryptominers.svg);
255+
fill: var(--cryptominer-color);
244256
color: var(--cryptominer-color);
245257
}
246258

@@ -254,7 +266,7 @@ label:hover {
254266
cursor: pointer;
255267
}
256268

257-
input:checked + label {
269+
#legend input:checked + label {
258270
border-bottom: 3px solid var(--tab-highlight);
259271
}
260272

browser/components/protections/content/protections.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,19 +41,19 @@ <h3 class="card-title">
4141
<div id="graph"></div>
4242
<div id="legend">
4343
<input id="tab-social" data-type="social" type="radio" name="tabs" checked>
44-
<label for="tab-social" data-type="social">Social</label>
44+
<label for="tab-social" data-type="social">345</label>
4545

4646
<input id="tab-crossSite" data-type="crossSite" type="radio" name="tabs">
47-
<label for="tab-crossSite" data-type="crossSite">cross-site-tracker</label>
47+
<label for="tab-crossSite" data-type="crossSite">123</label>
4848

4949
<input id="tab-tracker" data-type="tracker" type="radio" name="tabs">
50-
<label for="tab-tracker" data-type="tracker">ad-tracker</label>
50+
<label for="tab-tracker" data-type="tracker">1</label>
5151

5252
<input id="tab-fingerprinter" data-type="fingerprinter" type="radio" name="tabs">
53-
<label for="tab-fingerprinter" data-type="fingerprinter">fingerprinter</label>
53+
<label for="tab-fingerprinter" data-type="fingerprinter">45666</label>
5454

5555
<input id="tab-cryptominer" data-type="cryptominer" type="radio" name="tabs">
56-
<label for="tab-cryptominer" data-type="cryptominer">cryptominer</label>
56+
<label for="tab-cryptominer" data-type="cryptominer">7</label>
5757

5858
<div id="social" class="tab-content">
5959
<p class="content-title">Social Media Trackers</p>
Lines changed: 6 additions & 0 deletions
Loading

browser/themes/shared/jar.inc.mn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
skin/classic/browser/controlcenter/fingerprinters-disabled.svg (../shared/controlcenter/fingerprinters-disabled.svg)
3737
skin/classic/browser/controlcenter/info.svg (../shared/controlcenter/info.svg)
3838
skin/classic/browser/controlcenter/permissions.svg (../shared/controlcenter/permissions.svg)
39+
skin/classic/browser/controlcenter/socialblock.svg (../shared/controlcenter/socialblock.svg)
3940
skin/classic/browser/controlcenter/trackers.svg (../shared/controlcenter/trackers.svg)
4041
skin/classic/browser/controlcenter/trackers-disabled.svg (../shared/controlcenter/trackers-disabled.svg)
4142
skin/classic/browser/controlcenter/tracking-protection.svg (../shared/controlcenter/tracking-protection.svg)

0 commit comments

Comments
 (0)