Backed out 5 changesets (bug 1817443) for newtab failure CLOSED TREE

Backed out changeset ba33c510d008 (bug 1817443)
Backed out changeset 07e3bccaeb6d (bug 1817443)
Backed out changeset 2b39dee42948 (bug 1817443)
Backed out changeset a74a52e93af4 (bug 1817443)
Backed out changeset 827855beb033 (bug 1817443)

Author: chorotan

browser/base/content/browser-menubar.inc

@@ -504,7 +504,7 @@
                           hidden="true"/>
                 <menuitem id="helpPolicySupport"
                           hidden="true"
-                          oncommand="openTrustedLinkIn(Services.policies.getSupportMenu().URL.href, 'tab');"/>
+                          oncommand="openUILinkIn(Services.policies.getSupportMenu().URL.href, 'tab', {triggeringPrincipal: Services.scriptSecurityManager.createNullPrincipal({})});"/>
               </menupopup>
           </menu>
         </menubar>

browser/base/content/browser.js

@@ -2808,7 +2808,7 @@ function openLocation(event) {
   }
 
   // If there's an open browser window, redirect the command there.
-  let win = URILoadingHelper.getTargetWindow(window);
+  let win = getTopWin();
   if (win) {
     win.focus();
     win.openLocation();
@@ -3947,7 +3947,7 @@ const BrowserSearch = {
       window.location.href != AppConstants.BROWSER_CHROME_URL ||
       gURLBar.readOnly
     ) {
-      let win = URILoadingHelper.getTopWin(window, { skipPopups: true });
+      let win = getTopWin({ skipPopups: true });
       if (win) {
         // If there's an open browser window, it should handle this command
         win.focus();

browser/base/content/test/about/browser_aboutNewTab_bookmarksToolbarNewWindow.js

@@ -33,7 +33,8 @@ async function test_bookmarks_toolbar_visibility({ newTabEnabled }) {
   let newWindowOpened = BrowserTestUtils.domWindowOpened();
   let beforeShown = TestUtils.topicObserved("browser-window-before-show");
 
-  openTrustedLinkIn(url, "window");
+  let triggeringPrincipal = Services.scriptSecurityManager.getSystemPrincipal();
+  openUILinkIn(url, "window", { triggeringPrincipal });
 
   let newWin = await newWindowOpened;
   let slowSiteLoaded = BrowserTestUtils.firstBrowserLoaded(newWin, false);

browser/base/content/test/contextMenu/browser_utilityOverlay.js

@@ -51,12 +51,13 @@ add_task(async function test_eventMatchesKey() {
   }
 });
 
-add_task(async function test_getTargetWindow() {
-  is(URILoadingHelper.getTargetWindow(window), window, "got top window");
+add_task(async function test_getTopWin() {
+  is(getTopWin(), window, "got top window");
 });
 
 add_task(async function test_openUILink() {
-  const kURL = "https://example.org/";
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
+  const kURL = "http://example.org/";
   let tab = await BrowserTestUtils.openNewForegroundTab(
     gBrowser,
     "about:blank"