Bug 1828679 - Set the preference signon.signupDetection.enabled to true to enable SignUpFormRuleset for all channels r=credential-management-reviewers,dimi

Differential Revision: https://phabricator.services.mozilla.com/D178659

Author: 1rneh

modules/libpref/init/all.js

@@ -3184,11 +3184,7 @@ pref("signon.firefoxRelay.manage_url", "https://relay.firefox.com");
 pref("signon.firefoxRelay.terms_of_service_url", "https://www.mozilla.org/%LOCALE%/about/legal/terms/subscription-services/");
 pref("signon.firefoxRelay.privacy_policy_url", "https://www.mozilla.org/%LOCALE%/privacy/subscription-services/");
 pref("signon.signupDetection.confidenceThreshold",     "0.75");
-#ifdef NIGHTLY_BUILD
-  pref("signon.signupDetection.enabled", true);
-#else
-  pref("signon.signupDetection.enabled", false);
-#endif
+pref("signon.signupDetection.enabled", true);
 
 // Satchel (Form Manager) prefs
 pref("browser.formfill.debug",            false);

toolkit/components/passwordmgr/LoginManagerChild.sys.mjs

@@ -596,21 +596,20 @@ export class LoginFormState {
     }
     const threshold = lazy.LoginHelper.signupDetectionConfidenceThreshold;
     let score = this.#cachedSignUpFormScore.get(formElement);
-    if (score) {
-      return score >= threshold;
-    }
-    TelemetryStopwatch.start("PWMGR_SIGNUP_FORM_DETECTION_MS");
-    try {
-      const { rules, type } = lazy.SignUpFormRuleset;
-      const results = rules.against(formElement);
-      score = results.get(formElement).scoreFor(type);
-      TelemetryStopwatch.finish("PWMGR_SIGNUP_FORM_DETECTION_MS");
-    } finally {
-      if (TelemetryStopwatch.running("PWMGR_SIGNUP_FORM_DETECTION_MS")) {
-        TelemetryStopwatch.cancel("PWMGR_SIGNUP_FORM_DETECTION_MS");
+    if (!score) {
+      TelemetryStopwatch.start("PWMGR_SIGNUP_FORM_DETECTION_MS");
+      try {
+        const { rules, type } = lazy.SignUpFormRuleset;
+        const results = rules.against(formElement);
+        score = results.get(formElement).scoreFor(type);
+        TelemetryStopwatch.finish("PWMGR_SIGNUP_FORM_DETECTION_MS");
+      } finally {
+        if (TelemetryStopwatch.running("PWMGR_SIGNUP_FORM_DETECTION_MS")) {
+          TelemetryStopwatch.cancel("PWMGR_SIGNUP_FORM_DETECTION_MS");
+        }
       }
+      this.#cachedSignUpFormScore.set(formElement, score);
     }
-    this.#cachedSignUpFormScore.set(formElement, score);
     return score > threshold;
   }