Bug 1836727 - [marionette] Fix MARIONETTE_MANIFESTS usage in moz.build files. r=webdriver-reviewers,necko-reviewers,application-update-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,Standard8,jesup,jdescottes,nalexander,sclements,janv

whimboo · whimboo · commit 5217f294ffc6 · 2024-01-11T10:34:29.000Z
Differential Revision: https://phabricator.services.mozilla.com/D197515
diff --git a/browser/components/migration/moz.build b/browser/components/migration/moz.build
@@ -6,7 +6,7 @@
 
 XPCSHELL_TESTS_MANIFESTS += ["tests/unit/xpcshell.toml"]
 
-MARIONETTE_UNIT_MANIFESTS += ["tests/marionette/manifest.toml"]
+MARIONETTE_MANIFESTS += ["tests/marionette/manifest.toml"]
 
 MOCHITEST_CHROME_MANIFESTS += ["tests/chrome/chrome.toml"]
 
diff --git a/browser/components/moz.build b/browser/components/moz.build
@@ -111,4 +111,6 @@ if CONFIG["MOZ_UPDATER"]:
         "tests/browser/whats_new_page/browser.toml",
     ]
 
+MARIONETTE_MANIFESTS += ["tests/marionette/manifest.toml"]
+
 XPCSHELL_TESTS_MANIFESTS += ["tests/unit/xpcshell.toml"]
diff --git a/browser/components/places/moz.build b/browser/components/places/moz.build
@@ -12,6 +12,7 @@ BROWSER_CHROME_MANIFESTS += [
     "tests/browser/browser.toml",
     "tests/browser/interactions/browser.toml",
 ]
+MARIONETTE_MANIFESTS += ["tests/marionette/manifest.toml"]
 
 JAR_MANIFESTS += ["jar.mn"]
 
diff --git a/browser/components/search/moz.build b/browser/components/search/moz.build
@@ -17,7 +17,7 @@ BROWSER_CHROME_MANIFESTS += [
     "test/browser/telemetry/browser.toml",
 ]
 
-MARIONETTE_UNIT_MANIFESTS += ["test/marionette/manifest.toml"]
+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]
 
 XPCSHELL_TESTS_MANIFESTS += ["test/unit/xpcshell.toml"]
 
diff --git a/browser/components/sessionstore/moz.build b/browser/components/sessionstore/moz.build
@@ -6,6 +6,7 @@
 
 XPCSHELL_TESTS_MANIFESTS += ["test/unit/xpcshell.toml"]
 BROWSER_CHROME_MANIFESTS += ["test/browser.toml"]
+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]
 
 JAR_MANIFESTS += ["jar.mn"]
 
diff --git a/dom/cache/moz.build b/dom/cache/moz.build
@@ -95,6 +95,8 @@ BROWSER_CHROME_MANIFESTS += [
     "test/browser/browser.toml",
 ]
 
+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]
+
 XPCSHELL_TESTS_MANIFESTS += [
     "test/xpcshell/xpcshell.toml",
 ]
diff --git a/dom/indexedDB/moz.build b/dom/indexedDB/moz.build
@@ -17,6 +17,8 @@ BROWSER_CHROME_MANIFESTS += ["test/browser.toml"]
 
 MOCHITEST_CHROME_MANIFESTS += ["test/chrome.toml"]
 
+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]
+
 XPCSHELL_TESTS_MANIFESTS += [
     "test/unit/xpcshell-child-process.toml",
     "test/unit/xpcshell-parent-process.toml",
diff --git a/dom/quota/test/moz.build b/dom/quota/test/moz.build
@@ -8,6 +8,8 @@ TEST_DIRS += ["gtest"]
 
 BROWSER_CHROME_MANIFESTS += ["browser/browser.toml"]
 
+MARIONETTE_MANIFESTS += ["marionette/manifest.toml"]
+
 MOCHITEST_MANIFESTS += ["mochitest/mochitest.toml"]
 
 XPCSHELL_TESTS_MANIFESTS += [
@@ -82,7 +84,3 @@ TESTING_JS_MODULES.dom.quota.test.modules.worker += [
     "modules/system/worker/Utils.js",
     "modules/system/worker/UtilsChild.js",
 ]
-
-MARIONETTE_UNIT_MANIFESTS += [
-    "marionette/manifest.toml",
-]
diff --git a/dom/workers/moz.build b/dom/workers/moz.build
@@ -107,6 +107,8 @@ MOCHITEST_CHROME_MANIFESTS += [
     "test/chrome.toml",
 ]
 
+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]
+
 XPCSHELL_TESTS_MANIFESTS += ["test/xpcshell/xpcshell.toml"]
 
 BROWSER_CHROME_MANIFESTS += ["test/browser.toml"]
diff --git a/extensions/pref/autoconfig/moz.build b/extensions/pref/autoconfig/moz.build
@@ -8,4 +8,4 @@ DIRS += ["src"]
 
 XPCSHELL_TESTS_MANIFESTS += ["test/unit/xpcshell.toml", "test/unit/xpcshell_snap.toml"]
 
-MARIONETTE_UNIT_MANIFESTS += ["test/marionette/manifest.toml"]
+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]
diff --git a/layout/base/moz.build b/layout/base/moz.build
@@ -183,6 +183,6 @@ IPDL_SOURCES += [
 FINAL_LIBRARY = "xul"
 
 BROWSER_CHROME_MANIFESTS += ["tests/browser.toml"]
-MARIONETTE_LAYOUT_MANIFESTS += ["tests/marionette/manifest.toml"]
+MARIONETTE_MANIFESTS += ["tests/marionette/manifest.toml"]
 MOCHITEST_MANIFESTS += ["tests/mochitest.toml"]
 MOCHITEST_CHROME_MANIFESTS += ["tests/chrome/chrome.toml"]
diff --git a/netwerk/test/moz.build b/netwerk/test/moz.build
@@ -27,9 +27,7 @@ TESTING_JS_MODULES += [
 
 PERFTESTS_MANIFESTS += ["perf/perftest.toml", "unit/perftest.toml"]
 
-MARIONETTE_UNIT_MANIFESTS += [
-    "marionette/manifest.toml",
-]
+MARIONETTE_MANIFESTS += ["marionette/manifest.toml"]
 
 if CONFIG["FUZZING_INTERFACES"]:
     TEST_DIRS += ["fuzz"]
diff --git a/python/mozbuild/mozbuild/frontend/context.py b/python/mozbuild/mozbuild/frontend/context.py
@@ -2208,16 +2208,10 @@ def aggregate(files):
         """List of manifest files defining firefox-ui-functional tests.
         """,
     ),
-    "MARIONETTE_LAYOUT_MANIFESTS": (
+    "MARIONETTE_MANIFESTS": (
         ManifestparserManifestList,
         list,
-        """List of manifest files defining marionette-layout tests.
-        """,
-    ),
-    "MARIONETTE_UNIT_MANIFESTS": (
-        ManifestparserManifestList,
-        list,
-        """List of manifest files defining marionette-unit tests.
+        """List of manifest files defining marionette tests.
         """,
     ),
     "METRO_CHROME_MANIFESTS": (
diff --git a/python/mozbuild/mozbuild/testing.py b/python/mozbuild/mozbuild/testing.py
@@ -48,11 +48,7 @@
         ".",
         False,
     ),
-    # marionette tests are run from the srcdir
-    # TODO(ato): make packaging work as for other test suites
     MARIONETTE=("marionette", "marionette", ".", False),
-    MARIONETTE_UNIT=("marionette", "marionette", ".", False),
-    MARIONETTE_WEBAPI=("marionette", "marionette", ".", False),
     MOCHITEST=("mochitest", "testing/mochitest", "tests", True),
     MOCHITEST_CHROME=("chrome", "testing/mochitest", "chrome", True),
     WEBRTC_SIGNALLING_TEST=("steeplechase", "steeplechase", ".", True),
diff --git a/testing/marionette/harness/marionette_harness/tests/unit-tests.toml b/testing/marionette/harness/marionette_harness/tests/unit-tests.toml
@@ -1,3 +1,14 @@
+# The tests within this file are exclusively executed when `mach marionette-test`
+# is called without specifying a test path. In case a specific test or manifest
+# is provided, only that particular test or manifest is executed. Alternatively,
+# by using a path prefix, any manifest file is recursively searched for under
+# the specified path.
+#
+# Note: When adding a new top-level manifest file please also add a reference
+# to the `MARIONETTE_MANIFESTS` entry in the appropriate `moz.build` file to
+# allow the execution of tests via `mach test` and as part of the test package
+# as well.
+
 [DEFAULT]
 # marionette unit tests
 ["include:unit/unit-tests.toml"]
diff --git a/testing/marionette/moz.build b/testing/marionette/moz.build
@@ -2,7 +2,7 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-MARIONETTE_UNIT_MANIFESTS += ["harness/marionette_harness/tests/unit/unit-tests.toml"]
+MARIONETTE_MANIFESTS += ["harness/marionette_harness/tests/unit/unit-tests.toml"]
 
 with Files("**"):
     BUG_COMPONENT = ("Testing", "Marionette Client and Harness")
diff --git a/toolkit/components/cleardata/moz.build b/toolkit/components/cleardata/moz.build
@@ -28,6 +28,8 @@ XPCSHELL_TESTS_MANIFESTS += ["tests/unit/xpcshell.toml"]
 
 BROWSER_CHROME_MANIFESTS += ["tests/browser/browser.toml"]
 
+MARIONETTE_MANIFESTS += ["tests/marionette/manifest.toml"]
+
 include("/ipc/chromium/chromium-config.mozbuild")
 
 with Files("**"):
diff --git a/toolkit/components/extensions/moz.build b/toolkit/components/extensions/moz.build
@@ -132,7 +132,7 @@ XPCSHELL_TESTS_MANIFESTS += [
 # in builds where they are enabled (currently only on Nightly builds).
 if CONFIG["MOZ_WEBEXT_WEBIDL_ENABLED"]:
     BROWSER_CHROME_MANIFESTS += ["test/browser/browser-serviceworker.toml"]
-    MARIONETTE_UNIT_MANIFESTS += ["test/marionette/manifest-serviceworker.toml"]
+    MARIONETTE_MANIFESTS += ["test/marionette/manifest-serviceworker.toml"]
     XPCSHELL_TESTS_MANIFESTS += [
         "test/xpcshell/webidl-api/xpcshell.toml",
         "test/xpcshell/xpcshell-serviceworker.ini",
diff --git a/toolkit/mozapps/update/moz.build b/toolkit/mozapps/update/moz.build
@@ -17,7 +17,7 @@ XPIDL_SOURCES += [
 ]
 
 TEST_DIRS += ["tests"]
-MARIONETTE_UNIT_MANIFESTS += ["tests/marionette/marionette.toml"]
+MARIONETTE_MANIFESTS += ["tests/marionette/marionette.toml"]
 
 EXTRA_COMPONENTS += [
     "nsUpdateService.manifest",
diff --git a/toolkit/xre/moz.build b/toolkit/xre/moz.build
@@ -15,7 +15,7 @@ if CONFIG["OS_ARCH"] == "WINNT":
 MOCHITEST_MANIFESTS += ["test/mochitest.toml"]
 BROWSER_CHROME_MANIFESTS += ["test/browser.toml"]
 XPCSHELL_TESTS_MANIFESTS += ["test/xpcshell.toml"]
-MARIONETTE_UNIT_MANIFESTS += ["test/marionette/marionette.toml"]
+MARIONETTE_MANIFESTS += ["test/marionette/marionette.toml"]
 
 XPIDL_SOURCES += [
     "nsINativeAppSupport.idl",

Original file line number	Diff line number	Diff line change
`@@ -111,4 +111,6 @@ if CONFIG["MOZ_UPDATER"]:`
`111`	`111`	`"tests/browser/whats_new_page/browser.toml",`
`112`	`112`	`]`
`113`	`113`
	`114`	`+MARIONETTE_MANIFESTS += ["tests/marionette/manifest.toml"]`
	`115`	`+`
`114`	`116`	`XPCSHELL_TESTS_MANIFESTS += ["tests/unit/xpcshell.toml"]`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ BROWSER_CHROME_MANIFESTS += [`
`12`	`12`	`"tests/browser/browser.toml",`
`13`	`13`	`"tests/browser/interactions/browser.toml",`
`14`	`14`	`]`
	`15`	`+MARIONETTE_MANIFESTS += ["tests/marionette/manifest.toml"]`
`15`	`16`
`16`	`17`	`JAR_MANIFESTS += ["jar.mn"]`
`17`	`18`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ BROWSER_CHROME_MANIFESTS += [`
`17`	`17`	`"test/browser/telemetry/browser.toml",`
`18`	`18`	`]`
`19`	`19`
`20`		`-MARIONETTE_UNIT_MANIFESTS += ["test/marionette/manifest.toml"]`
	`20`	`+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]`
`21`	`21`
`22`	`22`	`XPCSHELL_TESTS_MANIFESTS += ["test/unit/xpcshell.toml"]`
`23`	`23`
Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,8 @@ BROWSER_CHROME_MANIFESTS += [`
`95`	`95`	`"test/browser/browser.toml",`
`96`	`96`	`]`
`97`	`97`
	`98`	`+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]`
	`99`	`+`
`98`	`100`	`XPCSHELL_TESTS_MANIFESTS += [`
`99`	`101`	`"test/xpcshell/xpcshell.toml",`
`100`	`102`	`]`
Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,8 @@ MOCHITEST_CHROME_MANIFESTS += [`
`107`	`107`	`"test/chrome.toml",`
`108`	`108`	`]`
`109`	`109`
	`110`	`+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]`
	`111`	`+`
`110`	`112`	`XPCSHELL_TESTS_MANIFESTS += ["test/xpcshell/xpcshell.toml"]`
`111`	`113`
`112`	`114`	`BROWSER_CHROME_MANIFESTS += ["test/browser.toml"]`
Original file line number	Diff line number	Diff line change
`@@ -8,4 +8,4 @@ DIRS += ["src"]`
`8`	`8`
`9`	`9`	`XPCSHELL_TESTS_MANIFESTS += ["test/unit/xpcshell.toml", "test/unit/xpcshell_snap.toml"]`
`10`	`10`
`11`		`-MARIONETTE_UNIT_MANIFESTS += ["test/marionette/manifest.toml"]`
	`11`	`+MARIONETTE_MANIFESTS += ["test/marionette/manifest.toml"]`