Skip to content

Commit 57d4903

Browse files
nordzillanordzilla
committed
Bug 1875090 - Rename ContentTaskUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich
Renames all instances of the snake_case identifier to camelCase to match more closely to idiomatic JavaScript and to existing conventions throughout the code base. Differential Revision: https://phabricator.services.mozilla.com/D198831
1 parent 0350564 commit 57d4903

29 files changed

+88
-91
lines changed

‎browser/base/content/test/about/browser_aboutNetError.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ add_task(async function resetToDefaultConfig() {
6565

6666
const prefResetButton = doc.getElementById("prefResetButton");
6767
await ContentTaskUtils.waitForCondition(
68-
() => ContentTaskUtils.is_visible(prefResetButton),
68+
() => ContentTaskUtils.isVisible(prefResetButton),
6969
"prefResetButton is visible"
7070
);
7171

@@ -118,15 +118,12 @@ add_task(async function checkLearnMoreLink() {
118118

119119
const tlsVersionNotice = doc.getElementById("tlsVersionNotice");
120120
ok(
121-
ContentTaskUtils.is_visible(tlsVersionNotice),
121+
ContentTaskUtils.isVisible(tlsVersionNotice),
122122
"TLS version notice is visible"
123123
);
124124

125125
const learnMoreLink = doc.getElementById("learnMoreLink");
126-
ok(
127-
ContentTaskUtils.is_visible(learnMoreLink),
128-
"Learn More link is visible"
129-
);
126+
ok(ContentTaskUtils.isVisible(learnMoreLink), "Learn More link is visible");
130127
is(learnMoreLink.getAttribute("href"), _baseURL + "connection-not-secure");
131128

132129
const titleEl = doc.querySelector(".title-text");
@@ -182,7 +179,7 @@ add_task(async function checkDomainCorrection() {
182179
);
183180

184181
const errorNotice = doc.getElementById("errorShortDesc");
185-
ok(ContentTaskUtils.is_visible(errorNotice), "Error text is visible");
182+
ok(ContentTaskUtils.isVisible(errorNotice), "Error text is visible");
186183

187184
// Wait for the domain suggestion to be resolved and for the text to update
188185
let link;

‎browser/base/content/test/captivePortal/browser_captivePortal_certErrorUI.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ add_task(async function checkCaptivePortalCertErrorUI() {
4040
let doc = content.document;
4141
let loginButton = doc.getElementById("openPortalLoginPageButton");
4242
await ContentTaskUtils.waitForCondition(
43-
() => ContentTaskUtils.is_visible(loginButton),
43+
() => ContentTaskUtils.isVisible(loginButton),
4444
"Captive portal error page UI is visible"
4545
);
4646

@@ -121,22 +121,22 @@ add_task(async function testCaptivePortalAdvancedPanel() {
121121
const doc = content.document;
122122
let advancedButton = doc.getElementById("advancedButton");
123123
await ContentTaskUtils.waitForCondition(
124-
() => ContentTaskUtils.is_visible(advancedButton),
124+
() => ContentTaskUtils.isVisible(advancedButton),
125125
"Captive portal UI is visible"
126126
);
127127

128128
info("Clicking on the advanced button");
129129
const advPanel = doc.getElementById("badCertAdvancedPanel");
130130
ok(
131-
!ContentTaskUtils.is_visible(advPanel),
131+
!ContentTaskUtils.isVisible(advPanel),
132132
"Advanced panel is not yet visible"
133133
);
134134
await EventUtils.synthesizeMouseAtCenter(advancedButton, {}, content);
135-
ok(ContentTaskUtils.is_visible(advPanel), "Advanced panel is now visible");
135+
ok(ContentTaskUtils.isVisible(advPanel), "Advanced panel is now visible");
136136

137137
let advPanelContent = doc.getElementById("badCertTechnicalInfo");
138138
ok(
139-
ContentTaskUtils.is_visible(advPanelContent) &&
139+
ContentTaskUtils.isVisible(advPanelContent) &&
140140
advPanelContent.textContent.includes("expired.example.com"),
141141
"Advanced panel text content is visible"
142142
);
@@ -152,7 +152,7 @@ add_task(async function testCaptivePortalAdvancedPanel() {
152152
const advPanelExceptionButton = doc.getElementById("exceptionDialogButton");
153153

154154
function isOnCertErrorPage() {
155-
return ContentTaskUtils.is_visible(advPanel);
155+
return ContentTaskUtils.isVisible(advPanel);
156156
}
157157

158158
ok(isOnCertErrorPage(), "On cert error page before adding exception");

‎browser/base/content/test/captivePortal/browser_captivePortal_https_only.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ add_task(async function checkCaptivePortalExempt() {
3636
let doc = content.document;
3737
let loginButton = doc.getElementById("openPortalLoginPageButton");
3838
await ContentTaskUtils.waitForCondition(
39-
() => ContentTaskUtils.is_visible(loginButton),
39+
() => ContentTaskUtils.isVisible(loginButton),
4040
"Captive portal error page UI is visible"
4141
);
4242

‎browser/components/aboutlogins/tests/browser/browser_createLogin.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ add_task(async function test_create_login() {
8282
createButton.click();
8383

8484
Assert.ok(
85-
ContentTaskUtils.is_visible(loginList._blankLoginListItem),
85+
ContentTaskUtils.isVisible(loginList._blankLoginListItem),
8686
"the blank login list item should be visible after clicking on the create button"
8787
);
8888
Assert.ok(
@@ -92,7 +92,7 @@ add_task(async function test_create_login() {
9292

9393
let cancelButton = loginItem.shadowRoot.querySelector(".cancel-button");
9494
Assert.ok(
95-
ContentTaskUtils.is_visible(cancelButton),
95+
ContentTaskUtils.isVisible(cancelButton),
9696
"cancel button should be visible in create mode with no logins saved"
9797
);
9898

@@ -105,7 +105,7 @@ add_task(async function test_create_login() {
105105

106106
// Upon clicking create-login-button, the origin input field is automatically focused.
107107
Assert.ok(
108-
ContentTaskUtils.is_visible(loginItem._originWarning),
108+
ContentTaskUtils.isVisible(loginItem._originWarning),
109109
"The origin warning should be visible"
110110
);
111111

@@ -131,7 +131,7 @@ add_task(async function test_create_login() {
131131

132132
passwordInput.focus();
133133
Assert.ok(
134-
ContentTaskUtils.is_visible(loginItem._passwordWarning),
134+
ContentTaskUtils.isVisible(loginItem._passwordWarning),
135135
"The password warning should not visible"
136136
);
137137
passwordInput.value = "testpass1";
@@ -355,7 +355,7 @@ add_task(async function test_cancel_create_login() {
355355
"there should be no selected guid when in create mode"
356356
);
357357
Assert.ok(
358-
ContentTaskUtils.is_visible(loginList._blankLoginListItem),
358+
ContentTaskUtils.isVisible(loginList._blankLoginListItem),
359359
"the blank login list item should be visible in create mode"
360360
);
361361

@@ -405,7 +405,7 @@ add_task(
405405
);
406406
let cancelButton = loginItem.shadowRoot.querySelector(".cancel-button");
407407
Assert.ok(
408-
ContentTaskUtils.is_visible(cancelButton),
408+
ContentTaskUtils.isVisible(cancelButton),
409409
"cancel button should be visible in create mode with one login showing"
410410
);
411411
cancelButton.click();
@@ -451,7 +451,7 @@ add_task(async function test_cancel_create_login_with_logins_filtered_out() {
451451
let loginItem = Cu.waiveXrays(content.document.querySelector("login-item"));
452452
let cancelButton = loginItem.shadowRoot.querySelector(".cancel-button");
453453
Assert.ok(
454-
ContentTaskUtils.is_visible(cancelButton),
454+
ContentTaskUtils.isVisible(cancelButton),
455455
"cancel button should be visible in create mode with no logins showing"
456456
);
457457
cancelButton.click();

‎browser/components/aboutlogins/tests/browser/browser_openFiltered.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ add_task(async function test_query_parameter_filter() {
6161
);
6262

6363
Assert.ok(
64-
ContentTaskUtils.is_visible(loginItem),
64+
ContentTaskUtils.isVisible(loginItem),
6565
"login-item should be visible when a login is selected"
6666
);
6767
const loginIntro = content.document.querySelector("login-intro");
@@ -166,7 +166,7 @@ add_task(async function test_query_parameter_filter_no_logins_for_site() {
166166
".empty-search-message"
167167
);
168168
Assert.ok(
169-
ContentTaskUtils.is_visible(emptySearchMessage),
169+
ContentTaskUtils.isVisible(emptySearchMessage),
170170
"the empty search message should be visible when there is a search with no results"
171171
);
172172

@@ -198,7 +198,7 @@ add_task(async function test_query_parameter_filter_no_logins_for_site() {
198198
Assert.ok(loginItem.dataset.isNewLogin, "should be in create mode");
199199
Assert.ok(loginItem.dataset.editing, "should be in edit mode");
200200
Assert.ok(
201-
ContentTaskUtils.is_visible(loginItem),
201+
ContentTaskUtils.isVisible(loginItem),
202202
"login-item should be visible in create mode"
203203
);
204204
Assert.ok(
@@ -287,7 +287,7 @@ add_task(async function test_query_parameter_filter_no_login_until_backspace() {
287287
Assert.ok(loginItem.dataset.isNewLogin, "should be in create mode");
288288
Assert.ok(loginItem.dataset.editing, "should be in edit mode");
289289
Assert.ok(
290-
ContentTaskUtils.is_visible(loginItem),
290+
ContentTaskUtils.isVisible(loginItem),
291291
"login-item should be visible in create mode"
292292
);
293293
Assert.ok(

‎browser/components/aboutlogins/tests/browser/browser_primaryPassword.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ add_task(async function test() {
170170
".reveal-password-checkbox"
171171
);
172172
Assert.ok(
173-
!ContentTaskUtils.is_visible(revealCheckbox),
173+
!ContentTaskUtils.isVisible(revealCheckbox),
174174
"Toggle should not be visible"
175175
);
176176
Assert.equal(passwordField.type, "password", "type is password");

‎browser/components/preferences/tests/browser_defaultbrowser_alwayscheck.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ add_task(async function clicking_make_default_checks_alwaysCheck_checkbox() {
7777
"The 'browser is default' pane should be hidden when not default"
7878
);
7979
Assert.ok(
80-
ContentTaskUtils.is_visible(isNotDefaultPane),
80+
ContentTaskUtils.isVisible(isNotDefaultPane),
8181
"The 'make default' pane should be visible when not default"
8282
);
8383

@@ -97,7 +97,7 @@ add_task(async function clicking_make_default_checks_alwaysCheck_checkbox() {
9797
content.window.gMainPane.updateSetDefaultBrowser();
9898

9999
await ContentTaskUtils.waitForCondition(
100-
() => ContentTaskUtils.is_visible(isDefaultPane),
100+
() => ContentTaskUtils.isVisible(isDefaultPane),
101101
"Browser is now default"
102102
);
103103

‎browser/components/protections/test/browser/browser_protections_lockwise.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ add_task(async function testNoLoginsLockwiseCardUI() {
2727
await SpecialPowers.spawn(tab.linkedBrowser, [], async function () {
2828
await ContentTaskUtils.waitForCondition(() => {
2929
const lockwiseCard = content.document.querySelector(".lockwise-card");
30-
return ContentTaskUtils.is_visible(lockwiseCard);
30+
return ContentTaskUtils.isVisible(lockwiseCard);
3131
}, "Lockwise card for user with no logins is visible.");
3232

3333
const lockwiseHowItWorks = content.document.querySelector(
@@ -68,7 +68,7 @@ add_task(async function testNoLoginsLockwiseCardUI() {
6868
"#save-passwords-button"
6969
);
7070
ok(
71-
ContentTaskUtils.is_visible(savePasswordsButton),
71+
ContentTaskUtils.isVisible(savePasswordsButton),
7272
"Save passwords button is visible in the header"
7373
);
7474
info(
@@ -101,7 +101,7 @@ add_task(async function testLockwiseCardUIWithLogins() {
101101
await SpecialPowers.spawn(tab.linkedBrowser, [], async function () {
102102
await ContentTaskUtils.waitForCondition(() => {
103103
const hasLogins = content.document.querySelector(".lockwise-card");
104-
return ContentTaskUtils.is_visible(hasLogins);
104+
return ContentTaskUtils.isVisible(hasLogins);
105105
}, "Lockwise card for user with logins is visible");
106106

107107
const lockwiseTitle = content.document.querySelector("#lockwise-title");
@@ -120,7 +120,7 @@ add_task(async function testLockwiseCardUIWithLogins() {
120120
"#lockwise-how-it-works"
121121
);
122122
ok(
123-
ContentTaskUtils.is_visible(lockwiseHowItWorks),
123+
ContentTaskUtils.isVisible(lockwiseHowItWorks),
124124
"How it works link is visible"
125125
);
126126

@@ -138,7 +138,7 @@ add_task(async function testLockwiseCardUIWithLogins() {
138138
".lockwise-scanned-wrapper"
139139
);
140140
ok(
141-
ContentTaskUtils.is_visible(lockwiseScannedWrapper),
141+
ContentTaskUtils.isVisible(lockwiseScannedWrapper),
142142
"Lockwise scanned wrapper is visible"
143143
);
144144

@@ -164,7 +164,7 @@ add_task(async function testLockwiseCardUIWithLogins() {
164164
"#manage-passwords-button"
165165
);
166166
ok(
167-
ContentTaskUtils.is_visible(managePasswordsButton),
167+
ContentTaskUtils.isVisible(managePasswordsButton),
168168
"Manage passwords button is visible"
169169
);
170170
info(
@@ -221,7 +221,7 @@ add_task(async function testLockwiseCardUIWithBreachedLogins() {
221221
"#lockwise-scanned-text"
222222
);
223223
ok(
224-
ContentTaskUtils.is_visible(lockwiseScannedText),
224+
ContentTaskUtils.isVisible(lockwiseScannedText),
225225
"Lockwise scanned text is visible"
226226
);
227227
await ContentTaskUtils.waitForCondition(
@@ -244,7 +244,7 @@ add_task(async function testLockwiseCardUIWithBreachedLogins() {
244244
"#lockwise-scanned-text"
245245
);
246246
ok(
247-
ContentTaskUtils.is_visible(lockwiseScannedText),
247+
ContentTaskUtils.isVisible(lockwiseScannedText),
248248
"Lockwise scanned text is visible"
249249
);
250250
await ContentTaskUtils.waitForCondition(

‎browser/components/protections/test/browser/browser_protections_monitor.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ add_task(async function () {
5353
const hasLogins = content.document.querySelector(
5454
".monitor-card.has-logins"
5555
);
56-
return hasLogins && ContentTaskUtils.is_visible(hasLogins);
56+
return hasLogins && ContentTaskUtils.isVisible(hasLogins);
5757
}, "Monitor card for user with stored logins is shown.");
5858

5959
const hasLoginsHeaderContent = content.document.querySelector(
@@ -64,7 +64,7 @@ add_task(async function () {
6464
);
6565

6666
ok(
67-
ContentTaskUtils.is_visible(cardBody),
67+
ContentTaskUtils.isVisible(cardBody),
6868
"Card body is shown for users monitor data."
6969
);
7070
await ContentTaskUtils.waitForCondition(() => {
@@ -140,7 +140,7 @@ async function checkNoLoginsContentIsDisplayed(tab, expectedLinkContent) {
140140
const noLogins = content.document.querySelector(
141141
".monitor-card.no-logins"
142142
);
143-
return noLogins && ContentTaskUtils.is_visible(noLogins);
143+
return noLogins && ContentTaskUtils.isVisible(noLogins);
144144
}, "Monitor card for user with no logins is shown.");
145145

146146
const noLoginsHeaderContent = content.document.querySelector(

0 commit comments

Comments
 (0)