Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE

Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)

Author: Cristian Tuns

.eslintrc.js

@@ -68,15 +68,10 @@ module.exports = {
   plugins: ["mozilla", "import", "json"],
   overrides: [
     {
-      files: [
-        // All .eslintrc.js files are in the node environment, so turn that
-        // on here.
-        // https://github.com/eslint/eslint/issues/13008
-        ".eslintrc.js",
-        // *.config.js files are generally assumed to be configuration files
-        // based for node.
-        "*.config.?(m)js",
-      ],
+      // All .eslintrc.js files are in the node environment, so turn that
+      // on here.
+      // https://github.com/eslint/eslint/issues/13008
+      files: [".eslintrc.js"],
       env: {
         node: true,
         browser: false,

browser/components/aboutwelcome/.eslintrc.js

@@ -4,6 +4,11 @@
 
 module.exports = {
   // When adding items to this file please check for effects on sub-directories.
+  parserOptions: {
+    ecmaFeatures: {
+      jsx: true,
+    },
+  },
   plugins: ["import", "react", "jsx-a11y"],
   settings: {
     react: {
@@ -13,9 +18,8 @@ module.exports = {
   extends: ["plugin:jsx-a11y/recommended"],
   overrides: [
     {
-      // TODO: Bug 1773467 - Move these to .mjs or figure out a generic way
-      // to identify these as modules.
-      files: ["tests/unit/**/*.js"],
+      // Only mark the files as modules which are actually modules.
+      files: ["content-src/**", "tests/unit/**"],
       parserOptions: {
         sourceType: "module",
       },
@@ -38,7 +42,7 @@ module.exports = {
       },
     },
     {
-      files: ["content-src/**", "tests/unit/**"],
+      files: ["./*.js", "content-src/**", "tests/unit/**"],
       env: {
         node: true,
       },
@@ -56,6 +60,8 @@ module.exports = {
       rules: {
         // Disallow commonjs in these directories.
         "import/no-commonjs": 2,
+        // Allow JSX with arrow functions.
+        "react/jsx-no-bind": 0,
       },
     },
     {
@@ -76,6 +82,7 @@ module.exports = {
       rules: {
         "func-name-matching": 0,
         "lines-between-class-members": 0,
+        "require-await": 0,
       },
     },
   ],
@@ -84,10 +91,7 @@ module.exports = {
 
     "react/jsx-boolean-value": ["error", "always"],
     "react/jsx-key": "error",
-    "react/jsx-no-bind": [
-      "error",
-      { allowArrowFunctions: true, allowFunctions: true },
-    ],
+    "react/jsx-no-bind": "error",
     "react/jsx-no-comment-textnodes": "error",
     "react/jsx-no-duplicate-props": "error",
     "react/jsx-no-target-blank": "error",
@@ -123,15 +127,20 @@ module.exports = {
     "block-scoped-var": "error",
     "consistent-this": ["error", "use-bind"],
     eqeqeq: "error",
+    "for-direction": "error",
     "func-name-matching": "error",
     "getter-return": "error",
     "guard-for-in": "error",
+    "handle-callback-err": "error",
+    "lines-between-class-members": "error",
     "max-depth": ["error", 4],
     "max-nested-callbacks": ["error", 4],
     "max-params": ["error", 6],
     "max-statements": ["error", 50],
+    "max-statements-per-line": ["error", { max: 2 }],
     "new-cap": ["error", { newIsCap: true, capIsNew: false }],
     "no-alert": "error",
+    "no-buffer-constructor": "error",
     "no-console": ["error", { allow: ["error"] }],
     "no-div-regex": "error",
     "no-duplicate-imports": "error",
@@ -141,12 +150,16 @@ module.exports = {
     "no-implicit-coercion": ["error", { allow: ["!!"] }],
     "no-implicit-globals": "error",
     "no-loop-func": "error",
+    "no-mixed-requires": "error",
     "no-multi-assign": "error",
     "no-multi-str": "error",
     "no-new": "error",
     "no-new-func": "error",
+    "no-new-require": "error",
     "no-octal-escape": "error",
     "no-param-reassign": "error",
+    "no-path-concat": "error",
+    "no-process-exit": "error",
     "no-proto": "error",
     "no-prototype-builtins": "error",
     "no-return-assign": ["error", "except-parens"],
@@ -177,6 +190,7 @@ module.exports = {
     "prefer-spread": "error",
     "prefer-template": "error",
     radix: ["error", "always"],
+    "require-await": "error",
     "sort-vars": "error",
     "symbol-description": "error",
     "vars-on-top": "error",

browser/components/aboutwelcome/content-src/aboutwelcome.jsx

@@ -4,7 +4,7 @@
 
 import React from "react";
 import ReactDOM from "react-dom";
-import { AboutWelcomeUtils } from "./lib/aboutwelcome-utils.mjs";
+import { AboutWelcomeUtils } from "./lib/aboutwelcome-utils";
 import { MultiStageAboutWelcome } from "./components/MultiStageAboutWelcome";
 import { ReturnToAMO } from "./components/ReturnToAMO";
 

browser/components/aboutwelcome/content-src/components/AddonsPicker.jsx

@@ -3,7 +3,7 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import React from "react";
-import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils.mjs";
+import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils";
 import { Localized } from "./MSLocalized";
 
 export const AddonsPicker = props => {

browser/components/aboutwelcome/content-src/components/HelpText.jsx

@@ -4,7 +4,7 @@
 
 import React from "react";
 import { Localized } from "./MSLocalized";
-import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils.mjs";
+import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils";
 const MS_STRING_PROP = "string_id";
 
 export const HelpText = props => {

browser/components/aboutwelcome/content-src/components/HeroImage.jsx

@@ -3,7 +3,7 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import React from "react";
-import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils.mjs";
+import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils";
 
 export const HeroImage = props => {
   const { height, url, alt } = props;

browser/components/aboutwelcome/content-src/components/LanguageSwitcher.jsx

@@ -4,7 +4,7 @@
 
 import React, { useState, useEffect } from "react";
 import { Localized } from "./MSLocalized";
-import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils.mjs";
+import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils";
 
 /**
  * The language switcher implements a hook that should be placed at a higher level

browser/components/aboutwelcome/content-src/components/MobileDownloads.jsx

@@ -4,7 +4,7 @@
 
 import React from "react";
 import { Localized } from "./MSLocalized";
-import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils.mjs";
+import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils";
 
 export const MarketplaceButtons = props => {
   return (

browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx

@@ -4,11 +4,14 @@
 
 import React, { useState, useEffect, useRef } from "react";
 import { Localized } from "./MSLocalized";
-import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils.mjs";
+import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils";
 import { MultiStageProtonScreen } from "./MultiStageProtonScreen";
 import { useLanguageSwitcher } from "./LanguageSwitcher";
 import { SubmenuButton } from "./SubmenuButton";
-import { BASE_PARAMS, addUtmParams } from "../lib/addUtmParams.mjs";
+import {
+  BASE_PARAMS,
+  addUtmParams,
+} from "asrouter/content-src/templates/FirstRun/addUtmParams";
 
 // Amount of milliseconds for all transitions to complete (including delays).
 const TRANSITION_OUT_TIME = 1000;

browser/components/aboutwelcome/content-src/components/MultiStageProtonScreen.jsx

@@ -4,7 +4,7 @@
 
 import React, { useEffect, useState } from "react";
 import { Localized } from "./MSLocalized";
-import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils.mjs";
+import { AboutWelcomeUtils } from "../lib/aboutwelcome-utils";
 import { MobileDownloads } from "./MobileDownloads";
 import { MultiSelect } from "./MultiSelect";
 import { Themes } from "./Themes";