Backed out changeset e009aa26b6f7 (bug 1539477) for causing xpc crashes @ mozilla::SVGObserverUtils::RemoveRenderingObserver]

Sandor Molnar · Sandor Molnar · commit 8937518c8fc7 · 2023-10-16T13:50:46.000+03:00
diff --git a/layout/svg/SVGObserverUtils.cpp b/layout/svg/SVGObserverUtils.cpp
@@ -255,7 +255,8 @@ void SVGRenderingObserver::OnNonDOMMutationRenderingChange() {
 }
 
 void SVGRenderingObserver::NotifyEvictedFromRenderingObserverSet() {
-  StopObserving();  // Stop observing mutations.
+  mInObserverSet = false;  // We've been removed from rendering-obs. set.
+  StopObserving();         // Stop observing mutations too.
 }
 
 void SVGRenderingObserver::AttributeChanged(dom::Element* aElement,

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,8 @@ void SVGRenderingObserver::OnNonDOMMutationRenderingChange() {`
`255`	`255`	`}`
`256`	`256`
`257`	`257`	`void SVGRenderingObserver::NotifyEvictedFromRenderingObserverSet() {`
`258`		`- StopObserving(); // Stop observing mutations.`
	`258`	`+ mInObserverSet = false; // We've been removed from rendering-obs. set.`
	`259`	`+ StopObserving(); // Stop observing mutations too.`
`259`	`260`	`}`
`260`	`261`
`261`	`262`	`void SVGRenderingObserver::AttributeChanged(dom::Element* aElement,`