Bug 1856014 - Fix fluent schema for strings in protections panel. r=Gijs,fluent-reviewers,flod

Differential Revision: https://phabricator.services.mozilla.com/D191997

Author: dwalkr

browser/components/controlcenter/content/protectionsPanel.inc.xhtml

@@ -82,8 +82,8 @@
         <toolbarseparator></toolbarseparator>
         <vbox id="tracking-protection-container" class="protections-popup-section">
           <description id="protections-popup-no-trackers-found-description" data-l10n-id="protections-panel-no-trackers-found"></description>
-          <tooltip id="protections-popup-not-blocking-why-etp-on-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-on-tooltip"></tooltip>
-          <tooltip id="protections-popup-not-blocking-why-etp-off-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-off-tooltip"></tooltip>
+          <tooltip id="protections-popup-not-blocking-why-etp-on-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-on-tooltip-label"></tooltip>
+          <tooltip id="protections-popup-not-blocking-why-etp-off-tooltip" data-l10n-id="protections-panel-not-blocking-why-etp-off-tooltip-label"></tooltip>
           <vbox id="protections-popup-content" flex="1">
             <vbox id="protections-popup-category-list">
               <toolbarbutton id="protections-popup-category-trackers"
@@ -401,12 +401,12 @@
                     oncommand="gProtectionsHandler._protectionsPopupMultiView.goBack();"
                     class="footer-button" />
           <button id="protections-popup-cookieBannerView-enable-button"
-                    data-l10n-id="protections-panel-cookie-banner-view-turn-on"
+                    data-l10n-id="protections-panel-cookie-banner-view-turn-on-label"
                     oncommand="gProtectionsHandler.onCookieBannerToggleCommand()"
                     default="true"
                     class="footer-button" />
           <button id="protections-popup-cookieBannerView-disable-button"
-                    data-l10n-id="protections-panel-cookie-banner-view-turn-off"
+                    data-l10n-id="protections-panel-cookie-banner-view-turn-off-label"
                     oncommand="gProtectionsHandler.onCookieBannerToggleCommand()"
                     default="true"
                     class="footer-button" />

browser/locales/en-US/browser/protectionsPanel.ftl

@@ -51,8 +51,10 @@ protections-panel-site-not-working-view =
 ## a tooltip explaining why these items were not blocked in the page.
 
 protections-panel-not-blocking-why-label = Why?
-protections-panel-not-blocking-why-etp-on-tooltip = Blocking these could break elements of some websites. Without trackers, some buttons, forms, and login fields might not work.
-protections-panel-not-blocking-why-etp-off-tooltip = All trackers on this site have been loaded because protections are turned off.
+protections-panel-not-blocking-why-etp-on-tooltip-label =
+  .label = Blocking these could break elements of some websites. Without trackers, some buttons, forms, and login fields might not work.
+protections-panel-not-blocking-why-etp-off-tooltip-label =
+  .label = All trackers on this site have been loaded because protections are turned off.
 
 ##
 
@@ -142,5 +144,7 @@ protections-panel-cookie-banner-blocker-view-turn-on-for-site = Turn on Cookie B
 protections-panel-cookie-banner-view-cookie-clear-warning = { -brand-short-name } will clear this site’s cookies and refresh the page. Clearing all cookies may sign you out or empty shopping carts.
 protections-panel-cookie-banner-blocker-view-turn-on-description = Turn on and { -brand-short-name } will try to automatically refuse cookie banners on this site.
 protections-panel-cookie-banner-view-cancel = Cancel
-protections-panel-cookie-banner-view-turn-off = Turn Off
-protections-panel-cookie-banner-view-turn-on = Turn On
+protections-panel-cookie-banner-view-turn-off-label =
+  .label = Turn Off
+protections-panel-cookie-banner-view-turn-on-label =
+  .label = Turn On

python/l10n/fluent_migrations/bug_1856014_protectionsPanel_fixButtonLabels.py

@@ -0,0 +1,36 @@
+# Any copyright is dedicated to the Public Domain.
+# http://creativecommons.org/publicdomain/zero/1.0/
+
+from fluent.migrate.helpers import transforms_from
+
+
+def migrate(ctx):
+    """Bug 1856014 - Fix fluent schema for strings in protections panel, part {index}."""
+
+    file = "browser/browser/protectionsPanel.ftl"
+    ctx.add_transforms(
+        file,
+        file,
+        transforms_from(
+            """
+protections-panel-not-blocking-why-etp-on-tooltip-label =
+  .label = {COPY_PATTERN(from_path, "protections-panel-not-blocking-why-etp-on-tooltip")}
+protections-panel-not-blocking-why-etp-off-tooltip-label =
+  .label = {COPY_PATTERN(from_path, "protections-panel-not-blocking-why-etp-off-tooltip")}
+""",
+            from_path=file,
+        ),
+    )
+    ctx.add_transforms(
+        file,
+        file,
+        transforms_from(
+            """
+protections-panel-cookie-banner-view-turn-off-label =
+  .label = {COPY_PATTERN(from_path, "protections-panel-cookie-banner-view-turn-off")}
+protections-panel-cookie-banner-view-turn-on-label =
+  .label = {COPY_PATTERN(from_path, "protections-panel-cookie-banner-view-turn-on")}
+""",
+            from_path=file,
+        ),
+    )