Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE

Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)

Author: ncsoregi

browser/components/asrouter/actors/ASRouterChild.sys.mjs

@@ -43,7 +43,7 @@ export class ASRouterChild extends JSWindowActorChild {
     });
   }
 
-  handleEvent() {
+  handleEvent(event) {
     // DOMDocElementCreated is only used to create the actor.
   }
 

browser/components/asrouter/content-src/components/ASRouterAdmin/ASRouterAdmin.jsx

@@ -258,7 +258,7 @@ export class ASRouterAdminInner extends React.PureComponent {
     ASRouterUtils.sendMessage({ type: "RESET_PROVIDER_PREF" });
   }
 
-  resetGroups() {
+  resetGroups(id, value) {
     ASRouterUtils.sendMessage({
       type: "RESET_GROUPS_STATE",
     }).then(this.setStateFromParent);
@@ -387,7 +387,7 @@ export class ASRouterAdminInner extends React.PureComponent {
   }
 
   // Simulate a copy event that sets to clipboard all targeting paramters and values
-  onCopyTargetingParams() {
+  onCopyTargetingParams(event) {
     const stringTargetingParameters = {
       ...this.state.stringTargetingParameters,
     };
@@ -507,7 +507,7 @@ export class ASRouterAdminInner extends React.PureComponent {
             isBlocked ? null : isModified ? (
               <button
                 className="button restore"
-                onClick={() => this.resetJSON(msg)}
+                onClick={e => this.resetJSON(msg)}
               >
                 Reset
               </button>
@@ -523,7 +523,7 @@ export class ASRouterAdminInner extends React.PureComponent {
           {isBlocked ? null : (
             <button
               className="button modify"
-              onClick={() => this.modifyJson(msg)}
+              onClick={e => this.modifyJson(msg)}
             >
               Modify
             </button>
@@ -557,7 +557,7 @@ export class ASRouterAdminInner extends React.PureComponent {
                 name={msg.id}
                 className="general-textarea"
                 disabled={isBlocked}
-                onChange={() => this.handleChange(msg.id)}
+                onChange={e => this.handleChange(msg.id)}
               >
                 {JSON.stringify(msg, null, 2)}
               </textarea>
@@ -647,7 +647,7 @@ export class ASRouterAdminInner extends React.PureComponent {
           </button>
           <button
             className="ASRouterButton slim button"
-            onClick={() => this.resetPBJSON(msg)}
+            onClick={e => this.resetPBJSON(msg)}
           >
             Reset JSON
           </button>
@@ -698,7 +698,7 @@ export class ASRouterAdminInner extends React.PureComponent {
       <div>
         <button
           className="ASRouterButton slim"
-          onClick={() => this.toggleAllMessages(messagesToShow)}
+          onClick={e => this.toggleAllMessages(messagesToShow)}
         >
           Collapse/Expand All
         </button>
@@ -1046,7 +1046,7 @@ export class ASRouterAdminInner extends React.PureComponent {
     });
   }
 
-  setAttribution() {
+  setAttribution(e) {
     ASRouterUtils.sendMessage({
       type: "FORCE_ATTRIBUTION",
       data: this.state.attributionParameters,
@@ -1307,7 +1307,7 @@ export class ASRouterAdminInner extends React.PureComponent {
           <h2>Messages</h2>
           <button
             className="ASRouterButton slim button"
-            onClick={() => this.toggleAllMessages(messagesToShow)}
+            onClick={e => this.toggleAllMessages(messagesToShow)}
           >
             Collapse/Expand All
           </button>
@@ -1359,7 +1359,10 @@ export class ASRouterAdminInner extends React.PureComponent {
               <tbody>
                 {this.state.groups &&
                   this.state.groups.map(
-                    ({ id, enabled, frequency, userPreferences = [] }) => (
+                    (
+                      { id, enabled, frequency, userPreferences = [] },
+                      index
+                    ) => (
                       <Row key={id}>
                         <td>
                           <TogglePrefCheckbox

browser/components/asrouter/content-src/components/ASRouterAdmin/CopyButton.jsx

@@ -26,7 +26,7 @@ export const CopyButton = ({
     timeout.current = setTimeout(() => setCopied(false), 1500);
   }, [inputSelector, transformer]);
   return (
-    <button className={className} onClick={() => onClick()} {...props}>
+    <button className={className} onClick={e => onClick()} {...props}>
       {(copied && copiedLabel) || label}
     </button>
   );

browser/components/asrouter/modules/ASRouter.sys.mjs

@@ -947,7 +947,7 @@ export class _ASRouter {
     return this.state;
   }
 
-  async _onLocaleChanged() {
+  async _onLocaleChanged(subject, topic, data) {
     await this._maybeUpdateL10nAttachment();
   }
 
@@ -1743,7 +1743,7 @@ export class _ASRouter {
     }
     // Update storage
     this._storage.set("groupImpressions", newGroupImpressions);
-    return this.setState(() => ({
+    return this.setState(({ groups }) => ({
       groupImpressions: newGroupImpressions,
     }));
   }

browser/components/asrouter/modules/ASRouterTargeting.sys.mjs

@@ -576,7 +576,7 @@ const TargetingGetters = {
       lazy.fxAccounts
         .getSignedInUser()
         .then(data => resolve(!!data))
-        .catch(() => resolve(false));
+        .catch(e => resolve(false));
     });
   },
   get sync() {

browser/components/asrouter/modules/ASRouterTriggerListeners.sys.mjs

@@ -446,7 +446,7 @@ export const ASRouterTriggerListeners = new Map([
         }
       },
 
-      observe(aSubject, aTopic) {
+      observe(aSubject, aTopic, aData) {
         if (aSubject.currentURI.asciiHost === "accounts.firefox.com") {
           // Don't notify about saved logins on the FxA login origin since this
           // trigger is used to promote login Sync and getting a recommendation
@@ -562,7 +562,7 @@ export const ASRouterTriggerListeners = new Map([
       _sessionPageLoad: 0,
       onLocationChange: null,
 
-      init(triggerHandler, params) {
+      init(triggerHandler, params, patterns) {
         params.forEach(p => this._events.push(p));
 
         if (!this._initialized) {
@@ -610,7 +610,7 @@ export const ASRouterTriggerListeners = new Map([
         this._sessionPageLoad = 0;
       },
 
-      observe(aSubject, aTopic) {
+      observe(aSubject, aTopic, aData) {
         switch (aTopic) {
           case "SiteProtection:ContentBlockingEvent":
             const { browser, host, event } = aSubject.wrappedJSObject;
@@ -690,7 +690,7 @@ export const ASRouterTriggerListeners = new Map([
         this._triggerHandler = triggerHandler;
       },
 
-      observe(aSubject, aTopic) {
+      observe(aSubject, aTopic, aData) {
         switch (aTopic) {
           case "captive-portal-login-success":
             const browser = Services.wm.getMostRecentBrowserWindow();

browser/components/asrouter/modules/CFRPageActions.sys.mjs

@@ -792,7 +792,7 @@ export class PageAction {
    * Respond to a user click on the recommendation by showing a doorhanger/
    * popup notification or running the action defined in the message
    */
-  async _cfrUrlbarButtonClick() {
+  async _cfrUrlbarButtonClick(event) {
     const browser = this.window.gBrowser.selectedBrowser;
     if (!RecommendationMap.has(browser)) {
       // There's no recommendation for this browser, so the user shouldn't have

browser/components/asrouter/modules/FeatureCalloutBroker.sys.mjs

@@ -192,7 +192,7 @@ export class _FeatureCalloutBroker {
     return item;
   }
 
-  handleFeatureCalloutCallback(win, event) {
+  handleFeatureCalloutCallback(win, event, data) {
     switch (event) {
       case "end":
         const item = this.#calloutMap.get(win);

browser/components/asrouter/modules/ToastNotification.sys.mjs

@@ -123,7 +123,7 @@ export const ToastNotification = {
     }
 
     let shownPromise = Promise.withResolvers();
-    let obs = (subject, topic) => {
+    let obs = (subject, topic, data) => {
       if (topic === "alertshow") {
         shownPromise.resolve();
       }

browser/components/asrouter/modules/ToolbarBadgeHub.sys.mjs

@@ -81,7 +81,7 @@ export class _ToolbarBadgeHub {
     win.MozXULElement.insertFTLIfNeeded("browser/newtab/asrouter.ftl");
   }
 
-  executeAction({ id }) {
+  executeAction({ id, data, message_id }) {
     switch (id) {
       case "show-whatsnew-button":
         lazy.ToolbarPanelHub.enableToolbarButton();