Bug 1874177: enable macOS attribution reporting by default r=nalexander

Differential Revision: https://phabricator.services.mozilla.com/D198294

Author: bhearsum

browser/app/profile/firefox.js

@@ -2938,11 +2938,6 @@ pref("ui.new-webcompat-reporter.reason-dropdown", 0);
 // performing the clear action.
 pref("browser.privatebrowsing.resetPBM.showConfirmationDialog", true);
 
-// bug 1858545: Temporary pref to enable a staged rollout of macOS attribution Telemetry
-#ifdef XP_MACOSX
-  pref("browser.attribution.macos.enabled", false);
-#endif
-
 // the preferences related to the Nimbus experiment, to activate and deactivate
 // the the entire rollout or deactivate only the OS prompt (see: bug 1864216)
 pref("browser.mailto.dualPrompt", false);

browser/components/aboutwelcome/tests/browser/browser.toml

@@ -5,7 +5,6 @@ support-files = [
 
 prefs = [
   "intl.multilingual.aboutWelcome.languageMismatchEnabled=false",
-  "browser.attribution.macos.enabled=true",
 ]
 
 ["browser_aboutwelcome_attribution.js"]

browser/components/attribution/AttributionCode.sys.mjs

@@ -259,17 +259,6 @@ export var AttributionCode = {
       return gCachedAttrData;
     }
 
-    // This is a temporary block until we're ready to enable macOS reporting by default.
-    if (
-      AppConstants.platform == "macosx" &&
-      !Services.prefs.getBoolPref("browser.attribution.macos.enabled")
-    ) {
-      lazy.log.debug(
-        "getAttrDataSync: macOS attribution disabled by pref; skipping"
-      );
-      return {};
-    }
-
     gCachedAttrData = {};
 
     if (AppConstants.platform == "macosx") {

browser/components/attribution/test/browser/browser.toml

@@ -1,6 +1,5 @@
 [DEFAULT]
 support-files = ["head.js"]
-prefs = ["browser.attribution.macos.enabled=true"]
 
 ["browser_AttributionCode_Mac_telemetry.js"]
 skip-if = ["toolkit != 'cocoa'"] # macOS only telemetry.

browser/components/attribution/test/xpcshell/xpcshell.toml

@@ -5,7 +5,6 @@ run-if = [
     "os == 'mac'",
 ]
 head = "head.js"
-prefs = ["browser.attribution.macos.enabled=true"]
 
 ["test_AttributionCode.js"]
 

browser/components/newtab/test/xpcshell/xpcshell.toml

@@ -5,7 +5,6 @@ skip-if = ["toolkit == 'android'"] # bug 1730213
 prefs = [
   "browser.startup.homepage.abouthome_cache.enabled=true",
  "browser.startup.homepage.abouthome_cache.testing=true",
- "browser.attribution.macos.enabled=true",
 ]
 
 ["test_ASRouterTargeting_attribution.js"]

toolkit/components/telemetry/tests/unit/xpcshell.toml

@@ -21,7 +21,6 @@ generated-files = [
   "system.xpi",
   "restartless.xpi",
 ]
-prefs = ["browser.attribution.macos.enabled=true"]
 
 ["test_ChildEvents.js"]
 skip-if = ["os == 'android'"] # Disabled due to crashes (see bug 1331366)