Skip to content

Commit 9985c92

Browse files
committed
Bug 1864751 - Pt.2. Remove fail-if notations for a11y_checks of one-off-items in Search and Address Bar and Session Restore. r=adw,Jamie,sessionstore-reviewers,sclements
With the AccessibilityUtils tests updated in D193591 to pass a11y_checks for for keyboard focusable URL bar's `.searchbar-engine-one-off-item` buttons and `.urlbarView-row-inner` results options that are purposefully made focusable with arrow keys only (instead of a Tab that would create more tiring, cumbersome experience navigating Awesomebar for keyboard-only users), we could now remove the `fail-if` notations from a series of tests that were previously failing. Also, there are 12 tests that would also be affected, but they have other elements that are throwing warning or failing a11y_checks besides the one-off controls, thus we'd be keeping them to expect to fail until these items are resolved separately. These tests were `fail-if`ed by bug 1854660 and bug 1854528, before the investigation in the meta bug 1854661 and bug 1854529. Differential Revision: https://phabricator.services.mozilla.com/D193849
1 parent 977ec32 commit 9985c92

File tree

3 files changed

+0
-29
lines changed

3 files changed

+0
-29
lines changed

browser/components/sessionstore/test/browser.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,6 @@ skip-if = [
572572
]
573573

574574
["browser_urlbarSearchMode.js"]
575-
fail-if = ["a11y_checks"] # Bug 1854529 clicked urlbar-engine-one-off-item-history button may not be focusable
576575

577576
["browser_userTyped_restored_after_discard.js"]
578577

browser/components/urlbar/tests/browser/browser.toml

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ skip-if = [
4848
["browser_UrlbarInput_searchTerms_searchBar.js"]
4949

5050
["browser_UrlbarInput_searchTerms_searchMode.js"]
51-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
5251

5352
["browser_UrlbarInput_searchTerms_switch_tab.js"]
5453

@@ -245,7 +244,6 @@ support-files = [
245244
"searchSuggestionEngine.xml",
246245
"searchSuggestionEngine.sjs",
247246
]
248-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
249247

250248
["browser_inputHistory_autofill.js"]
251249

@@ -306,7 +304,6 @@ support-files = [
306304
"searchSuggestionEngine.xml",
307305
"searchSuggestionEngine.sjs",
308306
]
309-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
310307

311308
["browser_oneOffs_contextMenu.js"]
312309
support-files = [
@@ -325,15 +322,13 @@ support-files = [
325322
"searchSuggestionEngine.xml",
326323
"searchSuggestionEngine.sjs",
327324
]
328-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
329325

330326
["browser_oneOffs_searchSuggestions.js"]
331327
support-files = [
332328
"searchSuggestionEngine.xml",
333329
"searchSuggestionEngine.sjs",
334330
"searchSuggestionEngine2.xml",
335331
]
336-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
337332

338333
["browser_oneOffs_settings.js"]
339334

@@ -365,12 +360,10 @@ fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and
365360
["browser_queryContextCache.js"]
366361

367362
["browser_quickactions.js"]
368-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
369363

370364
["browser_quickactions_devtools.js"]
371365

372366
["browser_quickactions_screenshot.js"]
373-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
374367

375368
["browser_quickactions_tab_refocus.js"]
376369

@@ -420,22 +413,17 @@ support-files = [
420413
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
421414

422415
["browser_searchMode_autofill.js"]
423-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
424416

425417
["browser_searchMode_clickLink.js"]
426418
https_first_disabled = true
427419
support-files = ["dummy_page.html"]
428-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
429420

430421
["browser_searchMode_engineRemoval.js"]
431-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
432422

433423
["browser_searchMode_excludeResults.js"]
434-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
435424

436425
["browser_searchMode_heuristic.js"]
437426
https_first_disabled = true
438-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
439427

440428
["browser_searchMode_indicator.js"]
441429
https_first_disabled = true
@@ -459,18 +447,14 @@ support-files = [
459447
["browser_searchMode_no_results.js"]
460448

461449
["browser_searchMode_oneOffButton.js"]
462-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
463450

464451
["browser_searchMode_pickResult.js"]
465452
https_first_disabled = true
466-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
467453

468454
["browser_searchMode_preview.js"]
469-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
470455

471456
["browser_searchMode_sessionStore.js"]
472457
https_first_disabled = true
473-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
474458
skip-if = [
475459
"os == 'mac' && debug", # Bug 1671045, Bug 1849098
476460
"os == 'linux' && (debug || tsan || asan)", # Bug 1849098
@@ -479,7 +463,6 @@ skip-if = [
479463

480464
["browser_searchMode_setURI.js"]
481465
https_first_disabled = true
482-
fail-if = ["a11y_checks"] # Bug 1854660 clicked button.searchbar-engine-one-off-item may not be focusable
483466

484467
["browser_searchMode_suggestions.js"]
485468
support-files = [
@@ -493,7 +476,6 @@ fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and
493476
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
494477

495478
["browser_searchSettings.js"]
496-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
497479

498480
["browser_searchSingleWordNotification.js"]
499481
https_first_disabled = true
@@ -548,7 +530,6 @@ support-files = [
548530
"add_search_engine_0.xml",
549531
"add_search_engine_1.xml",
550532
]
551-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
552533

553534
["browser_slow_heuristic.js"]
554535

@@ -593,14 +574,12 @@ support-files = ["slow-page.sjs"]
593574
["browser_switchToTabHavingURI_aOpenParams.js"]
594575

595576
["browser_switchToTab_chiclet.js"]
596-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
597577

598578
["browser_switchToTab_closes_newtab.js"]
599579

600580
["browser_switchToTab_fullUrl_repeatedKeydown.js"]
601581

602582
["browser_tabKeyBehavior.js"]
603-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
604583

605584
["browser_tabMatchesInAwesomebar.js"]
606585
support-files = ["moz.png"]
@@ -612,11 +591,9 @@ support-files = ["moz.png"]
612591
["browser_textruns.js"]
613592

614593
["browser_tokenAlias.js"]
615-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
616594

617595
["browser_top_sites.js"]
618596
https_first_disabled = true
619-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
620597

621598
["browser_top_sites_private.js"]
622599
https_first_disabled = true
@@ -642,7 +619,6 @@ support-files = [
642619
"urlbarTelemetrySearchSuggestions.sjs",
643620
"urlbarTelemetrySearchSuggestions.xml",
644621
]
645-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
646622

647623
["browser_urlbar_telemetry_autofill.js"]
648624
tags = "search-telemetry"
@@ -676,7 +652,6 @@ support-files = [
676652
"urlbarTelemetrySearchSuggestions.sjs",
677653
"urlbarTelemetrySearchSuggestions.xml",
678654
]
679-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
680655

681656
["browser_urlbar_telemetry_tabtosearch.js"]
682657
tags = "search-telemetry"

browser/components/urlbar/tests/engagementTelemetry/browser/browser.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ prefs = ["browser.bookmarks.testing.skipDefaultBookmarksImport=true"]
3434
["browser_glean_telemetry_abandonment_search_engine_default_id.js"]
3535

3636
["browser_glean_telemetry_abandonment_search_mode.js"]
37-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
3837

3938
["browser_glean_telemetry_abandonment_tips.js"]
4039
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
@@ -57,7 +56,6 @@ fail-if = ["a11y_checks"] # Bug 1854660 clicked customizableui-special-spring2 m
5756
["browser_glean_telemetry_engagement_search_engine_default_id.js"]
5857

5958
["browser_glean_telemetry_engagement_search_mode.js"]
60-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
6159

6260
["browser_glean_telemetry_engagement_selected_result.js"]
6361
support-files = ["../../../../search/test/browser/trendingSuggestionEngine.sjs"]
@@ -87,7 +85,6 @@ fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and
8785
["browser_glean_telemetry_impression_search_engine_default_id.js"]
8886

8987
["browser_glean_telemetry_impression_search_mode.js"]
90-
fail-if = ["a11y_checks"] # Bug 1854660 clicked element may not be focusable and/or labeled
9188

9289
["browser_glean_telemetry_impression_timing.js"]
9390

0 commit comments

Comments
 (0)