Bug 1854487 - Correctly bind nimbus callback in ShoppingUtils r=shopping-reviewers,kpatenio

Jared Hirsch · Jared Hirsch · commit a26e7f4abb59 · 2023-09-21T22:34:59.000Z
Differential Revision: https://phabricator.services.mozilla.com/D188887
diff --git a/browser/components/shopping/ShoppingUtils.sys.mjs b/browser/components/shopping/ShoppingUtils.sys.mjs
@@ -55,9 +55,10 @@ export const ShoppingUtils = {
     if (this.initialized) {
       return;
     }
+    this.onNimbusUpdate = this.onNimbusUpdate.bind(this);
 
     if (!this.registered) {
-      lazy.NimbusFeatures.shopping2023.onUpdate(ShoppingUtils.onNimbusUpdate);
+      lazy.NimbusFeatures.shopping2023.onUpdate(this.onNimbusUpdate);
       this._updateNimbusVariables();
       this.registered = true;
     }

Original file line number	Diff line number	Diff line change
`@@ -55,9 +55,10 @@ export const ShoppingUtils = {`
`55`	`55`	`if (this.initialized) {`
`56`	`56`	`return;`
`57`	`57`	`}`
	`58`	`+ this.onNimbusUpdate = this.onNimbusUpdate.bind(this);`
`58`	`59`
`59`	`60`	`if (!this.registered) {`
`60`		`- lazy.NimbusFeatures.shopping2023.onUpdate(ShoppingUtils.onNimbusUpdate);`
	`61`	`+ lazy.NimbusFeatures.shopping2023.onUpdate(this.onNimbusUpdate);`
`61`	`62`	`this._updateNimbusVariables();`
`62`	`63`	`this.registered = true;`
`63`	`64`	`}`