Bug 1870852 - Fixed about:welcome pinning regression r=mhughes

nipunshukla21 · nipunshukla21 · commit b1561549489c · 2023-12-20T18:13:30.000Z
Differential Revision: https://phabricator.services.mozilla.com/D196897
diff --git a/browser/components/shell/nsWindowsShellService.cpp b/browser/components/shell/nsWindowsShellService.cpp
@@ -1477,7 +1477,7 @@ static nsresult PinCurrentAppToTaskbarWin10(bool aCheckOnly,
   // The behavior here is identical if we're only checking or if we try to pin
   // but the app is already pinned so we update the variable accordingly.
   if (!aCheckOnly) {
-    aCheckOnly = !IsCurrentAppPinnedToTaskbarSync(aAppUserModelId);
+    aCheckOnly = IsCurrentAppPinnedToTaskbarSync(aAppUserModelId);
   }
   const bool pinType = true;  // true means pin
   return ManageShortcutTaskbarPins(aCheckOnly, pinType, aShortcutPath);

Original file line number	Diff line number	Diff line change
`@@ -1477,7 +1477,7 @@ static nsresult PinCurrentAppToTaskbarWin10(bool aCheckOnly,`
`1477`	`1477`	`// The behavior here is identical if we're only checking or if we try to pin`
`1478`	`1478`	`// but the app is already pinned so we update the variable accordingly.`
`1479`	`1479`	`if (!aCheckOnly) {`
`1480`		`- aCheckOnly = !IsCurrentAppPinnedToTaskbarSync(aAppUserModelId);`
	`1480`	`+ aCheckOnly = IsCurrentAppPinnedToTaskbarSync(aAppUserModelId);`
`1481`	`1481`	`}`
`1482`	`1482`	`const bool pinType = true; // true means pin`
`1483`	`1483`	`return ManageShortcutTaskbarPins(aCheckOnly, pinType, aShortcutPath);`