Bug 1817084 - Remove old translations code; r=settings-reviewers,fluent-reviewers,nordzilla,mconley,flod

Differential Revision: https://phabricator.services.mozilla.com/D181700

Author: gregtatum

browser/app/profile/firefox.js

@@ -1814,19 +1814,10 @@ pref("media.videocontrols.picture-in-picture.video-toggle.visibility-threshold",
 pref("media.videocontrols.picture-in-picture.keyboard-controls.enabled", true);
 pref("media.videocontrols.picture-in-picture.urlbar-button.enabled", true);
 
-// Preferences for the older translation service backed by external services. This is
-// planned to be replaced with an integration of the Firefox Translations service.
-// The prefs for the new service are located under "browser.translations" in
-// modules/libpref/init/all.js
-//
-// See Bug 971044.
-pref("browser.translation.detectLanguage", false);
+// TODO (Bug 1817084) - This pref is used for managing translation preferences
+// in the Firefox Translations addon. It should be removed when the addon is
+// removed.
 pref("browser.translation.neverForLanguages", "");
-// Show the older translation UI that uses external services. This includes UI such as
-// the info bar, notification icon and preferences.
-pref("browser.translation.ui.show", false);
-// Allows to define the translation engine. Google is default, Bing or Yandex are other options.
-pref("browser.translation.engine", "Google");
 
 // Enable Firefox translations powered by the Bergamot translations
 // engine https://browser.mt/. See Bug 971044.

browser/base/content/browser.js

@@ -99,7 +99,6 @@ ChromeUtils.defineESModuleGetters(this, {
 
 XPCOMUtils.defineLazyModuleGetters(this, {
   CFRPageActions: "resource://activity-stream/lib/CFRPageActions.jsm",
-  Translation: "resource:///modules/translation/TranslationParent.jsm",
 });
 
 XPCOMUtils.defineLazyGetter(this, "fxAccounts", () => {

browser/base/content/test/static/browser_all_files_referenced.js

@@ -89,11 +89,6 @@ if (AppConstants.MOZ_BACKGROUNDTASKS) {
   gExceptionPaths.push("resource://app/modules/backgroundtasks/");
 }
 
-// Bug 1710546 https://bugzilla.mozilla.org/show_bug.cgi?id=1710546
-if (AppConstants.NIGHTLY_BUILD) {
-  gExceptionPaths.push("resource://builtin-addons/translations/");
-}
-
 // Temporary allowlist for shopping - we'll reference this soon.
 if (AppConstants.NIGHTLY_BUILD) {
   gExceptionPaths.push("chrome://browser/content/shopping/shopping.html");
@@ -212,11 +207,6 @@ var whitelist = [
   { file: "resource://pdf.js/web/debugger.js" },
   { file: "resource://pdf.js/web/debugger.css" },
 
-  // resource://app/modules/translation/TranslationContentHandler.jsm
-  { file: "resource://app/modules/translation/BingTranslator.jsm" },
-  { file: "resource://app/modules/translation/GoogleTranslator.jsm" },
-  { file: "resource://app/modules/translation/YandexTranslator.jsm" },
-
   // Starting from here, files in the whitelist are bugs that need fixing.
   // Bug 1339424 (wontfix?)
   {

browser/components/BrowserGlue.sys.mjs

@@ -771,22 +771,6 @@ let JSWINDOWACTORS = {
     allFrames: true,
   },
 
-  // The older translations feature backed by external services.
-  // This is being replaced by a newer ML-backed translation service. See Bug 971044.
-  Translation: {
-    parent: {
-      moduleURI: "resource:///modules/translation/TranslationParent.jsm",
-    },
-    child: {
-      moduleURI: "resource:///modules/translation/TranslationChild.jsm",
-      events: {
-        pageshow: {},
-        load: { mozSystemGroup: true, capture: true },
-      },
-    },
-    enablePreference: "browser.translation.detectLanguage",
-  },
-
   UITour: {
     parent: {
       esModuleURI: "resource:///modules/UITourParent.sys.mjs",

browser/components/moz.build

@@ -58,7 +58,6 @@ DIRS += [
     "syncedtabs",
     "tabunloader",
     "textrecognition",
-    "translation",
     "translations",
     "uitour",
     "urlbar",

browser/components/preferences/main.inc.xhtml

@@ -355,25 +355,7 @@
             data-l10n-args='{"localeName": "und"}'
             preference="intl.regional_prefs.use_os_locales"/>
 
-  <!-- TODO (Bug 1817084) This older implementation will be removed soon -->
-  <hbox id="translationBox" hidden="true">
-    <hbox align="center" flex="1">
-      <checkbox id="translate" preference="browser.translation.detectLanguage"
-                data-l10n-id="translate-web-pages"/>
-      <hbox id="bingAttribution" hidden="true" align="center">
-        <label data-l10n-id="translate-attribution">
-          <html:img id="translationAttributionImage" aria-label="Microsoft Translator"
-            src="chrome://browser/content/microsoft-translator-attribution.png"
-            data-l10n-name="logo"/>
-        </label>
-      </hbox>
-    </hbox>
-    <button id="translateButton"
-            is="highlightable-button"
-            class="accessory-button"
-            data-l10n-id="translate-exceptions"/>
-  </hbox>
-
+  <!-- This Firefox Translations UI manages the prefs for the addon only. -->
   <hbox id="fxtranslationsBox" hidden="true" data-subcategory="fxtranslations">
     <description flex="1" control="fxtranslateButton" data-l10n-id="fx-translate-web-pages"/>
     <button id="fxtranslateButton"

browser/components/preferences/main.js

@@ -98,7 +98,6 @@ Preferences.addAll([
   { id: "font.language.group", type: "wstring" },
 
   // Languages
-  { id: "browser.translation.detectLanguage", type: "bool" },
   { id: "intl.regional_prefs.use_os_locales", type: "bool" },
 
   // General tab
@@ -439,17 +438,6 @@ var gMainPane = {
       makeDisableControllingExtension(PREF_SETTING_TYPE, CONTAINERS_KEY)
     );
     setEventListener("chooseLanguage", "command", gMainPane.showLanguages);
-    setEventListener(
-      "translationAttributionImage",
-      "click",
-      gMainPane.openTranslationProviderAttribution
-    );
-    // TODO (Bug 1817084) Remove this code when we disable the extension
-    setEventListener(
-      "translateButton",
-      "command",
-      gMainPane.showTranslationExceptions
-    );
     // TODO (Bug 1817084) Remove this code when we disable the extension
     setEventListener(
       "fxtranslateButton",
@@ -513,20 +501,6 @@ var gMainPane = {
 
     this.updateOnScreenKeyboardVisibility();
 
-    // Show translation preferences if we may:
-    const translationsPrefName = "browser.translation.ui.show";
-    if (Services.prefs.getBoolPref(translationsPrefName)) {
-      let row = document.getElementById("translationBox");
-      row.removeAttribute("hidden");
-      // Showing attribution only for Bing Translator.
-      var { Translation } = ChromeUtils.import(
-        "resource:///modules/translation/TranslationParent.jsm"
-      );
-      if (Translation.translationEngine == "Bing") {
-        document.getElementById("bingAttribution").removeAttribute("hidden");
-      }
-    }
-
     // Firefox Translations settings panel
     // TODO (Bug 1817084) Remove this code when we disable the extension
     const fxtranslationsDisabledPrefName = "extensions.translations.disabled";
@@ -750,14 +724,6 @@ var gMainPane = {
       document.getElementById("defaultFont"),
       element => FontBuilder.readFontSelection(element)
     );
-    Preferences.addSyncFromPrefListener(
-      document.getElementById("translate"),
-      () =>
-        this.updateButtons(
-          "translateButton",
-          "browser.translation.detectLanguage"
-        )
-    );
     Preferences.addSyncFromPrefListener(
       document.getElementById("checkSpelling"),
       () => this.readCheckSpelling()
@@ -1932,13 +1898,6 @@ var gMainPane = {
     );
   },
 
-  openTranslationProviderAttribution() {
-    var { Translation } = ChromeUtils.import(
-      "resource:///modules/translation/TranslationParent.jsm"
-    );
-    Translation.openProviderAttribution();
-  },
-
   /**
    * Displays the fonts dialog, where web page font names and sizes can be
    * configured.