Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D176791

Author: ItielMaN

browser/base/content/browser-places.js

@@ -1223,7 +1223,7 @@ var PlacesToolbarHelper = {
         if (entry.name) {
           submenu.setAttribute("label", entry.name);
         } else {
-          submenu.setAttribute("data-l10n-id", "managed-bookmarks-subfolder");
+          document.l10n.setAttributes(submenu, "managed-bookmarks-subfolder");
         }
         submenu.setAttribute("container", "true");
         submenu.setAttribute(

browser/base/content/browser-sitePermissionPanel.js

@@ -989,11 +989,9 @@ var gPermissionPanel = {
     MozXULElement.insertFTLIfNeeded("browser/sitePermissions.ftl");
     let text = document.createXULElement("label", { is: "text-link" });
     text.setAttribute("class", "permission-popup-permission-label");
-    text.setAttribute("data-l10n-id", "site-permissions-open-blocked-popups");
-    text.setAttribute(
-      "data-l10n-args",
-      JSON.stringify({ count: aTotalBlockedPopups })
-    );
+    document.l10n.setAttributes(text, "site-permissions-open-blocked-popups", {
+      count: aTotalBlockedPopups,
+    });
 
     text.addEventListener("click", () => {
       gBrowser.selectedBrowser.popupBlocker.unblockAllPopups();

browser/base/content/browser-sync.js

@@ -526,7 +526,7 @@ var gSync = {
         ? "syncing-data-l10n-id"
         : "sync-now-data-l10n-id"
     );
-    syncNowBtn.setAttribute("data-l10n-id", l10nId);
+    document.l10n.setAttributes(syncNowBtn, l10nId);
 
     // This needs to exist because if the user is signed in
     // but the user disabled or disconnected sync we should not show the button
@@ -1615,7 +1615,7 @@ var gSync = {
 
     document.querySelectorAll(".syncnow-label").forEach(el => {
       let l10nId = el.getAttribute("syncing-data-l10n-id");
-      el.setAttribute("data-l10n-id", l10nId);
+      document.l10n.setAttributes(el, l10nId);
     });
 
     document.querySelectorAll(".syncNowBtn").forEach(el => {
@@ -1638,7 +1638,7 @@ var gSync = {
 
     document.querySelectorAll(".syncnow-label").forEach(el => {
       let l10nId = el.getAttribute("sync-now-data-l10n-id");
-      el.setAttribute("data-l10n-id", l10nId);
+      document.l10n.setAttributes(el, l10nId);
     });
 
     document.querySelectorAll(".syncNowBtn").forEach(el => {

browser/base/content/browser-unified-extensions.js

@@ -194,9 +194,10 @@ customElements.define(
       // The data-extensionid attribute is used by context menu handlers
       // to identify the extension being manipulated by the context menu.
       this._menuButton.dataset.extensionid = this.extension.id;
-      this._menuButton.setAttribute(
-        "data-l10n-args",
-        JSON.stringify({ extensionName: this.extension.name })
+      this.ownerDocument.l10n.setAttributes(
+        this._menuButton,
+        "unified-extensions-item-open-menu",
+        { extensionName: this.extension.name }
       );
 
       this.#setStateMessage();

browser/base/content/browser.js

@@ -1532,8 +1532,8 @@ var gBrowserInit = {
       if (!toolbarMenubar.hasAttribute("autohide")) {
         toolbarMenubar.setAttribute("autohide", true);
       }
-      toolbarMenubar.setAttribute(
-        "data-l10n-id",
+      document.l10n.setAttributes(
+        toolbarMenubar,
         "toolbar-context-menu-menu-bar-cmd"
       );
       toolbarMenubar.setAttribute("data-l10n-attrs", "toolbarname");
@@ -1987,8 +1987,8 @@ var gBrowserInit = {
               toplevel.toplevel_name
             );
           } else {
-            managedBookmarksButton.setAttribute(
-              "data-l10n-id",
+            document.l10n.setAttributes(
+              managedBookmarksButton,
               "managed-bookmarks"
             );
           }

browser/base/content/nsContextMenu.js

@@ -1155,14 +1155,14 @@ class nsContextMenu {
       // Set the correct label for the fill menu
       let fillMenu = document.getElementById("fill-login");
       if (onPasswordLikeField) {
-        fillMenu.setAttribute(
-          "data-l10n-id",
+        document.l10n.setAttributes(
+          fillMenu,
           "main-context-menu-use-saved-password"
         );
       } else {
         // On a username field
-        fillMenu.setAttribute(
-          "data-l10n-id",
+        document.l10n.setAttributes(
+          fillMenu,
           "main-context-menu-use-saved-login"
         );
       }

browser/base/content/tabbrowser-tab.js

@@ -558,6 +558,7 @@
       } else {
         tooltipEl.removeAttribute("data-l10n-id");
       }
+      // TODO(Itiel): Maybe simplify this when bug 1830989 lands
     }
 
     startUnselectedTabHoverTimer() {

browser/base/content/unified-extensions-viewcache.inc.xhtml

@@ -35,6 +35,5 @@
   <toolbarbutton class="unified-extensions-item-menu-button subviewbutton subviewbutton-iconic"
                  closemenu="none"
                  context="unified-extensions-context-menu"
-                 data-l10n-id="unified-extensions-item-open-menu"
                  data-navigable-with-tab-only="true" />
 </html:template>

browser/components/customizableui/CustomizableUI.sys.mjs

@@ -1940,15 +1940,15 @@ var CustomizableUIInternal = {
       }
 
       if (aWidget.l10nId) {
-        node.setAttribute("data-l10n-id", aWidget.l10nId);
+        aDocument.l10n.setAttributes(node, aWidget.l10nId);
         if (button != node) {
           // This is probably a "button-and-view" widget, such as the Profiler
           // button. In that case, "node" is the "toolbaritem" container, and
           // "button" the main button (see above).
           // In this case, the values on the "node" is used in the Customize
           // view, as well as the tooltips over both buttons; the values on the
           // "button" are used in the overflow menu.
-          button.setAttribute("data-l10n-id", aWidget.l10nId);
+          aDocument.l10n.setAttributes(button, aWidget.l10nId);
         }
 
         if (shortcut) {
@@ -4837,7 +4837,7 @@ export var CustomizableUI = {
       // Sentence case in the AppMenu / panels.
       let l10nId = menuChild.getAttribute("appmenu-data-l10n-id");
       if (l10nId) {
-        subviewItem.setAttribute("data-l10n-id", l10nId);
+        doc.l10n.setAttributes(subviewItem, l10nId);
       }
 
       fragment.appendChild(subviewItem);

browser/components/customizableui/CustomizableWidgets.sys.mjs

@@ -457,7 +457,7 @@ if (Services.prefs.getBoolPref("identity.fxaccounts.enabled")) {
           ? "syncing-data-l10n-id"
           : "sync-now-data-l10n-id"
       );
-      syncNowBtn.setAttribute("data-l10n-id", l10nId);
+      doc.l10n.setAttributes(syncNowBtn, l10nId);
 
       let SyncedTabsPanelList = doc.defaultView.SyncedTabsPanelList;
       panelview.syncedTabsPanelList = new SyncedTabsPanelList(