Skip to content

Commit e475b72

Browse files
committed
Bug 1858041 - [devtools] Replace fail-if with skip-if for 2 tests that inconsistently failing/passing a11y-checks. r=devtools-reviewers,nchevobbe
The two tests affected are now inconsistently passing (in opt builds on all trees) and failing the Tier 2 a11y-checks: `devtools/client/webconsole/test/browser/browser_webconsole_longstring_getter.js` and `devtools/client/inspector/rules/test/browser_rules_edit-property-computed.js`, thus we are replacing the `fail-if` expectations with `skip-if` while the investigation is ongoing. Related bugs: bug 1849028, bug 1867062, bug 1868497 Differential Revision: https://phabricator.services.mozilla.com/D195468
1 parent 839eb81 commit e475b72

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

devtools/client/inspector/rules/test/browser_part1.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ fail-if = ["a11y_checks"] # Bug 1849028 clicked element may not be focusable and
206206
["browser_rules_edit-property-commit.js"]
207207

208208
["browser_rules_edit-property-computed.js"]
209-
fail-if = ["a11y_checks"] # Bug 1849028 clicked element may not be focusable and/or labeled
209+
skip-if = ["a11y_checks"] # Bugs 1849028 and 1858041 clicked span.ruleview-expander.theme-twisty is inconsistently not accessible
210210

211211
["browser_rules_edit-property-increments.js"]
212212

devtools/client/webconsole/test/browser/_webconsole.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ fail-if = ["a11y_checks"] # Bug 1849028 clicked element may not be focusable and
509509
fail-if = ["a11y_checks"] # Bug 1849028 clicked element may not be focusable and/or labeled
510510

511511
["browser_webconsole_longstring_getter.js"]
512-
fail-if = ["a11y_checks"] # Bug 1849028 clicked element may not be focusable and/or labeled
512+
skip-if = ["a11y_checks"] # Bugs 1849028 and 1858041 clicked BUTTON.arrow is inconsistently not focusable
513513

514514
["browser_webconsole_message_categories.js"]
515515

0 commit comments

Comments
 (0)