Skip to content

Commit e9d9030

Browse files
committed
Bug 1884719 - part3 : add a by-pass pref for testing. r=media-playback-reviewers,ci-and-tooling,jmaher,padenot
Ideally, we should run `wmfme` on the gpu worker in order to access video hardware decoding. However, when switching task to the gpu worker, there are some tests starting failed on the try server [1]. Therefore, adding this pref temporarily to bypass the gfx check until we figure out why those tests fail on the gpu worker. [1] https://treeherder.mozilla.org/jobs?repo=try&revision=bd9a68c7c259ba9028051c8898ddd69384616ac5&selectedTaskRun=OvNqUv77Q5OVeBDlIhWQ5g.0 Differential Revision: https://phabricator.services.mozilla.com/D204443
1 parent 0fd2a3c commit e9d9030

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

dom/media/platforms/wmf/MFMediaEngineDecoderModule.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ media::DecodeSupportSet MFMediaEngineDecoderModule::SupportInternal(
101101
return media::DecodeSupportSet{};
102102
}
103103
// Only support hardware decoding.
104-
if (!gfx::gfxVars::CanUseHardwareVideoDecoding()) {
104+
if (!gfx::gfxVars::CanUseHardwareVideoDecoding() &&
105+
!StaticPrefs::media_wmf_media_engine_bypass_gfx_blocklist()) {
105106
return media::DecodeSupportSet{};
106107
}
107108
bool supports = false;

modules/libpref/init/StaticPrefList.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10289,6 +10289,12 @@
1028910289
value: 2
1029010290
mirror: always
1029110291

10292+
# Bypass the gfx block list check for the media engine playback.
10293+
- name: media.wmf.media-engine.bypass-gfx-blocklist
10294+
type: RelaxedAtomicBool
10295+
value: false
10296+
mirror: always
10297+
1029210298
# [TEST-ONLY] Use Media Foundation Clearkey CDM for EME related testing.
1029310299
- name: media.eme.wmf.clearkey.enabled
1029410300
type: RelaxedAtomicBool

taskcluster/ci/test/variants.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,7 @@ wmf-media-engine:
355355
- "--setpref=media.wmf.media-engine.enabled=1"
356356
- "--setpref=media.wmf.media-engine.channel-decoder.enabled=true"
357357
- "--setpref=media.eme.wmf.clearkey.enabled=true"
358+
- "--setpref=media.wmf.media-engine.bypass-gfx-blocklist=true"
358359

359360
media-gpu:
360361
description: "{description} for running media tests on the GPU worker"

0 commit comments

Comments
 (0)