Bug 1881401 - remove expiring oskeystore.self_test metric and related code r=jschanck

Differential Revision: https://phabricator.services.mozilla.com/D203321

Author: mozkeeler

browser/components/BrowserGlue.sys.mjs

@@ -3175,8 +3175,6 @@ BrowserGlue.prototype = {
       function reportInstallationTelemetry() {
         lazy.BrowserUsageTelemetry.reportInstallationTelemetry();
       },
-
-      RunOSKeyStoreSelfTest,
     ];
 
     for (let task of idleTasks) {
@@ -6450,70 +6448,3 @@ export var AboutHomeStartupCache = {
     this._cacheEntryResolver(this._cacheEntry);
   },
 };
-
-async function RunOSKeyStoreSelfTest() {
-  // The linux implementation always causes an OS dialog, in contrast to
-  // Windows and macOS (the latter of which causes an OS dialog to appear on
-  // local developer builds), so only run on Windows and macOS and only if this
-  // has been built and signed by Mozilla's infrastructure. Similarly, don't
-  // run this code in automation.
-  if (
-    (AppConstants.platform != "win" && AppConstants.platform != "macosx") ||
-    !AppConstants.MOZILLA_OFFICIAL ||
-    Services.env.get("MOZ_AUTOMATION")
-  ) {
-    return;
-  }
-  let osKeyStore = Cc["@mozilla.org/security/oskeystore;1"].getService(
-    Ci.nsIOSKeyStore
-  );
-  let label = Services.prefs.getCharPref("security.oskeystore.test.label", "");
-  if (!label) {
-    label = Services.uuid.generateUUID().toString().slice(1, -1);
-    Services.prefs.setCharPref("security.oskeystore.test.label", label);
-    try {
-      await osKeyStore.asyncGenerateSecret(label);
-      Glean.oskeystore.selfTest.generate.set(true);
-    } catch (_) {
-      Glean.oskeystore.selfTest.generate.set(false);
-      return;
-    }
-  }
-  let secretAvailable = await osKeyStore.asyncSecretAvailable(label);
-  Glean.oskeystore.selfTest.available.set(secretAvailable);
-  if (!secretAvailable) {
-    return;
-  }
-  let encrypted = Services.prefs.getCharPref(
-    "security.oskeystore.test.encrypted",
-    ""
-  );
-  if (!encrypted) {
-    try {
-      encrypted = await osKeyStore.asyncEncryptBytes(label, [1, 1, 3, 8]);
-      Services.prefs.setCharPref(
-        "security.oskeystore.test.encrypted",
-        encrypted
-      );
-      Glean.oskeystore.selfTest.encrypt.set(true);
-    } catch (_) {
-      Glean.oskeystore.selfTest.encrypt.set(false);
-      return;
-    }
-  }
-  try {
-    let decrypted = await osKeyStore.asyncDecryptBytes(label, encrypted);
-    if (
-      decrypted.length != 4 ||
-      decrypted[0] != 1 ||
-      decrypted[1] != 1 ||
-      decrypted[2] != 3 ||
-      decrypted[3] != 8
-    ) {
-      throw new Error("decrypted value not as expected?");
-    }
-    Glean.oskeystore.selfTest.decrypt.set(true);
-  } catch (_) {
-    Glean.oskeystore.selfTest.decrypt.set(false);
-  }
-}

security/manager/ssl/metrics.yaml

@@ -53,26 +53,6 @@ data_storage:
     expires: never
     unit: entries
 
-oskeystore:
-  self_test:
-    type: labeled_boolean
-    description:
-      Whether or not each step of the OSKeyStore self test succeeded.
-    bugs:
-      - https://bugzilla.mozilla.org/show_bug.cgi?id=1855759
-    data_reviews:
-      - https://bugzilla.mozilla.org/show_bug.cgi?id=1855759
-    data_sensitivity:
-      - interaction
-    notification_emails:
-      - dkeeler@mozilla.com
-    expires: 126
-    labels:
-      - generate
-      - available
-      - encrypt
-      - decrypt
-
 tls:
   certificate_verifications:
     type: counter