Skip to content

Commit f3e1e3f

Browse files
committed
Bug 1857522 - Reduce max nesting depth to 3. r=Gijs
That still doesn't trigger on the code in comment 2, so that is a bit confusing and needs investigation. Differential Revision: https://phabricator.services.mozilla.com/D190310
1 parent fac2ba0 commit f3e1e3f

File tree

15 files changed

+28
-1
lines changed

15 files changed

+28
-1
lines changed

.stylelintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ python/mozbuild/mozbuild/test/backend/data/build/foo.css
8383

8484
# This is third-party in a way:
8585
toolkit/components/pdfjs/content/web/debugger.css
86+
toolkit/components/pdfjs/content/web/viewer.css
8687

8788
# Ignore web-platform tests as they are not necessarily under our control.
8889
testing/web-platform/tests/

.stylelintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ module.exports = {
5454
],
5555

5656
"max-nesting-depth": [
57-
8,
57+
3,
5858
{
5959
ignore: ["blockless-at-rules", "pseudo-classes"],
6060
},

browser/components/newtab/content-src/aboutwelcome/aboutwelcome.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
@import '../styles/feature-callout';
77
@import '../styles/shopping';
88

9+
/* stylelint-disable max-nesting-depth */
10+
911
$break-point-small: 570px;
1012
$break-point-medium: 610px;
1113
$break-point-large: 866px;

browser/components/newtab/content-src/components/ASRouterAdmin/ASRouterAdmin.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* stylelint-disable max-nesting-depth */
2+
13
.asrouter-toggle {
24
position: fixed;
35
top: 50px;

browser/components/newtab/content-src/components/Card/_Card.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
@use 'sass:math';
22

3+
/* stylelint-disable max-nesting-depth */
4+
35
.card-outer {
46
@include context-menu-button;
57

browser/components/newtab/content-src/components/CollapsibleSection/_CollapsibleSection.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* stylelint-disable max-nesting-depth */
2+
13
.collapsible-section {
24
padding: $section-vertical-padding $section-horizontal-padding;
35

browser/components/newtab/content-src/components/ContextMenu/_ContextMenu.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
@use 'sass:math';
22

3+
/* stylelint-disable max-nesting-depth */
4+
35
.context-menu {
46
background: var(--newtab-background-color-secondary);
57
border-radius: $context-menu-border-radius;

browser/components/newtab/content-src/components/DiscoveryStreamComponents/Highlights/_Highlights.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* stylelint-disable max-nesting-depth */
2+
13
.ds-highlights {
24
.section {
35
.section-list {

browser/components/newtab/content-src/components/DiscoveryStreamComponents/Navigation/_Navigation.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* stylelint-disable max-nesting-depth */
2+
13
.ds-navigation {
24
color: var(--newtab-text-primary-color);
35
font-size: 11.5px;

browser/components/newtab/content-src/components/DiscoveryStreamComponents/TopSites/_TopSites.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* stylelint-disable max-nesting-depth */
2+
13
.outer-wrapper {
24
.ds-top-sites {
35
.top-sites {

browser/components/newtab/content-src/components/DiscoveryStreamComponents/TopicsWidget/_TopicsWidget.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* stylelint-disable max-nesting-depth */
2+
13
.ds-topics-widget {
24
display: flex;
35
position: relative;

browser/components/newtab/content-src/components/TopSites/_TopSites.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
@use 'sass:math';
22

3+
/* stylelint-disable max-nesting-depth */
4+
35
$top-sites-size: $grid-unit-small;
46
$top-sites-border-radius: 8px;
57
$top-sites-icon-border-radius: 4px;

browser/components/newtab/content-src/styles/_feature-callout.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
@import 'feature-callout-theme';
66

7+
/* stylelint-disable max-nesting-depth */
8+
79
#feature-callout {
810
// See _feature-callout-theme.scss for the theme mixins and
911
// FeatureCallout.sys.mjs for the color values

browser/components/newtab/content-src/styles/_shopping.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// License, v. 2.0. If a copy of the MPL was not distributed with this
33
// file, You can obtain one at http://mozilla.org/MPL/2.0/.
44

5+
/* stylelint-disable max-nesting-depth */
6+
57
.onboardingContainer.shopping {
68
height: auto;
79

browser/components/pocket/content/panels/css/home.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/* stylelint-disable max-nesting-depth */
2+
13
.pkt_ext_containerhome,
24
.pkt_ext_wrapperhome {
35
overflow: hidden;

0 commit comments

Comments
 (0)