Skip to content

Commit fd43043

Browse files
committed
Backed out 2 changesets (bug 1814261) as per request. CLOSED TREE
Backed out changeset 8640c4a18d9e (bug 1814261) Backed out changeset c00c8fc88dbd (bug 1814261)
1 parent f50455a commit fd43043

File tree

6 files changed

+20
-69
lines changed

6 files changed

+20
-69
lines changed

browser/base/content/browser-siteIdentity.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ var gIdentityHandler = {
166166

167167
_popupInitialized: false,
168168
_initializePopup() {
169-
window.ensureCustomElements("moz-support-link");
170169
if (!this._popupInitialized) {
171170
let wrapper = document.getElementById("template-identity-popup");
172171
wrapper.replaceWith(wrapper.content);
@@ -929,6 +928,9 @@ var gIdentityHandler = {
929928

930929
// Update "Learn More" for Mixed Content Blocking and Insecure Login Forms.
931930
let baseURL = Services.urlFormatter.formatURLPref("app.support.baseURL");
931+
this._identityPopupMixedContentLearnMore.forEach(e =>
932+
e.setAttribute("href", baseURL + "mixed-content")
933+
);
932934

933935
this._identityPopupCustomRootLearnMore.setAttribute(
934936
"href",

browser/components/controlcenter/content/identityPanel.inc.xhtml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -147,25 +147,25 @@
147147

148148
<!-- Active Mixed Content Blocked -->
149149
<description class="identity-popup-warning-box identity-popup-warning-gray"
150-
when-mixedcontent="active-blocked">
151-
<label data-l10n-id="identity-description-active-blocked2"/>
152-
<html:a is="moz-support-link" class="identity-popup-mcb-learn-more" support-page="mixed-content"/>
150+
when-mixedcontent="active-blocked"
151+
data-l10n-id="identity-description-active-blocked">
152+
<label data-l10n-name="link" is="text-link" class="identity-popup-mcb-learn-more"/>
153153
</description>
154154

155155
<!-- Passive Mixed Content Loaded -->
156156
<description when-mixedcontent="passive-loaded" data-l10n-id="identity-description-passive-loaded"></description>
157157
<description class="identity-popup-warning-box identity-popup-warning-yellow"
158-
when-mixedcontent="passive-loaded">
159-
<label data-l10n-id="identity-description-passive-loaded-insecure2"/>
160-
<html:a is="moz-support-link" class="identity-popup-mcb-learn-more" support-page="mixed-content"/>
158+
when-mixedcontent="passive-loaded"
159+
data-l10n-id="identity-description-passive-loaded-insecure">
160+
<label data-l10n-name="link" is="text-link" class="identity-popup-mcb-learn-more"/>
161161
</description>
162162

163163
<!-- Passive Mixed Content Loaded, Active Mixed Content Blocked -->
164164
<description when-mixedcontent="passive-loaded active-blocked" data-l10n-id="identity-description-passive-loaded"></description>
165165
<description when-mixedcontent="passive-loaded active-blocked"
166-
class="identity-popup-warning-box identity-popup-warning-yellow">
167-
<label data-l10n-id="identity-description-passive-loaded-mixed2"/>
168-
<html:a is="moz-support-link" class="identity-popup-mcb-learn-more" support-page="mixed-content"/>
166+
class="identity-popup-warning-box identity-popup-warning-yellow"
167+
data-l10n-id="identity-description-passive-loaded-mixed">
168+
<label data-l10n-name="link" is="text-link" class="identity-popup-mcb-learn-more"/>
169169
</description>
170170

171171
<!-- Active Mixed Content Blocking Disabled -->
@@ -174,8 +174,8 @@
174174
<description when-mixedcontent="active-loaded"
175175
data-l10n-id="identity-description-active-loaded-insecure"></description>
176176
<hbox>
177-
<html:a is="moz-support-link" when-mixedcontent="active-loaded"
178-
and-when-loginforms="secure" class="identity-popup-mcb-learn-more" support-page="mixed-content"/>
177+
<label when-mixedcontent="active-loaded"
178+
and-when-loginforms="secure" is="text-link" class="identity-popup-mcb-learn-more" data-l10n-id="identity-learn-more"/>
179179
</hbox>
180180

181181

browser/locales/en-US/browser/browser.ftl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -408,12 +408,14 @@ identity-description-insecure = Your connection to this site is not private. Inf
408408
identity-description-insecure-login-forms = The login information you enter on this page is not secure and could be compromised.
409409
identity-description-weak-cipher-intro = Your connection to this website uses weak encryption and is not private.
410410
identity-description-weak-cipher-risk = Other people can view your information or modify the website’s behavior.
411-
identity-description-active-blocked2 = { -brand-short-name } has blocked parts of this page that are not secure.
411+
identity-description-active-blocked = { -brand-short-name } has blocked parts of this page that are not secure. <label data-l10n-name="link">Learn More</label>
412412
identity-description-passive-loaded = Your connection is not private and information you share with the site could be viewed by others.
413-
identity-description-passive-loaded-insecure2 = This website contains content that is not secure (such as images).
414-
identity-description-passive-loaded-mixed2 = Although { -brand-short-name } has blocked some content, there is still content on the page that is not secure (such as images).
413+
identity-description-passive-loaded-insecure = This website contains content that is not secure (such as images). <label data-l10n-name="link">Learn More</label>
414+
identity-description-passive-loaded-mixed = Although { -brand-short-name } has blocked some content, there is still content on the page that is not secure (such as images). <label data-l10n-name="link">Learn More</label>
415415
identity-description-active-loaded = This website contains content that is not secure (such as scripts) and your connection to it is not private.
416416
identity-description-active-loaded-insecure = Information you share with this site could be viewed by others (like passwords, messages, credit cards, etc.).
417+
identity-learn-more =
418+
.value = Learn More
417419
identity-disable-mixed-content-blocking =
418420
.label = Disable protection for now
419421
.accesskey = D

browser/themes/shared/controlcenter/panel.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,6 @@
268268
font-weight: 600;
269269
}
270270

271-
#identity-popup-securityView-extended-info > .identity-popup-warning-box > label {
272-
display: inline-block;
273-
}
274-
275271
#identity-popup-securityView-extended-info > button {
276272
margin-inline: 0;
277273
}

python/l10n/fluent_migrations/bug_1814261_mixed_content_identity_panel.py

Lines changed: 0 additions & 49 deletions
This file was deleted.

toolkit/content/widgets/moz-support-link/moz-support-link.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ export default class MozSupportLink extends HTMLAnchorElement {
5353
this.addEventListener("click", this);
5454
if (!this.getAttribute("data-l10n-id")) {
5555
document.l10n.setAttributes(this, "moz-support-link-text");
56+
document.l10n.translateFragment(this);
5657
}
57-
document.l10n.translateFragment(this);
5858
}
5959

6060
disconnectedCallback() {

0 commit comments

Comments
 (0)