Generate expected schemata for Calendar

Summary:
Ref T1191.

  - There was a varchar(50) column. I changed it to `text64`, since this length is unusual.
  - There was an int(3) column. I changed it to `int32`, since this length is unusual.

Test Plan: Ran migrations, saw warnings disappear from config tool.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10524

Author: epriestley

resources/sql/autopatches/20140919.schema.01.calstatus.sql

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_calendar.calendar_event
+  CHANGE status status INT UNSIGNED NOT NULL;

resources/sql/autopatches/20140919.schema.02.calname.sql

@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_calendar.calendar_holiday
+  CHANGE name name VARCHAR(64) NOT NULL COLLATE utf8_general_ci;

src/__phutil_library_map__.php

@@ -1300,6 +1300,7 @@
     'PhabricatorCalendarEventViewController' => 'applications/calendar/controller/PhabricatorCalendarEventViewController.php',
     'PhabricatorCalendarHoliday' => 'applications/calendar/storage/PhabricatorCalendarHoliday.php',
     'PhabricatorCalendarHolidayTestCase' => 'applications/calendar/storage/__tests__/PhabricatorCalendarHolidayTestCase.php',
+    'PhabricatorCalendarSchemaSpec' => 'applications/calendar/storage/PhabricatorCalendarSchemaSpec.php',
     'PhabricatorCalendarViewController' => 'applications/calendar/controller/PhabricatorCalendarViewController.php',
     'PhabricatorCampfireProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorCampfireProtocolAdapter.php',
     'PhabricatorChangeParserTestCase' => 'applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php',
@@ -4208,6 +4209,7 @@
     'PhabricatorCalendarEventViewController' => 'PhabricatorCalendarController',
     'PhabricatorCalendarHoliday' => 'PhabricatorCalendarDAO',
     'PhabricatorCalendarHolidayTestCase' => 'PhabricatorTestCase',
+    'PhabricatorCalendarSchemaSpec' => 'PhabricatorConfigSchemaSpec',
     'PhabricatorCalendarViewController' => 'PhabricatorCalendarController',
     'PhabricatorCampfireProtocolAdapter' => 'PhabricatorBotBaseStreamingProtocolAdapter',
     'PhabricatorChangeParserTestCase' => 'PhabricatorWorkingCopyTestCase',

src/applications/calendar/storage/PhabricatorCalendarEvent.php

@@ -37,6 +37,12 @@ public function getHumanStatus() {
   public function getConfiguration() {
     return array(
       self::CONFIG_AUX_PHID => true,
+      self::CONFIG_COLUMN_SCHEMA => array(
+        'dateFrom' => 'epoch',
+        'dateTo' => 'epoch',
+        'status' => 'uint32',
+        'description' => 'text',
+      ),
     ) + parent::getConfiguration();
   }
 

src/applications/calendar/storage/PhabricatorCalendarHoliday.php

@@ -8,6 +8,15 @@ final class PhabricatorCalendarHoliday extends PhabricatorCalendarDAO {
   public function getConfiguration() {
     return array(
       self::CONFIG_TIMESTAMPS => false,
+      self::CONFIG_COLUMN_SCHEMA => array(
+        'day' => 'date',
+        'name' => 'text64',
+      ),
+      self::CONFIG_KEY_SCHEMA => array(
+        'day' => array(
+          'columns' => array('day'),
+        ),
+      ),
     ) + parent::getConfiguration();
   }
 

src/applications/calendar/storage/PhabricatorCalendarSchemaSpec.php

@@ -0,0 +1,10 @@
+<?php
+
+final class PhabricatorCalendarSchemaSpec
+  extends PhabricatorConfigSchemaSpec {
+
+  public function buildSchemata() {
+    $this->buildLiskSchemata('PhabricatorCalendarDAO');
+  }
+
+}

src/applications/config/schema/PhabricatorConfigSchemaSpec.php

@@ -292,6 +292,9 @@ private function getDetailsForDataType($data_type) {
       case 'double':
         $column_type = 'double';
         break;
+      case 'date':
+        $column_type = 'date';
+        break;
       default:
         $column_type = pht('<unknown>');
         $charset = pht('<unknown>');