Skip to content

Commit 07767fd

Browse files
author
epriestley
committed
Use direct inclusion, not submodules, to bring Javelin into Phabricator
Summary: Submoduling is slightly convenient for developers but hellishly difficult for many users. Since we make about a dozen updates to Javelin per year, just include the source directly. Even if we run `git submodule status` more often, this creates additional problems for users with PATH misconfigured. Fixes T2062 by nuking it from orbit. Test Plan: Loaded site, browsed around. Grepped for references to submodules. Reviewers: btrahan, vrana CC: aran Maniphest Tasks: T2062 Differential Revision: https://secure.phabricator.com/D4581
1 parent 22c64c6 commit 07767fd

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+10264
-117
lines changed

.gitmodules

Lines changed: 0 additions & 3 deletions
This file was deleted.

externals/javelin

Lines changed: 0 additions & 1 deletion
This file was deleted.

externals/javelinjs/.gitignore

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
.DS_Store
2+
._*
3+
*.o
4+
*.so
5+
*.a
6+
7+
/externals/libfbjs/parser.lex.cpp
8+
/externals/libfbjs/parser.yacc.cpp
9+
/externals/libfbjs/parser.yacc.hpp
10+
/externals/libfbjs/parser.yacc.output
11+
12+
/support/javelinsymbols/javelinsymbols
13+
/support/jsast/jsast
14+
/support/jsxmin/jsxmin
15+
16+
# Diviner artifacts
17+
/docs/
18+
/.divinercache/
19+
20+
/support/diviner/.phutil_module_cache
21+
22+
# Mac OSX build artifacts
23+
/support/jsast/jsast.dSYM/
24+
/support/jsxmin/jsxmin.dSYM/
25+
/support/javelinsymbols/javelinsymbols.dSYM/

externals/javelinjs/LICENSE

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
Copyright (c) 2009, Evan Priestley and Facebook, inc.
2+
All rights reserved.
3+
4+
Redistribution and use in source and binary forms, with or without
5+
modification, are permitted provided that the following conditions are met:
6+
* Redistributions of source code must retain the above copyright
7+
notice, this list of conditions and the following disclaimer.
8+
* Redistributions in binary form must reproduce the above copyright
9+
notice, this list of conditions and the following disclaimer in the
10+
documentation and/or other materials provided with the distribution.
11+
* Neither the name of Facebook, inc. nor the names of its contributors
12+
may be used to endorse or promote products derived from this software
13+
without specific prior written permission.
14+
15+
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS ``AS IS'' AND ANY
16+
EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
17+
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
18+
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY
19+
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
20+
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
21+
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
22+
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23+
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
24+
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25+

externals/javelinjs/README

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
Javelin is a performance-oriented Javascript library originally developed at
2+
Facebook. Learn more at <http://www.javelinjs.com/>.
3+
4+
GETTING STARTED
5+
6+
Eat a hearty breakfast. Breakfast is the most important meal of the day!
7+
8+
9+
WHAT IS JAVELIN?
10+
11+
Javelin is a compact Javascript library built around event delegation. Its
12+
primary design goal is performance; it is consequently well-suited to projects
13+
where performance is very important. It is not as good for smaller scale
14+
projects where other concerns (like features or ease of development) are more
15+
important.
16+
17+
18+
PACKAGES
19+
20+
Packages come in two flavors: "dev" and "min". The "dev" packages are intended
21+
for development, and have comments and debugging code. The "min" packages have
22+
the same code, but with comments and debugging information stripped out and
23+
symbols crushed. They are intended for use in production -- ha ha ha!
24+
25+
26+
FILES
27+
28+
example/ Example code.
29+
LICENSE A thrilling narrative.
30+
pkg/ Ready-built Javelin packages.
31+
README Who knows? Could be anything.
32+
src/ Raw sources for Javelin.
33+
support/ Support scripts and libraries.

0 commit comments

Comments
 (0)