Skip to content

Commit 58712c7

Browse files
author
vrana
committed
Don't corrupt commit message in arc amend
Summary: I use a smart editor which wraps words by itself so that I don't need them to be wrapped by actual newlines. Curent state disallows me adding or removing words later without uglying the formatting. Also the wordwrapped message looks ugly in Phabricator. I am not sure how the commit message would look like on other places (such as GitHub) but all reasonable tools should be able to wrap the text by itself. Test Plan: arc amend --show # on a diff with long lines Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1755
1 parent 1febd32 commit 58712c7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/applications/conduit/method/differential/getcommitmessage/ConduitAPI_differential_getcommitmessage_Method.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ protected function execute(ConduitAPIRequest $request) {
138138
}
139139
$commit_message = implode("\n\n", $commit_message);
140140

141-
return wordwrap($commit_message, 80);
141+
return $commit_message;
142142
}
143143

144144
}

0 commit comments

Comments
 (0)