Skip to content

Commit eaacb4a

Browse files
author
epriestley
committed
Replace ActionHeader minicons with Font icons
Summary: Ref T5885. See D10276. Currently, ActionHeaders can only have minicons, and we don't use them anywhere and they probably don't make much sense in the product anymore. Instead, allow them to have font icons. Remove minicons, which have no callsites and probably won't in the future. Test Plan: {F190925} - Grepped for `minicons`. - Grepped for `setHeaderIcon()`. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T5885 Differential Revision: https://secure.phabricator.com/D10277
1 parent f9de495 commit eaacb4a

File tree

27 files changed

+31
-190
lines changed

27 files changed

+31
-190
lines changed

resources/celerity/map.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88
return array(
99
'names' => array(
10-
'core.pkg.css' => '383d0947',
10+
'core.pkg.css' => '1733ae8f',
1111
'core.pkg.js' => '7c8455ef',
1212
'darkconsole.pkg.js' => 'df001cab',
1313
'differential.pkg.css' => '4a93db37',
@@ -130,7 +130,7 @@
130130
'rsrc/css/phui/phui-form-view.css' => 'ebac1b1d',
131131
'rsrc/css/phui/phui-form.css' => 'b78ec020',
132132
'rsrc/css/phui/phui-header-view.css' => '39594ac0',
133-
'rsrc/css/phui/phui-icon.css' => 'd8526aa1',
133+
'rsrc/css/phui/phui-icon.css' => 'b4963a4f',
134134
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
135135
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
136136
'rsrc/css/phui/phui-list.css' => '43ed2d93',
@@ -154,7 +154,6 @@
154154
'rsrc/css/sprite-login.css' => '878ee4d8',
155155
'rsrc/css/sprite-main-header.css' => '92720ee2',
156156
'rsrc/css/sprite-menu.css' => '28281e16',
157-
'rsrc/css/sprite-minicons.css' => 'df4f76fe',
158157
'rsrc/css/sprite-payments.css' => 'cc085d44',
159158
'rsrc/css/sprite-projects.css' => '7578fa56',
160159
'rsrc/css/sprite-tokens.css' => '1706b943',
@@ -333,8 +332,6 @@
333332
'rsrc/image/sprite-main-header.png' => '83521873',
334333
'rsrc/image/sprite-menu-X2.png' => '39d78f97',
335334
'rsrc/image/sprite-menu.png' => '259dab45',
336-
'rsrc/image/sprite-minicons-X2.png' => '55377e4e',
337-
'rsrc/image/sprite-minicons.png' => '272644ea',
338335
'rsrc/image/sprite-payments.png' => 'd8576309',
339336
'rsrc/image/sprite-projects-X2.png' => '218fdc8b',
340337
'rsrc/image/sprite-projects.png' => '631ff9a7',
@@ -780,7 +777,7 @@
780777
'phui-form-css' => 'b78ec020',
781778
'phui-form-view-css' => 'ebac1b1d',
782779
'phui-header-view-css' => '39594ac0',
783-
'phui-icon-view-css' => 'd8526aa1',
780+
'phui-icon-view-css' => 'b4963a4f',
784781
'phui-image-mask-css' => '5a8b09c8',
785782
'phui-info-panel-css' => '27ea50a1',
786783
'phui-list-view-css' => '43ed2d93',
@@ -823,7 +820,6 @@
823820
'sprite-login-css' => '878ee4d8',
824821
'sprite-main-header-css' => '92720ee2',
825822
'sprite-menu-css' => '28281e16',
826-
'sprite-minicons-css' => 'df4f76fe',
827823
'sprite-payments-css' => 'cc085d44',
828824
'sprite-projects-css' => '7578fa56',
829825
'sprite-tokens-css' => '1706b943',

resources/sprite/manifest/minicons.json

Lines changed: 0 additions & 51 deletions
This file was deleted.
-3.8 KB
Binary file not shown.
-3.8 KB
Binary file not shown.
-3.8 KB
Binary file not shown.
-3.8 KB
Binary file not shown.
-6.83 KB
Binary file not shown.
-6.83 KB
Binary file not shown.
-6.83 KB
Binary file not shown.
-6.83 KB
Binary file not shown.

0 commit comments

Comments
 (0)