Skip to content

Commit 7db7e1a

Browse files
authored
feat: tmp disable pg_net on macos and allow for server start on macos (#1289)
Co-authored-by: Sam Rose <samuel@supabase.io>
1 parent d7902e5 commit 7db7e1a

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

flake.nix

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@
128128
# use, but even if they did, keeping our own copies means that we can
129129
# rollout new versions of these critical things easier without having to
130130
# go through the upstream release engineering process.
131-
ourExtensions = [
131+
ourExtensions = let
132+
baseExtensions = [
132133
./nix/ext/rum.nix
133134
./nix/ext/timescaledb.nix
134135
./nix/ext/pgroonga.nix
@@ -147,7 +148,6 @@
147148
./nix/ext/pg_cron.nix
148149
./nix/ext/pgsql-http.nix
149150
./nix/ext/pg_plan_filter.nix
150-
./nix/ext/pg_net.nix
151151
./nix/ext/pg_hashids.nix
152152
./nix/ext/pgsodium.nix
153153
./nix/ext/pg_graphql.nix
@@ -162,7 +162,13 @@
162162
./nix/ext/supautils.nix
163163
./nix/ext/plv8.nix
164164
];
165+
166+
# Add pg_net only if NOT on macOS aarch64
167+
pgNetExtension = if (system == "aarch64-darwin")
168+
then []
169+
else [ ./nix/ext/pg_net.nix ];
165170

171+
in baseExtensions ++ pgNetExtension;
166172
#Where we import and build the orioledb extension, we add on our custom extensions
167173
# plus the orioledb option
168174
orioledbExtension = ourExtensions ++ [ ./nix/ext/orioledb.nix ];
@@ -462,7 +468,8 @@
462468
--subst-var-by 'LOCALES' '${localeArchive}' \
463469
--subst-var-by 'EXTENSION_CUSTOM_SCRIPTS_DIR' "$out/extension-custom-scripts" \
464470
--subst-var-by 'MECAB_LIB' '${basePackages.psql_15.exts.pgroonga}/lib/groonga/plugins/tokenizers/tokenizer_mecab.so' \
465-
--subst-var-by 'GROONGA_DIR' '${supabase-groonga}'
471+
--subst-var-by 'GROONGA_DIR' '${supabase-groonga}' \
472+
--subst-var-by 'CURRENT_SYSTEM' '${system}'
466473
467474
chmod +x $out/bin/start-postgres-server
468475
'';

nix/tools/run-server.sh.in

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,14 @@ EXTENSION_CUSTOM_SCRIPTS=@EXTENSION_CUSTOM_SCRIPTS_DIR@
3232
GROONGA=@GROONGA_DIR@
3333
DATDIR=$(mktemp -d)
3434
LOCALE_ARCHIVE=@LOCALES@
35+
CURRENT_SYSTEM=@CURRENT_SYSTEM@
3536
export LOCALE_ARCHIVE
3637
export LANG=en_US.UTF-8
3738
export LANGUAGE=en_US.UTF-8
3839
export LC_ALL=en_US.UTF-8
3940
export LANG=en_US.UTF-8
4041
export LC_CTYPE=en_US.UTF-8
42+
echo "Current system is $CURRENT_SYSTEM"
4143
mkdir -p "$DATDIR"
4244
echo "NOTE: using port $PORTNO for server"
4345
echo "NOTE: using temporary directory $DATDIR for data, which will not be removed"
@@ -61,5 +63,10 @@ pgsodium.getkey_script = '$PGSODIUM_GETKEY_SCRIPT'" \
6163
-e "\$a\\
6264
session_preload_libraries = 'supautils'" \
6365
"$PSQL_CONF_FILE" > "$DATDIR/postgresql.conf"
66+
if [ "$CURRENT_SYSTEM" = "aarch64-darwin" ]; then
67+
echo "NOTE: using aarch64-darwin system"
68+
sed -i '' 's/ pg_net,//g' "$DATDIR/postgresql.conf"
69+
sed -i '' 's/ pg_net,//g' "$DATDIR/supautils.conf"
70+
fi
6471
export GRN_PLUGINS_DIR=$GROONGA/lib/groonga/plugins
6572
postgres --config-file="$DATDIR/postgresql.conf" -p "$PORTNO" -D "$DATDIR" -k /tmp

0 commit comments

Comments
 (0)