chore: fix flaky AMI test

Author: soedirgo

testinfra/test_ami.py

@@ -8,9 +8,10 @@
 import testinfra
 from ec2instanceconnectcli.EC2InstanceConnectLogger import EC2InstanceConnectLogger
 from ec2instanceconnectcli.EC2InstanceConnectKey import EC2InstanceConnectKey
+from paramiko.ssh_exception import NoValidConnectionsError
 from time import sleep
 
-RUN_ID = os.environ["GITHUB_RUN_ID"] if os.environ["GITHUB_RUN_ID"] else "unknown-ci-run"
+RUN_ID = os.environ.get("GITHUB_RUN_ID", "unknown-ci-run")
 
 postgresql_schema_sql_content = """
 ALTER DATABASE postgres SET "app.settings.jwt_secret" TO  'my_jwt_secret_which_is_not_so_secret';
@@ -251,39 +252,43 @@ def gzip_then_base64_encode(s: str) -> str:
     )
 
     def is_healthy(host) -> bool:
-        cmd = host.run("pg_isready -U postgres")
-        if cmd.failed is True:
-            logger.warn("pg not ready")
-            return False
+        try:
+            cmd = host.run("pg_isready -U postgres")
+            if cmd.failed is True:
+                logger.warn("pg not ready")
+                return False
 
-        cmd = host.run(f"curl -sf -k https://localhost:8085/health -H 'apikey: {supabase_admin_key}'")
-        if cmd.failed is True:
-            logger.warn("adminapi not ready")
-            return False
+            cmd = host.run(f"curl -sf -k https://localhost:8085/health -H 'apikey: {supabase_admin_key}'")
+            if cmd.failed is True:
+                logger.warn("adminapi not ready")
+                return False
 
-        cmd = host.run("curl -sf http://localhost:3001/ready")
-        if cmd.failed is True:
-            logger.warn("postgrest not ready")
-            return False
+            cmd = host.run("curl -sf http://localhost:3001/ready")
+            if cmd.failed is True:
+                logger.warn("postgrest not ready")
+                return False
 
-        cmd = host.run("curl -sf http://localhost:8081/health")
-        if cmd.failed is True:
-            logger.warn("gotrue not ready")
-            return False
+            cmd = host.run("curl -sf http://localhost:8081/health")
+            if cmd.failed is True:
+                logger.warn("gotrue not ready")
+                return False
 
-        cmd = host.run("sudo kong health")
-        if cmd.failed is True:
-            logger.warn("kong not ready")
-            return False
+            cmd = host.run("sudo kong health")
+            if cmd.failed is True:
+                logger.warn("kong not ready")
+                return False
 
-        cmd = host.run("printf \\\\0 > '/dev/tcp/localhost/6543'")
-        if cmd.failed is True:
-            logger.warn("pgbouncer not ready")
-            return False
+            cmd = host.run("printf \\\\0 > '/dev/tcp/localhost/6543'")
+            if cmd.failed is True:
+                logger.warn("pgbouncer not ready")
+                return False
 
-        cmd = host.run("sudo fail2ban-client status")
-        if cmd.failed is True:
-            logger.warn("fail2ban not ready")
+            cmd = host.run("sudo fail2ban-client status")
+            if cmd.failed is True:
+                logger.warn("fail2ban not ready")
+                return False
+        except NoValidConnectionsError:
+            logger.warn("unable to connect via ssh")
             return False
 
         return True