Add a breadcrumbs element

Summary:
Add a basic breadcrumbs element, and implement it in Paste.

This needs some polish but is most of the way there.

Test Plan:
{F26443}
{F26444}
{F26445}

(This element is not visible on devices.)

Reviewers: chad

Reviewed By: chad

CC: aran, btrahan

Maniphest Tasks: T1960

Differential Revision: https://secure.phabricator.com/D4087

Author: epriestley

scripts/celerity_mapper.php

@@ -22,8 +22,6 @@
     'javelin-typeahead-preloaded-source',
     'javelin-typeahead-ondemand-source',
     'javelin-tokenizer',
-    'javelin-fx',
-    'javelin-color',
   ),
   'core.pkg.js' => array(
     'javelin-behavior-aphront-basic-tokenizer',

src/__phutil_library_map__.php

@@ -656,6 +656,8 @@
     'PhabricatorCountdownEditController' => 'applications/countdown/controller/PhabricatorCountdownEditController.php',
     'PhabricatorCountdownListController' => 'applications/countdown/controller/PhabricatorCountdownListController.php',
     'PhabricatorCountdownViewController' => 'applications/countdown/controller/PhabricatorCountdownViewController.php',
+    'PhabricatorCrumbView' => 'view/layout/PhabricatorCrumbView.php',
+    'PhabricatorCrumbsView' => 'view/layout/PhabricatorCrumbsView.php',
     'PhabricatorCursorPagedPolicyAwareQuery' => 'infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php',
     'PhabricatorDaemon' => 'infrastructure/daemon/PhabricatorDaemon.php',
     'PhabricatorDaemonCombinedLogController' => 'applications/daemon/controller/PhabricatorDaemonCombinedLogController.php',
@@ -1905,6 +1907,8 @@
     'PhabricatorCountdownEditController' => 'PhabricatorCountdownController',
     'PhabricatorCountdownListController' => 'PhabricatorCountdownController',
     'PhabricatorCountdownViewController' => 'PhabricatorCountdownController',
+    'PhabricatorCrumbView' => 'AphrontView',
+    'PhabricatorCrumbsView' => 'AphrontView',
     'PhabricatorCursorPagedPolicyAwareQuery' => 'PhabricatorPolicyAwareQuery',
     'PhabricatorDaemon' => 'PhutilDaemon',
     'PhabricatorDaemonCombinedLogController' => 'PhabricatorDaemonController',

src/applications/base/controller/PhabricatorController.php

@@ -247,4 +247,28 @@ protected function buildApplicationMenu() {
     return null;
   }
 
+  protected function buildApplicationCrumbs() {
+
+    $crumbs = array();
+
+    $application = $this->getCurrentApplication();
+    if ($application) {
+      $sprite = $application->getAutospriteName();
+      if (!$sprite) {
+        $sprite = 'default';
+      }
+
+      $crumbs[] = id(new PhabricatorCrumbView())
+        ->setHref($this->getApplicationURI())
+        ->setIcon('temporary-icon-apps');
+    }
+
+    $view = new PhabricatorCrumbsView();
+    foreach ($crumbs as $crumb) {
+      $view->addCrumb($crumb);
+    }
+
+    return $view;
+  }
+
 }

src/applications/directory/controller/PhabricatorDirectoryMainController.php

@@ -496,7 +496,7 @@ private function buildAppPanel() {
       'Share Files');
     $nav_buttons[] = array(
       'Create Paste',
-      '/paste/',
+      '/paste/create/',
       'create-paste',
       'Share Text');
 

src/applications/paste/application/PhabricatorApplicationPaste.php

@@ -22,8 +22,9 @@ public function getRoutes() {
     return array(
       '/P(?P<id>[1-9]\d*)' => 'PhabricatorPasteViewController',
       '/paste/' => array(
-        '' => 'PhabricatorPasteEditController',
-        'edit/(?P<id>[1-9]\d*)/' => 'PhabricatorPasteEditController',
+        ''                        => 'PhabricatorPasteListController',
+        'create/'                 => 'PhabricatorPasteEditController',
+        'edit/(?P<id>[1-9]\d*)/'  => 'PhabricatorPasteEditController',
         'filter/(?P<filter>\w+)/' => 'PhabricatorPasteListController',
       ),
     );

src/applications/paste/controller/PhabricatorPasteController.php

@@ -2,37 +2,41 @@
 
 abstract class PhabricatorPasteController extends PhabricatorController {
 
-  public function buildSideNavView(PhabricatorPaste $paste = null) {
+  public function buildSideNavView($filter = null, $for_app = false) {
     $user = $this->getRequest()->getUser();
 
     $nav = new AphrontSideNavFilterView();
     $nav->setBaseURI(new PhutilURI($this->getApplicationURI('filter/')));
 
-    if ($paste) {
-      $nav->addFilter('paste', 'P'.$paste->getID(), '/P'.$paste->getID());
-      $nav->addSpacer();
+    if ($for_app) {
+      $nav->addFilter('', 'Create Paste', $this->getApplicationURI('/create/'));
     }
 
-    $nav->addLabel('Create');
-    $nav->addFilter(
-      'edit',
-      'New Paste',
-      $this->getApplicationURI(),
-      $relative = false,
-      $class = ($user->isLoggedIn() ? null : 'disabled'));
-
-    $nav->addSpacer();
-    $nav->addLabel('Pastes');
+    $nav->addLabel('Filters');
+    $nav->addFilter('all', 'All Pastes');
     if ($user->isLoggedIn()) {
       $nav->addFilter('my', 'My Pastes');
     }
-    $nav->addFilter('all', 'All Pastes');
+
+    $nav->selectFilter($filter, 'all');
 
     return $nav;
   }
 
   public function buildApplicationMenu() {
-    return $this->buildSideNavView(null)->getMenu();
+    return $this->buildSideNavView(null, true)->getMenu();
+  }
+
+  public function buildApplicationCrumbs() {
+    $crumbs = parent::buildApplicationCrumbs();
+
+    $crumbs->addAction(
+      id(new PhabricatorMenuItemView())
+        ->setName(pht('Create Paste'))
+        ->setHref($this->getApplicationURI('create/'))
+        ->setIcon('create'));
+
+    return $crumbs;
   }
 
 }

src/applications/paste/controller/PhabricatorPasteEditController.php

@@ -173,27 +173,35 @@ public function processRequest() {
 
     if (!$is_create) {
       $submit->addCancelButton($paste->getURI());
-      $submit->setValue('Save Paste');
-      $title = 'Edit '.$paste->getFullName();
+      $submit->setValue(pht('Save Paste'));
+      $title = pht('Edit %s', $paste->getFullName());
+      $short = pht('Edit');
     } else {
-      $submit->setValue('Create Paste');
-      $title = 'Create Paste';
+      $submit->setValue(pht('Create Paste'));
+      $title = pht('Create Paste');
+      $short = pht('Create');
     }
 
     $form
       ->appendChild($submit);
 
-    $nav = $this->buildSideNavView();
-    $nav->selectFilter('edit');
-    $nav->appendChild(
+    $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
+    if (!$is_create) {
+      $crumbs->addCrumb(
+        id(new PhabricatorCrumbView())
+          ->setName('P'.$paste->getID())
+          ->setHref('/P'.$paste->getID()));
+    }
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())->setName($short));
+
+    return $this->buildApplicationPage(
       array(
+        $crumbs,
         id(new PhabricatorHeaderView())->setHeader($title),
         $error_view,
         $form,
-      ));
-
-    return $this->buildApplicationPage(
-      $nav,
+      ),
       array(
         'title' => $title,
         'device' => true,

src/applications/paste/controller/PhabricatorPasteListController.php

@@ -19,8 +19,8 @@ public function processRequest() {
     $query = new PhabricatorPasteQuery();
     $query->setViewer($user);
 
-    $nav = $this->buildSideNavView();
-    $filter = $nav->selectFilter($this->filter, 'my');
+    $nav = $this->buildSideNavView($this->filter);
+    $filter = $nav->getSelectedFilter();
 
     switch ($filter) {
       case 'my':
@@ -45,6 +45,15 @@ public function processRequest() {
 
     $nav->appendChild($list);
 
+    $crumbs = $this
+      ->buildApplicationCrumbs($nav)
+      ->addCrumb(
+        id(new PhabricatorCrumbView())
+          ->setName($title)
+          ->setHref($this->getApplicationURI('filter/'.$filter.'/')));
+
+    $nav->setCrumbs($crumbs);
+
     return $this->buildApplicationPage(
       $nav,
       array(

src/applications/paste/controller/PhabricatorPasteViewController.php

@@ -51,19 +51,20 @@ public function processRequest() {
     $properties = $this->buildPropertyView($paste, $fork_phids);
     $source_code = $this->buildSourceCodeView($paste, $file);
 
-    $nav = $this->buildSideNavView($paste);
-    $nav->selectFilter('paste');
+    $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
+      ->addCrumb(
+        id(new PhabricatorCrumbView())
+          ->setName('P'.$paste->getID())
+          ->setHref('/P'.$paste->getID()));
 
-    $nav->appendChild(
+    return $this->buildApplicationPage(
       array(
+        $crumbs,
         $header,
         $actions,
         $properties,
         $source_code,
-      ));
-
-    return $this->buildApplicationPage(
-      $nav,
+      ),
       array(
         'title' => $paste->getFullName(),
         'device' => true,
@@ -87,6 +88,7 @@ private function buildActionView(
       PhabricatorPolicyCapability::CAN_EDIT);
 
     $can_fork = $user->isLoggedIn();
+    $fork_uri = $this->getApplicationURI('/create/?parent='.$paste->getID());
 
     return id(new PhabricatorActionListView())
       ->setUser($user)
@@ -97,7 +99,7 @@ private function buildActionView(
           ->setIcon('fork')
           ->setDisabled(!$can_fork)
           ->setWorkflow(!$can_fork)
-          ->setHref($this->getApplicationURI('?parent='.$paste->getID())))
+          ->setHref($fork_uri))
       ->addAction(
         id(new PhabricatorActionView())
           ->setName(pht('View Raw File'))

src/view/layout/AphrontSideNavFilterView.php

@@ -29,11 +29,21 @@ final class AphrontSideNavFilterView extends AphrontView {
   private $user;
   private $active;
   private $menu;
+  private $crumbs;
 
   public function __construct() {
     $this->menu = new PhabricatorMenuView();
   }
 
+  public function setCrumbs(PhabricatorCrumbsView $crumbs) {
+    $this->crumbs = $crumbs;
+    return $this;
+  }
+
+  public function getCrumbs() {
+    return $this->crumbs;
+  }
+
   public function setActive($active) {
     $this->active = $active;
     return $this;
@@ -54,6 +64,10 @@ public function setFlexible($flexible) {
     return $this;
   }
 
+  public function getMenuView() {
+    return $this->menu;
+  }
+
   public function addMenuItem(PhabricatorMenuItemView $item) {
     $this->menu->addMenuItem($item);
     return $this;
@@ -120,6 +134,10 @@ public function selectFilter($key, $default = null) {
     return $this->selectedFilter;
   }
 
+  public function getSelectedFilter() {
+    return $this->selectedFilter;
+  }
+
   public function render() {
     if ($this->menu->getItems()) {
       if (!$this->baseURI) {
@@ -187,13 +205,20 @@ private function renderFlexNav() {
         self::renderSingleView($this->menu));
     }
 
+    $crumbs = null;
+    if ($this->crumbs) {
+      $crumbs = $this->crumbs->render();
+      $nav_classes[] = 'has-crumbs';
+    }
+
     Javelin::initBehavior(
       'phabricator-nav',
       array(
         'mainID'      => $main_id,
         'localID'     => $local_id,
         'dragID'      => $drag_id,
         'contentID'   => $content_id,
+        'menuSize'   => ($crumbs ? 78 : 44),
       ));
 
     if ($this->active && $local_id) {
@@ -204,17 +229,7 @@ private function renderFlexNav() {
         ));
     }
 
-    $header_part =
-      '<div class="phabricator-nav-head">'.
-        '<div class="phabricator-nav-head-tablet">'.
-          '<a href="#" class="nav-button nav-button-w nav-button-menu" '.
-            'id="tablet-menu1"></a>'.
-          '<a href="#" class="nav-button nav-button-e nav-button-content '.
-            'nav-button-selected" id="tablet-menu2"></a>'.
-        '</div>'.
-      '</div>';
-
-    return $header_part.phutil_render_tag(
+    return $crumbs.phutil_render_tag(
       'div',
       array(
         'class' => implode(' ', $nav_classes),