Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use headed Chrome for local Cypress runs #3

Merged
merged 2 commits into from
Jun 3, 2021
Merged

chore: use headed Chrome for local Cypress runs #3

merged 2 commits into from
Jun 3, 2021

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Jun 3, 2021 •
edited
Loading

  • Use headed Chrome for local Cypress runs (works with PNPM)
  • Clean up ci configuration for the e2e execution target

@LayZeeDK LayZeeDK requested a review from santoshyadavdev June 3, 2021 14:54
@LayZeeDK LayZeeDK marked this pull request as ready for review June 3, 2021 14:55
santoshyadavdev
santoshyadavdev approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@santoshyadavdev santoshyadavdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this was quick 🔥

@santoshyadavdev santoshyadavdev merged commit 0b55cde into main Jun 3, 2021
@santoshyadavdev santoshyadavdev deleted the chore/fix-cypress-locally branch June 3, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santoshyadavdev santoshyadavdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LayZeeDK @santoshyadavdev