Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Scully and deployment to GitHub Pages #5

Merged
merged 16 commits into from
Jun 5, 2021

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Jun 3, 2021

  • Add Scully
  • Add deploy job targeting GitHub Pages
  • Disable Jekyll processing in GitHub Pages
  • Rename workspace configuration to angular.json and downgrade it to schema version 1 to be compatible with Scully

Copy link
Member

@santoshyadavdev santoshyadavdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow you are on fire today

@LayZeeDK
Copy link
Member Author

LayZeeDK commented Jun 3, 2021

Something's wrong with the build 🤔
https://this-is-learning.github.io/this-is-learning-website/

main.ae29df18f4488b785834.js:formatted:1984 ERROR TypeError: Cannot read property '11' of null
    at iu (main.ae29df18f4488b785834.js:formatted:7841)
    at template (main.ae29df18f4488b785834.js:formatted:11655)
    at Nr (main.ae29df18f4488b785834.js:formatted:2721)
    at Pr (main.ae29df18f4488b785834.js:formatted:2581)
    at Yr (main.ae29df18f4488b785834.js:formatted:2898)
    at main.ae29df18f4488b785834.js:formatted:2588
    at Pr (main.ae29df18f4488b785834.js:formatted:2589)
    at Ao.create (main.ae29df18f4488b785834.js:formatted:4583)
    at t.bootstrap (main.ae29df18f4488b785834.js:formatted:5460)
    at main.ae29df18f4488b785834.js:formatted:5329

Maybe we should disable build optimizations temporarily to identify the problem.

@santoshyadavdev santoshyadavdev marked this pull request as ready for review June 5, 2021 15:49
@santoshyadavdev santoshyadavdev merged commit 2312532 into main Jun 5, 2021
@santoshyadavdev santoshyadavdev deleted the feat/add-scully branch June 5, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants