Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use production build #8

Merged
merged 37 commits into from
Jun 5, 2021
Merged

ci: use production build #8

merged 37 commits into from
Jun 5, 2021

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Jun 5, 2021 •
edited
Loading

  • Use production build
  • Use Yarn because NGCC does not support PNPM's node_modules structure which causes issues with Scully
  • Optimize NGCC
  • Only deploy after automated tests pass
  • Extract SCAMs from single-file component files
  • Disable Scully prompts
  • Include render time in welcome message

@LayZeeDK LayZeeDK changed the title ci: temporarily enable development deployment from feature branch ci: use production build Jun 5, 2021
@LayZeeDK LayZeeDK marked this pull request as ready for review June 5, 2021 22:14
@LayZeeDK LayZeeDK merged commit 42f7f0f into main Jun 5, 2021
@LayZeeDK LayZeeDK deleted the ci/kick-scully branch June 5, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LayZeeDK