Skip to content

Commit 20768d6

Browse files
author
vrana
committed
Convert phutil_render_tag(X, Y, '...') to phutil_tag
Summary: Created with spatch: lang=diff - phutil_render_tag + phutil_tag (X, Y, '...') Then searched for `&` and `<` in the output and replaced them. Test Plan: Loaded homepage. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4503
1 parent 48561a8 commit 20768d6

File tree

86 files changed

+140
-140
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

86 files changed

+140
-140
lines changed

‎src/aphront/console/plugin/DarkConsoleServicesPlugin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ public function render() {
146146

147147
$results[] =
148148
'<div class="dark-console-panel-header">'.
149-
phutil_render_tag(
149+
phutil_tag(
150150
'a',
151151
array(
152152
'href' => $this->getRequestURI()->alter('__analyze__', true),

‎src/aphront/console/plugin/DarkConsoleXHProfPlugin.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function getXHProfRunID() {
3232
public function render() {
3333
if (!DarkConsoleXHProfPluginAPI::isProfilerAvailable()) {
3434
$href = PhabricatorEnv::getDoclink('article/Installation_Guide.html');
35-
$install_guide = phutil_render_tag(
35+
$install_guide = phutil_tag(
3636
'a',
3737
array(
3838
'href' => $href,
@@ -53,7 +53,7 @@ public function render() {
5353

5454
$header =
5555
'<div class="dark-console-panel-header">'.
56-
phutil_render_tag(
56+
phutil_tag(
5757
'a',
5858
array(
5959
'href' => $this->getRequestURI()->alter('__profile__', 'page'),

‎src/applications/auth/controller/PhabricatorMustVerifyEmailController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public function processRequest() {
5353
'action' => '/login/mustverify/',
5454
'method' => 'POST',
5555
),
56-
phutil_render_tag(
56+
phutil_tag(
5757
'button',
5858
array(
5959
),

‎src/applications/calendar/view/AphrontCalendarMonthView.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,18 +159,18 @@ private function renderCalendarHeader(DateTime $date) {
159159
$uri = new PhutilURI($uri);
160160
list($prev_year, $prev_month) = $this->getPrevYearAndMonth();
161161
$query = array('year' => $prev_year, 'month' => $prev_month);
162-
$prev_link = phutil_render_tag(
162+
$prev_link = phutil_tag(
163163
'a',
164164
array('href' => (string) $uri->setQueryParams($query)),
165-
'&larr;'
165+
"\xE2\x86\x90"
166166
);
167167

168168
list($next_year, $next_month) = $this->getNextYearAndMonth();
169169
$query = array('year' => $next_year, 'month' => $next_month);
170-
$next_link = phutil_render_tag(
170+
$next_link = phutil_tag(
171171
'a',
172172
array('href' => (string) $uri->setQueryParams($query)),
173-
'&rarr;'
173+
"\xE2\x86\x92"
174174
);
175175

176176
$left_th = '<th>'.$prev_link.'</th>';

‎src/applications/countdown/controller/PhabricatorCountdownListController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public function processRequest() {
2828
$delete_button = null;
2929
if ($user->getIsAdmin() ||
3030
($user->getPHID() == $timer->getAuthorPHID())) {
31-
$edit_button = phutil_render_tag(
31+
$edit_button = phutil_tag(
3232
'a',
3333
array(
3434
'class' => 'small button grey',

‎src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function processRequest() {
8181
$task->getLeaseOwner(),
8282
$task->getLeaseExpires() - time(),
8383
$task->getFailureCount(),
84-
phutil_render_tag(
84+
phutil_tag(
8585
'a',
8686
array(
8787
'href' => '/daemon/task/'.$task->getID().'/',

‎src/applications/daemon/view/PhabricatorDaemonLogListView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function render() {
8181
$log->getPID(),
8282
phabricator_date($epoch, $this->user),
8383
phabricator_time($epoch, $this->user),
84-
phutil_render_tag(
84+
phutil_tag(
8585
'a',
8686
array(
8787
'href' => '/daemon/log/'.$log->getID().'/',

‎src/applications/differential/controller/DifferentialDiffCreateController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public function processRequest() {
3030
$form = new AphrontFormView();
3131
$arcanist_href = PhabricatorEnv::getDoclink(
3232
'article/Arcanist_User_Guide.html');
33-
$arcanist_link = phutil_render_tag(
33+
$arcanist_link = phutil_tag(
3434
'a',
3535
array(
3636
'href' => $arcanist_href,

‎src/applications/differential/controller/DifferentialRevisionViewController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ public function processRequest() {
184184
'<p>'.pht('This diff is very large and affects %d files. Load '.
185185
'each file individually. ', $count).
186186
"<strong>".
187-
phutil_render_tag(
187+
phutil_tag(
188188
'a',
189189
array(
190190
'href' => $request_uri

‎src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public function build(array $changesets) {
9090
$icon = 'phabricator-filetree-icon-dir';
9191
}
9292

93-
$icon = phutil_render_tag(
93+
$icon = phutil_tag(
9494
'span',
9595
array(
9696
'class' => 'phabricator-filetree-icon '.$icon,

‎src/applications/differential/view/DifferentialDiffTableOfContentsView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ public function render() {
182182
$this->repository->getCallsign());
183183
if ($editor_link) {
184184
$editor_link =
185-
phutil_render_tag(
185+
phutil_tag(
186186
'a',
187187
array(
188188
'href' => $editor_link,

‎src/applications/differential/view/DifferentialInlineCommentEditView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ private function renderBody() {
104104

105105
$buttons = implode('', $buttons);
106106

107-
$formatting = phutil_render_tag(
107+
$formatting = phutil_tag(
108108
'a',
109109
array(
110110
'href' => PhabricatorEnv::getDoclink(

‎src/applications/differential/view/DifferentialInlineCommentView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ public function render() {
190190
if ($this->preview) {
191191
$anchor = null;
192192
} else {
193-
$anchor = phutil_render_tag(
193+
$anchor = phutil_tag(
194194
'a',
195195
array(
196196
'name' => $anchor_name,

‎src/applications/diffusion/controller/DiffusionCommitTagsController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function processRequest() {
3232
}
3333

3434
if ($has_more_tags) {
35-
$tag_links[] = phutil_render_tag(
35+
$tag_links[] = phutil_tag(
3636
'a',
3737
array(
3838
'href' => $request->generateURI(

‎src/applications/diffusion/controller/DiffusionController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ private function buildCrumbList(array $spec = array()) {
299299
$last_crumb = array_pop($crumb_list);
300300

301301
if ($raw_commit) {
302-
$jump_link = phutil_render_tag(
302+
$jump_link = phutil_tag(
303303
'a',
304304
array(
305305
'href' => $drequest->generateURI(

‎src/applications/diffusion/controller/DiffusionHomeController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ public function processRequest() {
146146
}
147147

148148
$repository_tool_uri = PhabricatorEnv::getProductionURI('/repository/');
149-
$repository_tool = phutil_render_tag('a',
149+
$repository_tool = phutil_tag('a',
150150
array(
151151
'href' => $repository_tool_uri,
152152
),

‎src/applications/diffusion/controller/DiffusionRepositoryController.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function processRequest() {
6060
$history_table->setIsHead(true);
6161

6262
$callsign = $drequest->getRepository()->getCallsign();
63-
$all = phutil_render_tag(
63+
$all = phutil_tag(
6464
'a',
6565
array(
6666
'href' => "/diffusion/{$callsign}/history/",
@@ -182,7 +182,7 @@ private function buildBranchListTable(DiffusionRequest $drequest) {
182182
}
183183

184184
$panel->addButton(
185-
phutil_render_tag(
185+
phutil_tag(
186186
'a',
187187
array(
188188
'href' => $drequest->generateURI(
@@ -240,7 +240,7 @@ private function buildTagListTable(DiffusionRequest $drequest) {
240240
}
241241

242242
$panel->addButton(
243-
phutil_render_tag(
243+
phutil_tag(
244244
'a',
245245
array(
246246
'href' => $drequest->generateURI(

‎src/applications/diffusion/view/DiffusionBranchTableView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function render() {
3636
}
3737

3838
$rows[] = array(
39-
phutil_render_tag(
39+
phutil_tag(
4040
'a',
4141
array(
4242
'href' => $drequest->generateURI(

‎src/applications/diffusion/view/DiffusionBrowseTableView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ public function render() {
204204
$request->getRepository()->getCallsign());
205205
if ($editor_link) {
206206
$show_edit = true;
207-
$editor_button = phutil_render_tag(
207+
$editor_button = phutil_tag(
208208
'a',
209209
array(
210210
'href' => $editor_link,

‎src/applications/diffusion/view/DiffusionView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ final public function linkHistory($path) {
4747
'path' => $path,
4848
));
4949

50-
return phutil_render_tag(
50+
return phutil_tag(
5151
'a',
5252
array(
5353
'href' => $href,

‎src/applications/directory/controller/PhabricatorDirectoryMainController.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ private function buildUnbreakNowPanel() {
109109
$panel->setHeader('Unbreak Now!');
110110
$panel->setCaption('Open tasks with "Unbreak Now!" priority.');
111111
$panel->addButton(
112-
phutil_render_tag(
112+
phutil_tag(
113113
'a',
114114
array(
115115
'href' => '/maniphest/view/all/',
@@ -154,7 +154,7 @@ private function buildNeedsTriagePanel(array $projects) {
154154
'<a href="/project/">projects you are a member of</a>.');
155155

156156
$panel->addButton(
157-
phutil_render_tag(
157+
phutil_tag(
158158
'a',
159159
array(
160160
// TODO: This should filter to just your projects' need-triage
@@ -198,7 +198,7 @@ private function buildRevisionPanel() {
198198
$panel->setCaption('Revisions waiting for you for review or commit.');
199199

200200
$panel->addButton(
201-
phutil_render_tag(
201+
phutil_tag(
202202
'a',
203203
array(
204204
'href' => '/differential/',
@@ -248,7 +248,7 @@ private function buildTasksPanel() {
248248
$panel->setHeader('Assigned Tasks');
249249

250250
$panel->addButton(
251-
phutil_render_tag(
251+
phutil_tag(
252252
'a',
253253
array(
254254
'href' => '/maniphest/',
@@ -294,7 +294,7 @@ private function buildJumpPanel($query=null) {
294294
require_celerity_resource('phabricator-jump-nav');
295295

296296
$doc_href = PhabricatorEnv::getDocLink('article/Jump_Nav_User_Guide.html');
297-
$doc_link = phutil_render_tag(
297+
$doc_link = phutil_tag(
298298
'a',
299299
array(
300300
'href' => $doc_href,
@@ -381,7 +381,7 @@ public function buildAuditPanel() {
381381
$panel->setCaption('Commits awaiting your audit.');
382382
$panel->appendChild($view);
383383
$panel->addButton(
384-
phutil_render_tag(
384+
phutil_tag(
385385
'a',
386386
array(
387387
'href' => '/audit/',
@@ -426,7 +426,7 @@ public function buildCommitPanel() {
426426
$panel->setCaption('Commits which auditors have raised concerns about.');
427427
$panel->appendChild($view);
428428
$panel->addButton(
429-
phutil_render_tag(
429+
phutil_tag(
430430
'a',
431431
array(
432432
'href' => '/audit/',

‎src/applications/fact/controller/PhabricatorFactChartController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public function processRequest() {
5353
$y = array_values($points);
5454

5555
$id = celerity_generate_unique_node_id();
56-
$chart = phutil_render_tag(
56+
$chart = phutil_tag(
5757
'div',
5858
array(
5959
'id' => $id,

‎src/applications/files/controller/PhabricatorFileUploadController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ private function renderUploadLimit() {
104104

105105
$doc_href = PhabricatorEnv::getDocLink(
106106
'article/Configuring_File_Upload_Limits.html');
107-
$doc_link = phutil_render_tag(
107+
$doc_link = phutil_tag(
108108
'a',
109109
array(
110110
'href' => $doc_href,

‎src/applications/flag/view/PhabricatorFlagListView.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public function render() {
2020
$class = PhabricatorFlagColor::getCSSClass($flag->getColor());
2121

2222
$rows[] = array(
23-
phutil_render_tag(
23+
phutil_tag(
2424
'div',
2525
array(
2626
'class' => 'phabricator-flag-icon '.$class,
@@ -36,7 +36,7 @@ public function render() {
3636
'action' => '/flag/edit/'.$flag->getObjectPHID().'/',
3737
'sigil' => 'workflow',
3838
),
39-
phutil_render_tag(
39+
phutil_tag(
4040
'button',
4141
array(
4242
'class' => 'small grey',
@@ -49,7 +49,7 @@ public function render() {
4949
'action' => '/flag/delete/'.$flag->getID().'/',
5050
'sigil' => 'workflow',
5151
),
52-
phutil_render_tag(
52+
phutil_tag(
5353
'button',
5454
array(
5555
'class' => 'small grey',

‎src/applications/herald/controller/HeraldHomeController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public function processRequest() {
9898

9999
if ($can_create) {
100100
$panel->addButton(
101-
phutil_render_tag(
101+
phutil_tag(
102102
'a',
103103
array(
104104
'href' => '/herald/new/'.$this->contentType.'/'.$this->ruleType.'/',

‎src/applications/herald/controller/HeraldTranscriptListController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function processRequest() {
5858
$handles[$xscript['objectPHID']]->renderLink(),
5959
$xscript['dryRun'] ? 'Yes' : '',
6060
number_format((int)(1000 * $xscript['duration'])).' ms',
61-
phutil_render_tag(
61+
phutil_tag(
6262
'a',
6363
array(
6464
'href' => '/herald/transcript/'.$xscript['id'].'/',

‎src/applications/herald/view/HeraldRuleListView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function render() {
5151
),
5252
$rule->getName());
5353

54-
$edit_log = phutil_render_tag(
54+
$edit_log = phutil_tag(
5555
'a',
5656
array(
5757
'href' => '/herald/history/'.$rule->getID().'/',

‎src/applications/mailinglists/controller/PhabricatorMailingListsListController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public function processRequest() {
3333
$rows[] = array(
3434
phutil_escape_html($list->getName()),
3535
phutil_escape_html($list->getEmail()),
36-
phutil_render_tag(
36+
phutil_tag(
3737
'a',
3838
array(
3939
'class' => 'button grey small',

0 commit comments

Comments
 (0)