Unconditionally enable drag-and-drop uploads for Remarkup text areas

Summary: Make these always work. Notably, this makes them work in Maniphest. Previously this was at odds with stuff fixed in D3651.

Test Plan: Dragged and dropped files into Remarkup in Maniphest.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3652

Author: epriestley

src/applications/differential/view/DifferentialAddCommentView.php

@@ -133,7 +133,6 @@ public function render() {
           ->setName('comment')
           ->setID('comment-content')
           ->setLabel('Comment')
-          ->setEnableDragAndDropFileUploads(true)
           ->setValue($this->draft ? $this->draft->getDraft() : null))
       ->appendChild(
         id(new AphrontFormSubmitControl())

src/applications/phame/controller/post/PhamePostEditController.php

@@ -259,7 +259,6 @@ public function processRequest() {
         ->setName('body')
         ->setValue($post->getBody())
         ->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL)
-        ->setEnableDragAndDropFileUploads(true)
         ->setID('post-body')
       )
       ->appendChild(

src/applications/phriction/controller/PhrictionEditController.php

@@ -223,8 +223,7 @@ public function processRequest() {
           ->setValue($content_text)
           ->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL)
           ->setName('content')
-          ->setID('document-textarea')
-          ->setEnableDragAndDropFileUploads(true))
+          ->setID('document-textarea'))
       ->appendChild(
         id(new AphrontFormTextControl())
           ->setLabel('Edit Notes')

src/applications/ponder/view/PonderAddAnswerView.php

@@ -60,8 +60,7 @@ public function render() {
           ->setName('answer')
           ->setLabel('Answer')
           ->setError(true)
-          ->setID('answer-content')
-          ->setEnableDragAndDropFileUploads(true))
+          ->setID('answer-content'))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue($is_serious ? 'Submit' : 'Make it so.'));

src/applications/ponder/view/PonderAddCommentView.php

@@ -60,8 +60,7 @@ public function render() {
       ->addHiddenInput('question_id', $questionID)
       ->appendChild(
         id(new AphrontFormTextAreaControl())
-          ->setName('content')
-        ->setEnableDragAndDropFileUploads(false))
+          ->setName('content'))
       ->appendChild(
         id(new AphrontFormSubmitControl())
           ->setValue($is_serious ? 'Submit' : 'Editorialize'));

src/view/form/control/AphrontFormTextAreaControl.php

@@ -48,11 +48,6 @@ protected function getCustomControlClass() {
     return 'aphront-form-control-textarea';
   }
 
-  public function setEnableDragAndDropFileUploads($enable) {
-    $this->enableDragAndDropFileUploads = $enable;
-    return $this;
-  }
-
   public function setCustomClass($custom_class) {
     $this->customClass = $custom_class;
     return $this;
@@ -74,20 +69,6 @@ protected function renderInput() {
     $classes[] = $this->customClass;
     $classes = trim(implode(' ', $classes));
 
-    $id = $this->getID();
-    if ($this->enableDragAndDropFileUploads) {
-      if (!$id) {
-        $id = celerity_generate_unique_node_id();
-      }
-      Javelin::initBehavior(
-        'aphront-drag-and-drop-textarea',
-        array(
-          'target'          => $id,
-          'activatedClass'  => 'aphront-textarea-drag-and-drop',
-          'uri'             => '/file/dropupload/',
-        ));
-    }
-
     return phutil_render_tag(
       'textarea',
       array(
@@ -96,7 +77,7 @@ protected function renderInput() {
         'readonly'  => $this->getReadonly() ? 'readonly' : null,
         'class'     => $classes,
         'style'     => $this->getControlStyle(),
-        'id'        => $id,
+        'id'        => $this->getID(),
       ),
       phutil_escape_html($this->getValue()));
   }

src/view/form/control/PhabricatorRemarkupControl.php

@@ -19,6 +19,19 @@
 final class PhabricatorRemarkupControl extends AphrontFormTextAreaControl {
 
   protected function renderInput() {
+    $id = $this->getID();
+    if (!$id) {
+      $id = celerity_generate_unique_node_id();
+      $this->setID($id);
+    }
+
+    Javelin::initBehavior(
+      'aphront-drag-and-drop-textarea',
+      array(
+        'target'          => $id,
+        'activatedClass'  => 'aphront-textarea-drag-and-drop',
+        'uri'             => '/file/dropupload/',
+      ));
 
     Javelin::initBehavior('phabricator-remarkup-assist', array());
     Javelin::initBehavior('phabricator-tooltips', array());