Add breadcrumbs and ApplicationSearch to Phriction

Summary: Fixes T3631. Also adds ApplicationSearch.

Test Plan: Viewed "New", "Edit"; saw breadcrumbs. Viewed "index", saw application search.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3631

Differential Revision: https://secure.phabricator.com/D6593

Author: epriestley

src/__phutil_library_map__.php

@@ -1863,6 +1863,7 @@
     'PhrictionNewController' => 'applications/phriction/controller/PhrictionNewController.php',
     'PhrictionPHIDTypeDocument' => 'applications/phriction/phid/PhrictionPHIDTypeDocument.php',
     'PhrictionRemarkupRule' => 'applications/phriction/remarkup/PhrictionRemarkupRule.php',
+    'PhrictionSearchEngine' => 'applications/phriction/query/PhrictionSearchEngine.php',
     'PhrictionSearchIndexer' => 'applications/phriction/search/PhrictionSearchIndexer.php',
     'PonderAddAnswerView' => 'applications/ponder/view/PonderAddAnswerView.php',
     'PonderAddCommentView' => 'applications/ponder/view/PonderAddCommentView.php',
@@ -3957,11 +3958,16 @@
     'PhrictionDocumentTestCase' => 'PhabricatorTestCase',
     'PhrictionEditController' => 'PhrictionController',
     'PhrictionHistoryController' => 'PhrictionController',
-    'PhrictionListController' => 'PhrictionController',
+    'PhrictionListController' =>
+    array(
+      0 => 'PhrictionController',
+      1 => 'PhabricatorApplicationSearchResultsControllerInterface',
+    ),
     'PhrictionMoveController' => 'PhrictionController',
     'PhrictionNewController' => 'PhrictionController',
     'PhrictionPHIDTypeDocument' => 'PhabricatorPHIDType',
     'PhrictionRemarkupRule' => 'PhutilRemarkupRule',
+    'PhrictionSearchEngine' => 'PhabricatorApplicationSearchEngine',
     'PhrictionSearchIndexer' => 'PhabricatorSearchDocumentIndexer',
     'PonderAddAnswerView' => 'AphrontView',
     'PonderAddCommentView' => 'AphrontView',

src/applications/phriction/application/PhabricatorApplicationPhriction.php

@@ -42,8 +42,7 @@ public function getRoutes() {
       '/w/(?P<slug>.+/)' => 'PhrictionDocumentController',
 
       '/phriction/' => array(
-        ''                       => 'PhrictionListController',
-        'list/(?P<view>[^/]+)/'  => 'PhrictionListController',
+        '(?:query/(?P<queryKey>[^/]+)/)?' => 'PhrictionListController',
 
         'history(?P<slug>/)'     => 'PhrictionHistoryController',
         'history/(?P<slug>.+/)'  => 'PhrictionHistoryController',

src/applications/phriction/controller/PhrictionController.php

@@ -5,45 +5,28 @@
  */
 abstract class PhrictionController extends PhabricatorController {
 
-  public function buildStandardPageResponse($view, array $data) {
-
-    $page = $this->buildStandardPageView();
-
-    $page->setApplicationName(pht('Phriction'));
-    $page->setBaseURI('/w/');
-    $page->setTitle(idx($data, 'title'));
-    $page->setGlyph("\xE2\x9A\xA1");
-
-    $page->appendChild($view);
-    $page->setSearchDefaultScope(PhabricatorSearchScope::SCOPE_WIKI);
-
-    $response = new AphrontWebpageResponse();
-    return $response->setContent($page->render());
-  }
-
-  public function buildSideNavView($filter = null, $for_app = false) {
+  public function buildSideNavView($for_app = false) {
     $user = $this->getRequest()->getUser();
 
     $nav = new AphrontSideNavFilterView();
-    $nav->setBaseURI(new PhutilURI('/phriction/list/'));
+    $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
 
     if ($for_app) {
-      $nav->addFilter('', pht('Root Document'), '/w/');
-      $nav->addFilter('', pht('New Document'), '/phriction/new');
+      $nav->addFilter('create', pht('New Document'));
+      $nav->addFilter('/phriction/', pht('Index'));
     }
 
-    $nav->addLabel(pht('Filters'));
-    $nav->addFilter('active', pht('Active Documents'));
-    $nav->addFilter('all', pht('All Documents'));
-    $nav->addFilter('updates', pht('Recently Updated'));
+    id(new PhrictionSearchEngine())
+      ->setViewer($user)
+      ->addNavigationItems($nav->getMenu());
 
-    $nav->selectFilter($filter, 'active');
+    $nav->selectFilter(null);
 
     return $nav;
   }
 
   public function buildApplicationMenu() {
-    return $this->buildSideNavView(null, true)->getMenu();
+    return $this->buildSideNavView(true)->getMenu();
   }
 
   public function buildApplicationCrumbs() {

src/applications/phriction/controller/PhrictionEditController.php

@@ -248,11 +248,26 @@ public function processRequest() {
         'uri'       => '/phriction/preview/?draftkey='.$draft_key,
       ));
 
+    $crumbs = $this->buildApplicationCrumbs();
+    if ($document->getID()) {
+      $crumbs->addCrumb(
+        id(new PhabricatorCrumbView())
+          ->setName($content->getTitle())
+          ->setHref(PhrictionDocument::getSlugURI($document->getSlug())));
+      $crumbs->addCrumb(
+        id(new PhabricatorCrumbView())
+          ->setName(pht('Edit')));
+    } else {
+      $crumbs->addCrumb(
+        id(new PhabricatorCrumbView())
+          ->setName(pht('Create')));
+    }
+
     return $this->buildApplicationPage(
       array(
+        $crumbs,
         $draft_note,
         $error_view,
-        $header,
         $form,
         $preview_panel,
       ),